Using arrow functions changes `this` context, which is undesired in tests, e.g. it makes it impossible to setup things like pretender (`this.server`) in `beforeEach` hooks. Ember guides always use classic functions in examples (e.g. https://guides.emberjs.com/release/testing/test-types/), and that's what it uses in its own test suite, as do various addons and ember apps. It was also already used in Discourse where `this` was required. Moving forward, it will be needed in more places as we migrate toward ember-cli. (I might later add a custom rule to eslint-discourse-ember to enforce this)
52 lines
1.3 KiB
JavaScript
52 lines
1.3 KiB
JavaScript
import { visit } from "@ember/test-helpers";
|
|
import { test } from "qunit";
|
|
import I18n from "I18n";
|
|
import selectKit from "discourse/tests/helpers/select-kit-helper";
|
|
import { withPluginApi } from "discourse/lib/plugin-api";
|
|
import { clearTopicFooterButtons } from "discourse/lib/register-topic-footer-button";
|
|
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
|
|
|
|
let _test;
|
|
|
|
acceptance("Topic footer buttons mobile", function (needs) {
|
|
needs.user();
|
|
needs.mobileView();
|
|
|
|
needs.hooks.beforeEach(() => {
|
|
I18n.translations[I18n.locale].js.test = {
|
|
title: "My title",
|
|
label: "My Label",
|
|
};
|
|
|
|
withPluginApi("0.8.28", (api) => {
|
|
api.registerTopicFooterButton({
|
|
id: "my-button",
|
|
icon: "user",
|
|
label: "test.label",
|
|
title: "test.title",
|
|
dropdown: true,
|
|
action() {
|
|
_test = 2;
|
|
},
|
|
});
|
|
});
|
|
});
|
|
|
|
needs.hooks.afterEach(() => {
|
|
clearTopicFooterButtons();
|
|
_test = undefined;
|
|
});
|
|
|
|
test("default", async function (assert) {
|
|
await visit("/t/internationalization-localization/280");
|
|
|
|
assert.equal(_test, null);
|
|
|
|
const subject = selectKit(".topic-footer-mobile-dropdown");
|
|
await subject.expand();
|
|
await subject.selectRowByValue("my-button");
|
|
|
|
assert.equal(_test, 2);
|
|
});
|
|
});
|