Using arrow functions changes `this` context, which is undesired in tests, e.g. it makes it impossible to setup things like pretender (`this.server`) in `beforeEach` hooks. Ember guides always use classic functions in examples (e.g. https://guides.emberjs.com/release/testing/test-types/), and that's what it uses in its own test suite, as do various addons and ember apps. It was also already used in Discourse where `this` was required. Moving forward, it will be needed in more places as we migrate toward ember-cli. (I might later add a custom rule to eslint-discourse-ember to enforce this)
45 lines
1.3 KiB
JavaScript
45 lines
1.3 KiB
JavaScript
import { exists } from "discourse/tests/helpers/qunit-helpers";
|
|
import { visit, currentURL } from "@ember/test-helpers";
|
|
import { test } from "qunit";
|
|
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
|
|
|
|
acceptance("Unknown", function (needs) {
|
|
const urls = {
|
|
"viewtopic.php": "/t/internationalization-localization/280",
|
|
"not-the-url-for-faq": "/faq",
|
|
};
|
|
|
|
needs.pretender((server, helper) => {
|
|
server.get("/permalink-check.json", (request) => {
|
|
let url = urls[request.queryParams.path];
|
|
if (url) {
|
|
return helper.response({
|
|
found: true,
|
|
internal: true,
|
|
target_url: url,
|
|
});
|
|
} else {
|
|
return helper.response({
|
|
found: false,
|
|
html: "<div class='page-not-found'>not found</div>",
|
|
});
|
|
}
|
|
});
|
|
});
|
|
|
|
test("Permalink Unknown URL", async function (assert) {
|
|
await visit("/url-that-doesn't-exist");
|
|
assert.ok(exists(".page-not-found"), "The not found content is present");
|
|
});
|
|
|
|
test("Permalink URL to a Topic", async function (assert) {
|
|
await visit("/viewtopic.php?f=8&t=280");
|
|
assert.equal(currentURL(), "/t/internationalization-localization/280");
|
|
});
|
|
|
|
test("Permalink URL to a static page", async function (assert) {
|
|
await visit("/not-the-url-for-faq");
|
|
assert.equal(currentURL(), "/faq");
|
|
});
|
|
});
|