osr-plastic/osr-discourse-src
Archived
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.
bbe2947742
osr-discourse-src/app/assets/javascripts/discourse
History
Krzysztof Kotlarek b47b1d8af8 FIX: label helpers on sign up form are not hidden (#8603) 
This commit fe9293b8b5 created a regression.

The problem is that dom changed a little bit.
Before it was
```
<tr class="instructions create-account-email">
  <td></td>
  <div id="account-email-validation" class="tip bad ember-view"></div>
  <td><label>Never shown to the public.</label></td>
</tr>
```

And after we got
```
<tr class="instructions create-account-email">
  <td></td>
  <div id="account-email-validation" class="tip bad ember-view"> </div>
  <td><label>Never shown to the public.</label></td>
</tr>
```
That small space may look like not important change.

However, now helpers are hitting that CSS rule:

```
.login-form {
  .tip {
    &:not(:empty) + td {
      display: none;
    }
}
```

To fix it, we should render template only if there is a reason - like it was before

```
if (reason) {
  buffer.push(iconHTML(this.good ? "check" : "times") + " " + reason);
}
```

* FIX: remove rerenderTriggers
2019-12-20 12:17:51 +01:00
..
adapters FEATURE: Tag synonyms 2019-12-04 13:33:51 -05:00
components FIX: label helpers on sign up form are not hidden (#8603) 2019-12-20 12:17:51 +01:00
controllers Revert "Rename 'target usernames' with 'target recipients' in Composer (#8468)" 2019-12-20 11:56:20 +02:00
helpers FIX: Reorder categories not working 2019-12-10 12:36:47 -07:00
initializers FEATURE: Modal for profile featured topic & admin wrench refactor (#8545) 2019-12-16 08:41:34 -08:00
lib FEATURE: Keyboard shortcut for opening the topic admin menu (#8568) 2019-12-19 14:18:14 -05:00
mixins Revert "Rename 'target usernames' with 'target recipients' in Composer (#8468)" 2019-12-20 11:56:20 +02:00
models Revert "Rename 'target usernames' with 'target recipients' in Composer (#8468)" 2019-12-20 11:56:20 +02:00
pre-initializers DEV: Add unambiguous routes for tags 2019-12-13 11:24:59 +00:00
raw-views DEV: Move computed to discourseComputed (#8312) 2019-11-07 15:38:28 -06:00
routes Revert "Rename 'target usernames' with 'target recipients' in Composer (#8468)" 2019-12-20 11:56:20 +02:00
services DEV: Move computed to discourseComputed (#8312) 2019-11-07 15:38:28 -06:00
templates FIX: label helpers on sign up form are not hidden (#8603) 2019-12-20 12:17:51 +01:00
widgets FEATURE: Keyboard shortcut for opening the topic admin menu (#8568) 2019-12-19 14:18:14 -05:00
mapping-router.js.es6 DEV: Remove Discourse.Site in favor of import (#8344) 2019-11-13 12:13:47 -05:00