c07f1e442f
This commit fixes the UpdateUserLastRead spec which was checking for a message ID that did not exist -- this could fail at times since message ID 2 could exist. Better to create + destroy a message since then it's guaranteed we have a unique ID. This also attempts to clarify a step that we expect to fail which succeeds instead by adding another emoji next to the success tick and an explanation text. Also removes some uses of unless in Services::Base, we generally prefer to use alternatives, since unless can be hard to parse in a lot of cases. Co-authored-by: Loïc Guitaut <loic@discourse.org> |
||
|---|---|---|
| .. | ||
| discourse_dev | ||
| email_controller_helper | ||
| extensions | ||
| onebox/templates | ||
| tasks | ||
| validators | ||
| chat_channel_archive_service.rb | ||
| chat_channel_fetcher.rb | ||
| chat_channel_hashtag_data_source.rb | ||
| chat_channel_membership_manager.rb | ||
| chat_mailer.rb | ||
| chat_message_bookmarkable.rb | ||
| chat_message_creator.rb | ||
| chat_message_processor.rb | ||
| chat_message_rate_limiter.rb | ||
| chat_message_reactor.rb | ||
| chat_message_updater.rb | ||
| chat_notifier.rb | ||
| chat_review_queue.rb | ||
| chat_seeder.rb | ||
| chat_statistics.rb | ||
| chat_transcript_service.rb | ||
| direct_message_channel_creator.rb | ||
| duplicate_message_validator.rb | ||
| endpoint.rb | ||
| guardian_extensions.rb | ||
| message_mover.rb | ||
| post_notification_handler.rb | ||
| secure_uploads_compatibility.rb | ||
| slack_compatibility.rb | ||
| steps_inspector.rb | ||