This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.

Alan Guo Xiang Tan c245b74398 FIX: Avoid leaking TopicTrackingState listeners due to sidebar (#18131) ... In eb12daa7f8 when adding community section support for anonymous users, we changed the `sectionLinks` property into a getter method. This meant that if the getter method was called again after the community section has been rendered, we would end up reintializing the section links classes. As part of the initialisation, some section links would setup a TopicTrackingState onStateChange listener. However, the listener is only removed when the entire community section is removed which resulted in us leaking the onStateChange listeners. This commit reverts the `sectionLinks` from being defined as a getter method into a property which is only set once when the community section is being constructor. Also, we changed it such that the community section will register the listener instead of each section link since it makes cleaning up much easier to reason about. No tests have been added for this commit because the original bug is not possible after this change and we already have an existing tests ensuring that TopicTrackingState change listeners are cleaned up when the community section is destroyed. Internal ref: /t/73224		2022-08-30 11:39:32 +08:00
..
admin	DEV: Add A11Y-friendly dialog addon (#18028)	2022-08-29 13:59:57 -04:00
confirm-new-email	DEV: Update linting setup and fix issues (#17345)	2022-07-06 10:37:54 +02:00
discourse	FIX: Avoid leaking TopicTrackingState listeners due to sidebar (#18131)	2022-08-30 11:39:32 +08:00
discourse-common	FIX: Track native class deps in discourseComputed (#18023)	2022-08-22 17:33:32 +02:00
discourse-ensure-deprecation-order	DEV: Silence 3.x deprecations	2022-07-19 10:00:59 +01:00
discourse-hbr	DEV: Introduce flag for compiling Plugin JS with Ember CLI (#17965)	2022-08-22 09:56:39 +01:00
discourse-plugins	FIX: Load admin-specific JS when compiling via ember-cli (#18086)	2022-08-25 11:36:02 +01:00
discourse-widget-hbs	DEV: Add jsconfig (#17800)	2022-08-04 22:50:47 +01:00
docs	DEV: enforces eslint’s curly rule to the codebase (#10720)	2020-09-22 16:28:28 +02:00
ember-addons	DEV: Remove ember-addons (#9559)	2020-04-28 10:14:49 -04:00
ember-cli-progress-ci	DEV: Add progress output in CI during ember-cli build (#17977)	2022-08-17 22:39:52 +01:00
locales	FEATURE: Add Croatian language (#17130)	2022-06-18 00:18:22 +02:00
pretty-text	DEV: Add jsconfig (#17800)	2022-08-04 22:50:47 +01:00
select-kit	DEV: Add select-kit option to hide values from preview (#18002)	2022-08-19 11:39:58 -05:00
truth-helpers	DEV: Update @embroider/test-setup (#17625)	2022-07-24 17:29:21 +02:00
wizard	DEV: plugin outlet for wizard checkboxes (#18113)	2022-08-26 17:03:30 -04:00
.licensee.json	DEV: Add Ember CLI workspace license checks (#16603)	2022-05-03 13:06:19 -04:00
.npmrc	DEV: Prevent npm usage (#13945)	2021-08-04 22:04:58 +02:00
admin-plugins.js.erb	FIX: When using Ember CLI, plugin admin code was not being loaded in tests (#16239)	2022-03-21 15:46:41 -04:00
handlebars-shim.js	FIX: It seems sometimes shims are evaluated by older JS engines (#11813)	2021-01-22 10:41:01 -05:00
mini-loader.js	DEV: Support inline-hbs compilation in themes (#18112)	2022-08-29 19:53:42 +01:00
package.json	DEV: Introduce flag for compiling Plugin JS with Ember CLI (#17965)	2022-08-22 09:56:39 +01:00
polyfills.js	DEV: Add polyfill for String.prototype.replaceAll (#16301)	2022-03-28 17:18:56 +01:00
service-worker.js.erb	FIX: Disable service worker proxying in chrome 97-97.0.4692 (#15638)	2022-01-18 19:41:25 +00:00
yarn.lock	DEV: Support inline-hbs compilation in themes (#18112)	2022-08-29 19:53:42 +01:00