Krzysztof Kotlarek
b47b1d8af8
This commit https://github.com/discourse/discourse/commit/fe9293b8b554ab79636faa61a4756d5ff514a233 created a regression. The problem is that dom changed a little bit. Before it was ``` <tr class="instructions create-account-email"> <td></td> <div id="account-email-validation" class="tip bad ember-view"></div> <td><label>Never shown to the public.</label></td> </tr> ``` And after we got ``` <tr class="instructions create-account-email"> <td></td> <div id="account-email-validation" class="tip bad ember-view"> </div> <td><label>Never shown to the public.</label></td> </tr> ``` That small space may look like not important change. However, now helpers are hitting that CSS rule: ``` .login-form { .tip { &:not(:empty) + td { display: none; } } ``` To fix it, we should render template only if there is a reason - like it was before ``` if (reason) { buffer.push(iconHTML(this.good ? "check" : "times") + " " + reason); } ``` * FIX: remove rerenderTriggers
4 lines
54 B
Handlebars
4 lines
54 B
Handlebars
{{#if tipReason}}
|
|
{{tipIcon}} {{tipReason}}
|
|
{{/if}}
|