Recent changes surfaced the various issues with this codepath: - we were not correctly reseting `messageLookup` leading to us trying to scroll to a non existing message in the view - we were calling markAsRead which would scroll to the bottom, even if we had a target message - we were not debouncing fetchMessages, which could cause multiple reload of the messages when loading it with a targetMessageId: first fetch from last read and then immediately fetch from targetMessageId - other naming inconsistencies - not handling drawer This commit also adds tests for classic scenarios related to this use case. |
||
|---|---|---|
| .. | ||
| chat-api.js | ||
| chat-audio-manager.js | ||
| chat-channel-info-route-origin-manager.js | ||
| chat-channels-manager.js | ||
| chat-composer-presence-manager.js | ||
| chat-emoji-picker-manager.js | ||
| chat-emoji-reaction-store.js | ||
| chat-guardian.js | ||
| chat-message-visibility-observer.js | ||
| chat-notification-manager.js | ||
| chat-state-manager.js | ||
| chat-subscriptions-manager.js | ||
| chat.js | ||
| emoji-picker-scroll-observer.js | ||