ecc3c404a0
* FIX: Cache missing inline oneboxes Some inline oneboxes were not cached when the server did not return an answer for an URL and the queried URL and the absolute URL were different. For example, if user typed www.example.com, the client asked the server for http://www.example.com and if the server returned an empty response, then the client would keep requesting an inline onebox everytime the composer changed. In other words, the key used for reading (the absolute URL) and the one used for writing (the URL as typed by the user) were not the same when the server returned an empty response. * DEV: Check cache before making request There is another cache check in PrettyText, but that is not enough if multiple requests are pending. This problem was made obvious in tests, but can happen for users with slow connections.
83 lines
3.0 KiB
JavaScript
83 lines
3.0 KiB
JavaScript
import { acceptance, queryAll } from "discourse/tests/helpers/qunit-helpers";
|
|
import { click, fillIn, visit } from "@ember/test-helpers";
|
|
import { test } from "qunit";
|
|
|
|
acceptance("Composer - Onebox", function (needs) {
|
|
needs.user();
|
|
needs.settings({
|
|
max_oneboxes_per_post: 2,
|
|
enable_markdown_linkify: true,
|
|
});
|
|
|
|
test("Preview update should respect max_oneboxes_per_post site setting", async function (assert) {
|
|
await visit("/t/internationalization-localization/280");
|
|
await click("#topic-footer-buttons .btn.create");
|
|
|
|
await fillIn(
|
|
".d-editor-input",
|
|
`
|
|
http://www.example.com/has-title.html
|
|
This is another test http://www.example.com/has-title.html
|
|
|
|
http://www.example.com/no-title.html
|
|
|
|
This is another test http://www.example.com/no-title.html
|
|
This is another test http://www.example.com/has-title.html
|
|
|
|
http://www.example.com/has-title.html
|
|
`
|
|
);
|
|
|
|
assert.equal(
|
|
queryAll(".d-editor-preview:visible").html().trim(),
|
|
`
|
|
<p><aside class=\"onebox\"><article class=\"onebox-body\"><h3><a href=\"http://www.example.com/article.html\">An interesting article</a></h3></article></aside><br>
|
|
This is another test <a href=\"http://www.example.com/has-title.html\" class=\"inline-onebox\">This is a great title</a></p>
|
|
<p><a href=\"http://www.example.com/no-title.html\" class=\"onebox\" target=\"_blank\">http://www.example.com/no-title.html</a></p>
|
|
<p>This is another test <a href=\"http://www.example.com/no-title.html\" class=\"\">http://www.example.com/no-title.html</a><br>
|
|
This is another test <a href=\"http://www.example.com/has-title.html\" class=\"inline-onebox\">This is a great title</a></p>
|
|
<p><aside class=\"onebox\"><article class=\"onebox-body\"><h3><a href=\"http://www.example.com/article.html\">An interesting article</a></h3></article></aside></p>
|
|
`.trim()
|
|
);
|
|
});
|
|
});
|
|
|
|
acceptance("Composer - Inline Onebox", function (needs) {
|
|
needs.user();
|
|
needs.settings({
|
|
max_oneboxes_per_post: 2,
|
|
enable_markdown_linkify: true,
|
|
markdown_linkify_tlds: "com",
|
|
});
|
|
|
|
let requestsCount;
|
|
|
|
needs.pretender((server, helper) => {
|
|
server.get("/inline-onebox", () => {
|
|
++requestsCount;
|
|
return helper.response({ "inline-oneboxes": [] });
|
|
});
|
|
});
|
|
|
|
test("Uses cached inline onebox", async function (assert) {
|
|
requestsCount = 0;
|
|
|
|
await visit("/t/internationalization-localization/280");
|
|
await click("#topic-footer-buttons .btn.create");
|
|
|
|
await fillIn(".d-editor-input", `Test www.example.com/page`);
|
|
assert.equal(requestsCount, 1);
|
|
assert.equal(
|
|
queryAll(".d-editor-preview").html().trim(),
|
|
'<p>Test <a href="http://www.example.com/page" class="inline-onebox-loading">www.example.com/page</a></p>'
|
|
);
|
|
|
|
await fillIn(".d-editor-input", `Test www.example.com/page Test`);
|
|
assert.equal(requestsCount, 1);
|
|
assert.equal(
|
|
queryAll(".d-editor-preview").html().trim(),
|
|
'<p>Test <a href="http://www.example.com/page">www.example.com/page</a> Test</p>'
|
|
);
|
|
});
|
|
});
|