This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.
osr-discourse-src/app/assets/javascripts/pretty-text
Keegan George eb987460f2
FEATURE: Select emojis in picker via keyboard (#18163)
* DEV: Make emoji elements focusable

Since emoji elements are of type `<img>` it requires a `tablindex="0"` in order to be focusable.

* WIP: Handle emoji focus/selection via arrow keys

Near completion, however, need a few fixes/improvements and overall code cleanup

* WIP: Testing

* DEV: Fixes and cleanup

* DEV: Follow conventions

* DEV: Improve up/down traversal when recents present

* DEV: Emoji markup in tests should include `tabindex`

* DEV: Add `tabindex` to topic tests

* DEV: Variable name as `searchInput` instead of `searchBar`

* DEV: Use appropriate method name (`_setNumEmojiPerRow`)

* DEV: Add comments and avoid nested if

* WIP: Adding test

* Fix first test

* DEV: Add assertions for arrow keys and escape key

* Some fixes for up/down navigation

This does not fix everything, when going from one section to another,
there are issues

* Fix a small regression

* FIX: Ability to focus on search results

Fixes regression

* Refactor calculating next up/down emoji

* Debugging test failure

* Skip stubborn CI test, add others

Co-authored-by: Penar Musaraj <pmusaraj@gmail.com>
2022-09-21 13:21:36 -07:00
..
addon FEATURE: Select emojis in picker via keyboard (#18163) 2022-09-21 13:21:36 -07:00
app DEV: Move pretty-text into an ember-addon format (#9689) 2020-05-07 12:37:47 -04:00
config DEV: Upgrade to Ember 3.28 2022-07-19 10:00:59 +01:00
engines/discourse-markdown FIX: Empty inline BBCodes were broken (#18276) 2022-09-20 09:50:22 +10:00
tests DEV: Make addons buildable on their own (#17205) 2022-06-23 22:19:54 +02:00
vendor DEV: Ember Addon needs a vendor dir 2020-05-07 15:45:35 -04:00
.npmrc DEV: Prevent npm usage (#13945) 2021-08-04 22:04:58 +02:00
ember-cli-build.js DEV: Upgrade to Ember 3.28 2022-07-19 10:00:59 +01:00
index.js REFACTOR: Support bundling our admin section as an ember addon 2020-09-22 15:14:29 -04:00
jsconfig.json DEV: Add jsconfig (#17800) 2022-08-04 22:50:47 +01:00
package.json Build(deps): Bump webpack in /app/assets/javascripts (#18214) 2022-09-11 22:35:55 +02:00