This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.
osr-discourse-src/app/assets/javascripts/discourse
Jarek Radosz f0b2e77abb
FIX: Isolate modal and global key-binds (#12477)
This change makes is so that when a time-picking modal (e.g.  "Add bookmark" modal) is visible, **all** global key bindings are paused.

1. Fixes an issue where opening and closing a time-picking modal would break global single-key keybinds, so for example, <kbd>L</kbd> would no longer like posts, but <kbd>L</kbd> <kbd>L</kbd> would
2. Fixes a related issue, where doing the above would also override custom keybinds provided by plugins (e.g. <kbd>L</kbd> shortcut that discourse-reactions uses)

Included:

* DEV: Reset Mousetraps instead of unbinding
* FIX: Make unbind use unbind
* DEV: Don't check for keyTrapper twice
* DEV: Use an instance of Mousetrap
* DEV: Remove an invalid `for` attribute (`set_reminder` doesn't exist)
* DEV: Add ability to pause all KeyboardShortcuts
* FIX: Pause all keybinds when in a time-picking modal
* DEV: Move bookmark keybind resets to willDestroyElement
* DEV: Fix shortcuts-related tests
2021-03-29 13:58:03 +02:00
..
app FIX: Isolate modal and global key-binds (#12477) 2021-03-29 13:58:03 +02:00
config DEV: Use Ember CLI middleware to decorate the index template (#12292) 2021-03-09 10:09:35 -05:00
lib Support for Testem in Ember CLI (#12442) 2021-03-19 09:32:46 -04:00
public/assets/scripts REFACTOR: Use a <script src> tag to start the app (#12401) 2021-03-16 09:36:11 -04:00
tests FIX: Isolate modal and global key-binds (#12477) 2021-03-29 13:58:03 +02:00
.ember-cli REFACTOR: Sync up master with changes for Ember-CLI (#11671) 2021-01-12 10:13:21 -05:00
ember-cli-build.js Support for Testem in Ember CLI (#12442) 2021-03-19 09:32:46 -04:00
package.json Support for Testem in Ember CLI (#12442) 2021-03-19 09:32:46 -04:00
testem.js Support for Testem in Ember CLI (#12442) 2021-03-19 09:32:46 -04:00
yarn.lock DEV: Migrate to Ember CLI (#11932) 2021-02-03 14:22:20 -05:00