This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.

Martin Brennan 002c676344 DEV: Topic tracking state improvements (#12958) ... Original PR which had to be reverted **https://github.com/discourse/discourse/pull/12555**. See the description there for what this PR is achieving, plus below. The issue with the original PR is addressed in 92ef54f402 If you went to the `x unread` link for a tag Chrome would freeze up and possibly crash, or eventually unfreeze after nearly 10 mins. Other routes for unread/new were similarly slow. From profiling the issue was the `sync` function of `topic-tracking-state.js`, which calls down to `isNew` which in turn calls `moment`, a change I had made in the PR above. The time it takes locally with ~1400 topics in the tracking state is 2.3 seconds. To solve this issue, I have moved these calculations for "created in new period" and "unread not too old" into the tracking state serializer. When I was looking at the profiler I also noticed this issue which was just compounding the problem. Every time we modify topic tracking state we recalculate the sidebar tracking/everything/tag counts. However this calls `forEachTracked` and `countTags` which can be quite expensive as they go through the whole tracking state (and were also calling the removed moment functions). I added some logs and this was being called 30 times when navigating to a new /unread route because `sync` is being called from `build-topic-route` (one for each topic loaded due to pagination). So I just added a debounce here and it makes things even faster. Finally, I changed topic tracking state to use a Map so our counts of the state keys is faster (Maps have .size whereas objects you have to do Object.keys(obj) which is O(n).)		2021-05-31 09:22:28 +10:00
..
actions-summary-test.js	DEV: Migrate more tests to our Ember CLI format. (#11899)	2021-02-01 09:01:47 -05:00
avatar-flair-test.js	DEV: Migrate more tests to our Ember CLI format. (#11899)	2021-02-01 09:01:47 -05:00
button-test.js	FIX: Tests were broken in Firefox (#12456)	2021-03-22 11:35:51 +11:00
default-notification-item-test.js	DEV: Support Node 15 with Ember CLI (#12679)	2021-04-14 10:16:39 -04:00
hamburger-menu-test.js	DEV: Topic tracking state improvements (#12958)	2021-05-31 09:22:28 +10:00
header-test.js	DEV: Migrate more tests to our Ember CLI format. (#11899)	2021-02-01 09:01:47 -05:00
home-logo-test.js	DEV: Migrate more tests to our Ember CLI format. (#11899)	2021-02-01 09:01:47 -05:00
post-links-test.js	DEV: Migrate more tests to our Ember CLI format. (#11899)	2021-02-01 09:01:47 -05:00
post-menu-test.js	DEV: Migrate more tests to our Ember CLI format. (#11899)	2021-02-01 09:01:47 -05:00
post-stream-test.js	DEV: Migrate more tests to our Ember CLI format. (#11899)	2021-02-01 09:01:47 -05:00
post-test.js	DEV: Correct typos and spelling mistakes (#12812)	2021-05-21 11:43:47 +10:00
poster-name-test.js	DEV: Migrate more tests to our Ember CLI format. (#11899)	2021-02-01 09:01:47 -05:00
quick-access-item-test.js	DEV: Migrate more tests to our Ember CLI format. (#11899)	2021-02-01 09:01:47 -05:00
small-user-list-test.js	DEV: Correct typos and spelling mistakes (#12812)	2021-05-21 11:43:47 +10:00
software-update-prompt-test.js	FIX: Software update prompt fixes and improvements (#12648)	2021-04-14 10:26:23 +10:00
topic-admin-menu-test.js	FIX: Clean up topic-timer-info CSS classes, add edit button, and improve UI (#12080)	2021-02-16 12:07:30 +10:00
topic-participant-test.js	DEV: Migrate more tests to our Ember CLI format. (#11899)	2021-02-01 09:01:47 -05:00
topic-status-test.js	DEV: Migrate more tests to our Ember CLI format. (#11899)	2021-02-01 09:01:47 -05:00
user-menu-test.js	DEV: Migrate more tests to our Ember CLI format. (#11899)	2021-02-01 09:01:47 -05:00
widget-dropdown-test.js	DEV: Migrate more tests to our Ember CLI format. (#11899)	2021-02-01 09:01:47 -05:00
widget-test.js	DEV: Correct typos and spelling mistakes (#12812)	2021-05-21 11:43:47 +10:00