ac7bf98ad1
Our method of loading a subset of client settings into tests via
tests/helpers/site-settings.js can be improved upon. Currently we have a
hardcoded subset of the client settings, which may get out of date and not have
the correct defaults. As well as this plugins do not get their settings into the
tests, so whenever you need a setting from a plugin, even if it has a default,
you have to do needs.setting({ ... }) which is inconvenient.
This commit introduces an ember CLI build step to take the site_settings.yml and
all the plugin settings.yml files, pull out the client settings, and dump them
into a variable in a single JS file we can load in our tests, so we have the
correct selection of settings and default values in our JS tests. It also fixes
many, many tests that were operating under incorrect assumptions or old
settings.
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
63 lines
2.3 KiB
JavaScript
63 lines
2.3 KiB
JavaScript
import {
|
|
acceptance,
|
|
exists,
|
|
normalizeHtml,
|
|
query,
|
|
visible,
|
|
} from "discourse/tests/helpers/qunit-helpers";
|
|
import { click, fillIn, triggerKeyEvent, visit } from "@ember/test-helpers";
|
|
import { test } from "qunit";
|
|
import { IMAGE_VERSION as v } from "pretty-text/emoji/version";
|
|
|
|
acceptance("Emoji", function (needs) {
|
|
needs.user();
|
|
|
|
test("emoji is cooked properly", async function (assert) {
|
|
await visit("/t/internationalization-localization/280");
|
|
await click("#topic-footer-buttons .btn.create");
|
|
|
|
await fillIn(".d-editor-input", "this is an emoji :blonde_woman:");
|
|
assert.ok(visible(".d-editor-preview"));
|
|
assert.strictEqual(
|
|
normalizeHtml(query(".d-editor-preview").innerHTML.trim()),
|
|
normalizeHtml(
|
|
`<p>this is an emoji <img src="/images/emoji/twitter/blonde_woman.png?v=${v}" title=":blonde_woman:" class="emoji" alt=":blonde_woman:" loading="lazy" width="20" height="20" style="aspect-ratio: 20 / 20;"></p>`
|
|
)
|
|
);
|
|
});
|
|
|
|
test("skin toned emoji is cooked properly", async function (assert) {
|
|
await visit("/t/internationalization-localization/280");
|
|
await click("#topic-footer-buttons .btn.create");
|
|
|
|
await fillIn(".d-editor-input", "this is an emoji :blonde_woman:t5:");
|
|
|
|
assert.ok(visible(".d-editor-preview"));
|
|
assert.strictEqual(
|
|
normalizeHtml(query(".d-editor-preview").innerHTML.trim()),
|
|
normalizeHtml(
|
|
`<p>this is an emoji <img src="/images/emoji/twitter/blonde_woman/5.png?v=${v}" title=":blonde_woman:t5:" class="emoji" alt=":blonde_woman:t5:" loading="lazy" width="20" height="20" style="aspect-ratio: 20 / 20;"></p>`
|
|
)
|
|
);
|
|
});
|
|
|
|
needs.settings({
|
|
emoji_autocomplete_min_chars: 2,
|
|
});
|
|
|
|
test("siteSetting:emoji_autocomplete_min_chars", async function (assert) {
|
|
await visit("/t/internationalization-localization/280");
|
|
await click("#topic-footer-buttons .btn.create");
|
|
|
|
await fillIn(".d-editor-input", ":s");
|
|
await triggerKeyEvent(".d-editor-input", "keyup", "ArrowDown"); // ensures a keyup is triggered
|
|
|
|
assert.notOk(exists(".autocomplete.ac-emoji"));
|
|
|
|
await fillIn(".d-editor-input", ":sw");
|
|
await triggerKeyEvent(".d-editor-input", "keyup", "ArrowDown"); // ensures a keyup is triggered
|
|
|
|
assert.ok(exists(".autocomplete.ac-emoji"));
|
|
});
|
|
});
|