* SECURITY: Fix XSS in full name composer reply We are using htmlSafe when rendering the name field so we need to escape any html being passed in. * SECURITY: Monkey-patch web-push gem to use safer HTTP client `FinalDestination::HTTP` is our patch of `Net::HTTP` which defend us against SSRF and DNS rebinding attacks. * SECURITY: SSRF protection bypass with IPv4-mapped IPv6 addresses As part of this commit, we've also expanded our list of private IP ranges based on https://www.iana.org/assignments/iana-ipv4-special-registry/iana-ipv4-special-registry.xhtml and https://www.iana.org/assignments/iana-ipv6-special-registry/iana-ipv6-special-registry.xhtml * SECURITY: XSS on chat excerpts Non-markdown tags weren't being escaped in chat excerpts. This could be triggered by editing a chat message containing a tag (self XSS), or by replying to a chat message with a tag (XSS). Co-authored-by: Jan Cernik <jancernik12@gmail.com> * FIX: Escaped mentions in chat excerpts Mentions are now displayed as using the non-cooked message which fixes the problem. This is not ideal. I think we might want to rework how these excerpts are created and rendered in the near future. Co-authored-by: Jan Cernik <jancernik12@gmail.com> * SECURITY: Add FinalDestination::FastImage that's SSRF safe --------- Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com> Co-authored-by: Jan Cernik <jancernik12@gmail.com> Co-authored-by: Ted Johansson <ted@discourse.org> |
||
|---|---|---|
| .. | ||
| concerns | ||
| category_channel.rb | ||
| chat_channel_archive.rb | ||
| chat_channel.rb | ||
| chat_draft.rb | ||
| chat_mention.rb | ||
| chat_message_reaction.rb | ||
| chat_message_revision.rb | ||
| chat_message.rb | ||
| chat_thread.rb | ||
| chat_upload.rb | ||
| chat_view.rb | ||
| chat_webhook_event.rb | ||
| deleted_chat_user.rb | ||
| direct_message_channel.rb | ||
| direct_message_user.rb | ||
| direct_message.rb | ||
| incoming_chat_webhook.rb | ||
| reviewable_chat_message.rb | ||
| user_chat_channel_membership.rb | ||