From 1f11f1cf8b0730f5c1928f8d2adf4e5c204c9e2c Mon Sep 17 00:00:00 2001 From: Simon Edwards Date: Tue, 17 Aug 2021 22:34:13 +0200 Subject: [PATCH] Make `connectSignalsToEventEmitter()` virtual to support wrappers on plain Qt widget instances --- .../nodegui/QtCore/QAbstractItemModel/nabstractitemmodel.hpp | 2 +- src/cpp/include/nodegui/QtCore/QObject/nobject.hpp | 2 +- src/cpp/include/nodegui/QtGui/QApplication/napplication.hpp | 2 +- src/cpp/include/nodegui/QtGui/QDrag/ndrag.hpp | 2 +- src/cpp/include/nodegui/QtGui/QMovie/nmovie.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QAction/naction.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QBoxLayout/nboxlayout.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QButtonGroup/nbuttongroup.hpp | 2 +- .../nodegui/QtWidgets/QCalendarWidget/ncalendarwidget.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QCheckBox/ncheckbox.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QColorDialog/ncolordialog.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QComboBox/ncombobox.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QDateEdit/ndateedit.hpp | 2 +- .../include/nodegui/QtWidgets/QDateTimeEdit/ndatetimeedit.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QDial/ndial.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QDialog/ndialog.hpp | 2 +- .../include/nodegui/QtWidgets/QDoubleSpinBox/ndoublespinbox.hpp | 2 +- .../include/nodegui/QtWidgets/QErrorMessage/nerrormessage.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QFileDialog/nfiledialog.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QFontDialog/nfontdialog.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QFrame/nframe.hpp | 2 +- .../QtWidgets/QGraphicsBlurEffect/ngraphicsblureffect.hpp | 2 +- .../QGraphicsDropShadowEffect/ngraphicsdropshadoweffect.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QGridLayout/ngridlayout.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QGroupBox/ngroupbox.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QHeaderView/nheaderview.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QInputDialog/ninputdialog.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QLCDNumber/nlcdnumber.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QLabel/nlabel.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QLayout/nlayout.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QLineEdit/nlineedit.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QListView/nlistview.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QListWidget/nlistwidget.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QMainWindow/nmainwindow.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QMenu/nmenu.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QMenuBar/nmenubar.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QMessageBox/nmessagebox.hpp | 2 +- .../include/nodegui/QtWidgets/QPlainTextEdit/nplaintextedit.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QProgressBar/nprogressbar.hpp | 2 +- .../nodegui/QtWidgets/QProgressDialog/nprogressdialog.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QPushButton/npushbutton.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QRadioButton/nradiobutton.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QScrollArea/nscrollarea.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QScrollBar/nscrollbar.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QShortcut/nshortcut.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QSlider/nslider.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QSpinBox/nspinbox.hpp | 2 +- .../include/nodegui/QtWidgets/QStackedWidget/nstackedwidget.hpp | 2 +- .../nodegui/QtWidgets/QStandardItemModel/nstandarditemmodel.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QStatusBar/nstatusbar.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QSvgWidget/nsvgwidget.hpp | 2 +- .../nodegui/QtWidgets/QSystemTrayIcon/nsystemtrayicon.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QTabBar/ntabbar.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QTabWidget/ntabwidget.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QTableView/ntableview.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QTableWidget/ntablewidget.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QTextBrowser/ntextbrowser.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QTextEdit/ntextedit.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QTimeEdit/ntimeedit.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QToolButton/ntoolbutton.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QTreeWidget/ntreewidget.hpp | 2 +- src/cpp/include/nodegui/QtWidgets/QWidget/nwidget.hpp | 2 +- src/cpp/include/nodegui/core/Events/eventwidget.h | 2 +- src/cpp/include/nodegui/core/FlexLayout/flexlayout.hpp | 2 +- 64 files changed, 64 insertions(+), 64 deletions(-) diff --git a/src/cpp/include/nodegui/QtCore/QAbstractItemModel/nabstractitemmodel.hpp b/src/cpp/include/nodegui/QtCore/QAbstractItemModel/nabstractitemmodel.hpp index 6e3d68fc5..cb89f5262 100644 --- a/src/cpp/include/nodegui/QtCore/QAbstractItemModel/nabstractitemmodel.hpp +++ b/src/cpp/include/nodegui/QtCore/QAbstractItemModel/nabstractitemmodel.hpp @@ -14,7 +14,7 @@ class DLL_EXPORT NAbstractItemModel : public QAbstractItemModel, public: Napi::FunctionReference dispatchOnNode; - void connectSignalsToEventEmitter(){ + virtual void connectSignalsToEventEmitter(){ // Qt Connects: Implement all signal connects here QOBJECT_SIGNALS} diff --git a/src/cpp/include/nodegui/QtCore/QObject/nobject.hpp b/src/cpp/include/nodegui/QtCore/QObject/nobject.hpp index 8ae9c46f7..5d12a542f 100644 --- a/src/cpp/include/nodegui/QtCore/QObject/nobject.hpp +++ b/src/cpp/include/nodegui/QtCore/QObject/nobject.hpp @@ -12,5 +12,5 @@ class DLL_EXPORT NObject : public QObject, public EventWidget { public: using QObject::QObject; - void connectSignalsToEventEmitter() { QOBJECT_SIGNALS } + virtual void connectSignalsToEventEmitter() { QOBJECT_SIGNALS } }; diff --git a/src/cpp/include/nodegui/QtGui/QApplication/napplication.hpp b/src/cpp/include/nodegui/QtGui/QApplication/napplication.hpp index 5b01d47b4..2d9960f7a 100644 --- a/src/cpp/include/nodegui/QtGui/QApplication/napplication.hpp +++ b/src/cpp/include/nodegui/QtGui/QApplication/napplication.hpp @@ -12,7 +12,7 @@ class DLL_EXPORT NApplication : public QApplication, public EventWidget { EVENTWIDGET_IMPLEMENTATIONS(QApplication) public: using QApplication::QApplication; // inherit all constructors of QApplication - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { // Qt Connects: Implement all signal connects here QOBJECT_SIGNALS diff --git a/src/cpp/include/nodegui/QtGui/QDrag/ndrag.hpp b/src/cpp/include/nodegui/QtGui/QDrag/ndrag.hpp index c2d41846e..4898596f6 100644 --- a/src/cpp/include/nodegui/QtGui/QDrag/ndrag.hpp +++ b/src/cpp/include/nodegui/QtGui/QDrag/ndrag.hpp @@ -12,7 +12,7 @@ class DLL_EXPORT NDrag : public QDrag, public EventWidget { public: using QDrag::QDrag; - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QOBJECT_SIGNALS QObject::connect(this, &QDrag::actionChanged, [=](Qt::DropAction action) { Napi::Env env = this->emitOnNode.Env(); diff --git a/src/cpp/include/nodegui/QtGui/QMovie/nmovie.hpp b/src/cpp/include/nodegui/QtGui/QMovie/nmovie.hpp index b9159dbc6..ab103e8e4 100644 --- a/src/cpp/include/nodegui/QtGui/QMovie/nmovie.hpp +++ b/src/cpp/include/nodegui/QtGui/QMovie/nmovie.hpp @@ -14,7 +14,7 @@ class DLL_EXPORT NMovie : public QMovie, public EventWidget { public: using QMovie::QMovie; - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QOBJECT_SIGNALS // Qt Connects: Implement all signal connects here QObject::connect(this, &QMovie::error, diff --git a/src/cpp/include/nodegui/QtWidgets/QAction/naction.hpp b/src/cpp/include/nodegui/QtWidgets/QAction/naction.hpp index f28b0a80e..e100b73de 100644 --- a/src/cpp/include/nodegui/QtWidgets/QAction/naction.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QAction/naction.hpp @@ -11,7 +11,7 @@ class DLL_EXPORT NAction : public QAction, public EventWidget { EVENTWIDGET_IMPLEMENTATIONS(QAction) public: using QAction::QAction; // inherit all constructors of QAction - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { // Qt Connects: Implement all signal connects here QOBJECT_SIGNALS QObject::connect(this, &QAction::triggered, [=](bool checked) { diff --git a/src/cpp/include/nodegui/QtWidgets/QBoxLayout/nboxlayout.hpp b/src/cpp/include/nodegui/QtWidgets/QBoxLayout/nboxlayout.hpp index 0f5fb9eb1..1fc5fad40 100644 --- a/src/cpp/include/nodegui/QtWidgets/QBoxLayout/nboxlayout.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QBoxLayout/nboxlayout.hpp @@ -10,5 +10,5 @@ class DLL_EXPORT NBoxLayout : public QBoxLayout, public EventWidget { public: EVENTWIDGET_IMPLEMENTATIONS(QBoxLayout) using QBoxLayout::QBoxLayout; - void connectSignalsToEventEmitter() { QLAYOUT_SIGNALS } + virtual void connectSignalsToEventEmitter() { QLAYOUT_SIGNALS } }; diff --git a/src/cpp/include/nodegui/QtWidgets/QButtonGroup/nbuttongroup.hpp b/src/cpp/include/nodegui/QtWidgets/QButtonGroup/nbuttongroup.hpp index 2ec5d5d20..89040281c 100644 --- a/src/cpp/include/nodegui/QtWidgets/QButtonGroup/nbuttongroup.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QButtonGroup/nbuttongroup.hpp @@ -12,7 +12,7 @@ class DLL_EXPORT NButtonGroup : public QButtonGroup, public EventWidget { EVENTWIDGET_IMPLEMENTATIONS(QButtonGroup) public: using QButtonGroup::QButtonGroup; // inherit all constructors of QButtonGroup - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QOBJECT_SIGNALS // Qt Connects: Implement all signal connects here connect(this, QOverload::of(&QButtonGroup::buttonClicked), diff --git a/src/cpp/include/nodegui/QtWidgets/QCalendarWidget/ncalendarwidget.hpp b/src/cpp/include/nodegui/QtWidgets/QCalendarWidget/ncalendarwidget.hpp index cc803e2c2..176203ab3 100644 --- a/src/cpp/include/nodegui/QtWidgets/QCalendarWidget/ncalendarwidget.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QCalendarWidget/ncalendarwidget.hpp @@ -14,7 +14,7 @@ class DLL_EXPORT NCalendarWidget : public QCalendarWidget, public NodeWidget { // inherit all constructors of QCalendarWidget using QCalendarWidget::QCalendarWidget; - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { // Qt Connects: Implement all signal connects here QWIDGET_SIGNALS QObject::connect(this, &QCalendarWidget::activated, [=](const QDate &date) { diff --git a/src/cpp/include/nodegui/QtWidgets/QCheckBox/ncheckbox.hpp b/src/cpp/include/nodegui/QtWidgets/QCheckBox/ncheckbox.hpp index 9a3684b19..224f9ff42 100644 --- a/src/cpp/include/nodegui/QtWidgets/QCheckBox/ncheckbox.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QCheckBox/ncheckbox.hpp @@ -13,7 +13,7 @@ class DLL_EXPORT NCheckBox : public QCheckBox, public NodeWidget { public: using QCheckBox::QCheckBox; // inherit all constructors of QCheckBox - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QABSTRACT_BUTTON_SIGNALS QObject::connect(this, &QCheckBox::stateChanged, [=](int state) { Napi::Env env = this->emitOnNode.Env(); diff --git a/src/cpp/include/nodegui/QtWidgets/QColorDialog/ncolordialog.hpp b/src/cpp/include/nodegui/QtWidgets/QColorDialog/ncolordialog.hpp index 8473352ec..1978c919b 100644 --- a/src/cpp/include/nodegui/QtWidgets/QColorDialog/ncolordialog.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QColorDialog/ncolordialog.hpp @@ -14,7 +14,7 @@ class DLL_EXPORT NColorDialog : public QColorDialog, public NodeWidget { public: using QColorDialog::QColorDialog; - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QDIALOG_SIGNALS // Qt Connects: Implement all signal connects here QObject::connect( diff --git a/src/cpp/include/nodegui/QtWidgets/QComboBox/ncombobox.hpp b/src/cpp/include/nodegui/QtWidgets/QComboBox/ncombobox.hpp index 7147c4cb9..0ca3bc7f4 100644 --- a/src/cpp/include/nodegui/QtWidgets/QComboBox/ncombobox.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QComboBox/ncombobox.hpp @@ -12,7 +12,7 @@ class DLL_EXPORT NComboBox : public QComboBox, public NodeWidget { NODEWIDGET_IMPLEMENTATIONS(QComboBox) using QComboBox::QComboBox; - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QWIDGET_SIGNALS // Qt Connects: Implement all signal connects here QObject::connect( diff --git a/src/cpp/include/nodegui/QtWidgets/QDateEdit/ndateedit.hpp b/src/cpp/include/nodegui/QtWidgets/QDateEdit/ndateedit.hpp index 16a7e0639..a716a6053 100644 --- a/src/cpp/include/nodegui/QtWidgets/QDateEdit/ndateedit.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QDateEdit/ndateedit.hpp @@ -13,7 +13,7 @@ class DLL_EXPORT NDateEdit : public QDateEdit, public NodeWidget { // inherit all constructors of QDateEdit using QDateEdit::QDateEdit; - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { // Qt Connects: Implement all signal connects here QDATETIMEEDIT_SIGNALS } diff --git a/src/cpp/include/nodegui/QtWidgets/QDateTimeEdit/ndatetimeedit.hpp b/src/cpp/include/nodegui/QtWidgets/QDateTimeEdit/ndatetimeedit.hpp index 2557b11d9..438620e80 100644 --- a/src/cpp/include/nodegui/QtWidgets/QDateTimeEdit/ndatetimeedit.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QDateTimeEdit/ndatetimeedit.hpp @@ -14,7 +14,7 @@ class DLL_EXPORT NDateTimeEdit : public QDateTimeEdit, public NodeWidget { // inherit all constructors of QDateTimeEdit using QDateTimeEdit::QDateTimeEdit; - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { // Qt Connects: Implement all signal connects here QDATETIMEEDIT_SIGNALS } diff --git a/src/cpp/include/nodegui/QtWidgets/QDial/ndial.hpp b/src/cpp/include/nodegui/QtWidgets/QDial/ndial.hpp index 117136f22..a3735b3db 100644 --- a/src/cpp/include/nodegui/QtWidgets/QDial/ndial.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QDial/ndial.hpp @@ -11,7 +11,7 @@ class DLL_EXPORT NDial : public QDial, public NodeWidget { public: using QDial::QDial; // inherit all constructors of QDial - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { // Qt Connects: Implement all signal connects here QABSTRACT_SLIDER_SIGNALS } diff --git a/src/cpp/include/nodegui/QtWidgets/QDialog/ndialog.hpp b/src/cpp/include/nodegui/QtWidgets/QDialog/ndialog.hpp index ffc115103..5eeb017fb 100644 --- a/src/cpp/include/nodegui/QtWidgets/QDialog/ndialog.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QDialog/ndialog.hpp @@ -11,5 +11,5 @@ class DLL_EXPORT NDialog : public QDialog, public NodeWidget { public: using QDialog::QDialog; - void connectSignalsToEventEmitter() { QDIALOG_SIGNALS } + virtual void connectSignalsToEventEmitter() { QDIALOG_SIGNALS } }; diff --git a/src/cpp/include/nodegui/QtWidgets/QDoubleSpinBox/ndoublespinbox.hpp b/src/cpp/include/nodegui/QtWidgets/QDoubleSpinBox/ndoublespinbox.hpp index f1a089f56..aaa1a8b70 100644 --- a/src/cpp/include/nodegui/QtWidgets/QDoubleSpinBox/ndoublespinbox.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QDoubleSpinBox/ndoublespinbox.hpp @@ -14,7 +14,7 @@ class DLL_EXPORT NDoubleSpinBox : public QDoubleSpinBox, public NodeWidget { using QDoubleSpinBox::QDoubleSpinBox; // inherit all constructors of // QDoubleSpinBox - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QABSTRACTSPINBOX_SIGNALS // Qt Connects: Implement all signal connects here QObject::connect( diff --git a/src/cpp/include/nodegui/QtWidgets/QErrorMessage/nerrormessage.hpp b/src/cpp/include/nodegui/QtWidgets/QErrorMessage/nerrormessage.hpp index 467222488..4eefb6a5d 100644 --- a/src/cpp/include/nodegui/QtWidgets/QErrorMessage/nerrormessage.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QErrorMessage/nerrormessage.hpp @@ -13,7 +13,7 @@ class DLL_EXPORT NErrorMessage : public QErrorMessage, public NodeWidget { public: using QErrorMessage::QErrorMessage; - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QDIALOG_SIGNALS // Qt Connects: Implement all signal connects here } diff --git a/src/cpp/include/nodegui/QtWidgets/QFileDialog/nfiledialog.hpp b/src/cpp/include/nodegui/QtWidgets/QFileDialog/nfiledialog.hpp index 032db8046..67d60baab 100644 --- a/src/cpp/include/nodegui/QtWidgets/QFileDialog/nfiledialog.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QFileDialog/nfiledialog.hpp @@ -12,7 +12,7 @@ class DLL_EXPORT NFileDialog : public QFileDialog, public NodeWidget { NODEWIDGET_IMPLEMENTATIONS(QFileDialog) using QFileDialog::QFileDialog; - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QDIALOG_SIGNALS // Qt Connects: Implement all signal connects here QObject::connect( diff --git a/src/cpp/include/nodegui/QtWidgets/QFontDialog/nfontdialog.hpp b/src/cpp/include/nodegui/QtWidgets/QFontDialog/nfontdialog.hpp index 02271a874..045795052 100644 --- a/src/cpp/include/nodegui/QtWidgets/QFontDialog/nfontdialog.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QFontDialog/nfontdialog.hpp @@ -14,7 +14,7 @@ class DLL_EXPORT NFontDialog : public QFontDialog, public NodeWidget { public: using QFontDialog::QFontDialog; - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QDIALOG_SIGNALS // Qt Connects: Implement all signal connects here QObject::connect( diff --git a/src/cpp/include/nodegui/QtWidgets/QFrame/nframe.hpp b/src/cpp/include/nodegui/QtWidgets/QFrame/nframe.hpp index 71c1a65cb..ecde9fb9a 100644 --- a/src/cpp/include/nodegui/QtWidgets/QFrame/nframe.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QFrame/nframe.hpp @@ -12,5 +12,5 @@ class DLL_EXPORT NFrame : public QFrame, public NodeWidget { public: using QFrame::QFrame; - void connectSignalsToEventEmitter() { QFRAME_SIGNALS } + virtual void connectSignalsToEventEmitter() { QFRAME_SIGNALS } }; diff --git a/src/cpp/include/nodegui/QtWidgets/QGraphicsBlurEffect/ngraphicsblureffect.hpp b/src/cpp/include/nodegui/QtWidgets/QGraphicsBlurEffect/ngraphicsblureffect.hpp index 54677f42b..f441addcb 100644 --- a/src/cpp/include/nodegui/QtWidgets/QGraphicsBlurEffect/ngraphicsblureffect.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QGraphicsBlurEffect/ngraphicsblureffect.hpp @@ -14,7 +14,7 @@ class DLL_EXPORT NGraphicsBlurEffect : public QGraphicsBlurEffect, public: using QGraphicsBlurEffect::QGraphicsBlurEffect; - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QGRAPHICSEFFECT_SIGNALS // Qt Connects: Implement all signal connects here QObject::connect(this, &QGraphicsBlurEffect::blurHintsChanged, diff --git a/src/cpp/include/nodegui/QtWidgets/QGraphicsDropShadowEffect/ngraphicsdropshadoweffect.hpp b/src/cpp/include/nodegui/QtWidgets/QGraphicsDropShadowEffect/ngraphicsdropshadoweffect.hpp index 1b17870aa..3cf6b69ed 100644 --- a/src/cpp/include/nodegui/QtWidgets/QGraphicsDropShadowEffect/ngraphicsdropshadoweffect.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QGraphicsDropShadowEffect/ngraphicsdropshadoweffect.hpp @@ -14,7 +14,7 @@ class DLL_EXPORT NGraphicsDropShadowEffect : public QGraphicsDropShadowEffect, public: using QGraphicsDropShadowEffect::QGraphicsDropShadowEffect; - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QGRAPHICSEFFECT_SIGNALS // Qt Connects: Implement all signal connects here QObject::connect( diff --git a/src/cpp/include/nodegui/QtWidgets/QGridLayout/ngridlayout.hpp b/src/cpp/include/nodegui/QtWidgets/QGridLayout/ngridlayout.hpp index 0be6f53aa..4b8723ce8 100644 --- a/src/cpp/include/nodegui/QtWidgets/QGridLayout/ngridlayout.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QGridLayout/ngridlayout.hpp @@ -10,5 +10,5 @@ class DLL_EXPORT NGridLayout : public QGridLayout, public EventWidget { public: EVENTWIDGET_IMPLEMENTATIONS(QGridLayout) using QGridLayout::QGridLayout; - void connectSignalsToEventEmitter() { QLAYOUT_SIGNALS } + virtual void connectSignalsToEventEmitter() { QLAYOUT_SIGNALS } }; diff --git a/src/cpp/include/nodegui/QtWidgets/QGroupBox/ngroupbox.hpp b/src/cpp/include/nodegui/QtWidgets/QGroupBox/ngroupbox.hpp index b2e3780b9..7477334a7 100644 --- a/src/cpp/include/nodegui/QtWidgets/QGroupBox/ngroupbox.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QGroupBox/ngroupbox.hpp @@ -12,7 +12,7 @@ class DLL_EXPORT NGroupBox : public QGroupBox, public NodeWidget { public: using QGroupBox::QGroupBox; // inherit all constructors of QGroupBox - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QWIDGET_SIGNALS QObject::connect(this, &QGroupBox::clicked, [=](bool checked) { Napi::Env env = this->emitOnNode.Env(); diff --git a/src/cpp/include/nodegui/QtWidgets/QHeaderView/nheaderview.hpp b/src/cpp/include/nodegui/QtWidgets/QHeaderView/nheaderview.hpp index fac500ab2..b1a4e75ac 100644 --- a/src/cpp/include/nodegui/QtWidgets/QHeaderView/nheaderview.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QHeaderView/nheaderview.hpp @@ -12,5 +12,5 @@ class DLL_EXPORT NHeaderView : public QHeaderView, public NodeWidget { public: using QHeaderView::QHeaderView; - void connectSignalsToEventEmitter() { QABSTRACTITEMVIEW_SIGNALS } + virtual void connectSignalsToEventEmitter() { QABSTRACTITEMVIEW_SIGNALS } }; diff --git a/src/cpp/include/nodegui/QtWidgets/QInputDialog/ninputdialog.hpp b/src/cpp/include/nodegui/QtWidgets/QInputDialog/ninputdialog.hpp index 986027d8c..7f88f9d45 100644 --- a/src/cpp/include/nodegui/QtWidgets/QInputDialog/ninputdialog.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QInputDialog/ninputdialog.hpp @@ -11,7 +11,7 @@ class DLL_EXPORT NInputDialog : public QInputDialog, public NodeWidget { Q_OBJECT NODEWIDGET_IMPLEMENTATIONS(QInputDialog) using QInputDialog::QInputDialog; - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QDIALOG_SIGNALS QObject::connect(this, &QInputDialog::doubleValueChanged, [=](double val) { Napi::Env env = this->emitOnNode.Env(); diff --git a/src/cpp/include/nodegui/QtWidgets/QLCDNumber/nlcdnumber.hpp b/src/cpp/include/nodegui/QtWidgets/QLCDNumber/nlcdnumber.hpp index 985848800..1e6cf017a 100644 --- a/src/cpp/include/nodegui/QtWidgets/QLCDNumber/nlcdnumber.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QLCDNumber/nlcdnumber.hpp @@ -12,7 +12,7 @@ class DLL_EXPORT NLCDNumber : public QLCDNumber, public NodeWidget { public: using QLCDNumber::QLCDNumber; // inherit all constructors of QLCDNumber - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QWIDGET_SIGNALS QObject::connect(this, &QLCDNumber::overflow, [=]() { Napi::Env env = this->emitOnNode.Env(); diff --git a/src/cpp/include/nodegui/QtWidgets/QLabel/nlabel.hpp b/src/cpp/include/nodegui/QtWidgets/QLabel/nlabel.hpp index 2705122c3..30c2efc08 100644 --- a/src/cpp/include/nodegui/QtWidgets/QLabel/nlabel.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QLabel/nlabel.hpp @@ -13,7 +13,7 @@ class DLL_EXPORT NLabel : public QLabel, public NodeWidget { public: using QLabel::QLabel; // inherit all constructors of QLabel - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QFRAME_SIGNALS QObject::connect(this, &QLabel::linkActivated, [=](const QString& link) { Napi::Env env = this->emitOnNode.Env(); diff --git a/src/cpp/include/nodegui/QtWidgets/QLayout/nlayout.hpp b/src/cpp/include/nodegui/QtWidgets/QLayout/nlayout.hpp index cf51888b4..46803ad40 100644 --- a/src/cpp/include/nodegui/QtWidgets/QLayout/nlayout.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QLayout/nlayout.hpp @@ -10,5 +10,5 @@ class DLL_EXPORT NLayout : public QLayout, public EventWidget { public: EVENTWIDGET_IMPLEMENTATIONS(QLayout) using QLayout::QLayout; - void connectSignalsToEventEmitter() { QLAYOUT_SIGNALS } + virtual void connectSignalsToEventEmitter() { QLAYOUT_SIGNALS } }; diff --git a/src/cpp/include/nodegui/QtWidgets/QLineEdit/nlineedit.hpp b/src/cpp/include/nodegui/QtWidgets/QLineEdit/nlineedit.hpp index 786567919..44d6b7869 100644 --- a/src/cpp/include/nodegui/QtWidgets/QLineEdit/nlineedit.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QLineEdit/nlineedit.hpp @@ -11,7 +11,7 @@ class DLL_EXPORT NLineEdit : public QLineEdit, public NodeWidget { public: using QLineEdit::QLineEdit; // inherit all constructors of QLineEdit - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QWIDGET_SIGNALS // Qt Connects: Implement all signal connects here QObject::connect(this, &QLineEdit::cursorPositionChanged, diff --git a/src/cpp/include/nodegui/QtWidgets/QListView/nlistview.hpp b/src/cpp/include/nodegui/QtWidgets/QListView/nlistview.hpp index d054824bf..8ee0a85a7 100644 --- a/src/cpp/include/nodegui/QtWidgets/QListView/nlistview.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QListView/nlistview.hpp @@ -12,5 +12,5 @@ class DLL_EXPORT NListView : public QListView, public NodeWidget { public: using QListView::QListView; - void connectSignalsToEventEmitter() { QLISTVIEW_SIGNALS } + virtual void connectSignalsToEventEmitter() { QLISTVIEW_SIGNALS } }; diff --git a/src/cpp/include/nodegui/QtWidgets/QListWidget/nlistwidget.hpp b/src/cpp/include/nodegui/QtWidgets/QListWidget/nlistwidget.hpp index 8fac0c861..adfc0616d 100644 --- a/src/cpp/include/nodegui/QtWidgets/QListWidget/nlistwidget.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QListWidget/nlistwidget.hpp @@ -15,7 +15,7 @@ class DLL_EXPORT NListWidget : public QListWidget, public NodeWidget { public: using QListWidget::QListWidget; - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QLISTVIEW_SIGNALS // Qt Connects: Implement all signal connects here QObject::connect( diff --git a/src/cpp/include/nodegui/QtWidgets/QMainWindow/nmainwindow.hpp b/src/cpp/include/nodegui/QtWidgets/QMainWindow/nmainwindow.hpp index bde89767d..70783c819 100644 --- a/src/cpp/include/nodegui/QtWidgets/QMainWindow/nmainwindow.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QMainWindow/nmainwindow.hpp @@ -11,5 +11,5 @@ class DLL_EXPORT NMainWindow : public QMainWindow, public NodeWidget { NODEWIDGET_IMPLEMENTATIONS(QMainWindow) public: using QMainWindow::QMainWindow; // inherit all constructors of QMainWindow - void connectSignalsToEventEmitter() { QWIDGET_SIGNALS } + virtual void connectSignalsToEventEmitter() { QWIDGET_SIGNALS } }; diff --git a/src/cpp/include/nodegui/QtWidgets/QMenu/nmenu.hpp b/src/cpp/include/nodegui/QtWidgets/QMenu/nmenu.hpp index 06902f8c7..0e70aa4df 100644 --- a/src/cpp/include/nodegui/QtWidgets/QMenu/nmenu.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QMenu/nmenu.hpp @@ -11,7 +11,7 @@ class DLL_EXPORT NMenu : public QMenu, public NodeWidget { NODEWIDGET_IMPLEMENTATIONS(QMenu) public: using QMenu::QMenu; // inherit all constructors of QMenu - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QWIDGET_SIGNALS QObject::connect(this, &QMenu::triggered, [=](QAction* action) { diff --git a/src/cpp/include/nodegui/QtWidgets/QMenuBar/nmenubar.hpp b/src/cpp/include/nodegui/QtWidgets/QMenuBar/nmenubar.hpp index 1fde962ad..ce6a19f0d 100644 --- a/src/cpp/include/nodegui/QtWidgets/QMenuBar/nmenubar.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QMenuBar/nmenubar.hpp @@ -11,5 +11,5 @@ class DLL_EXPORT NMenuBar : public QMenuBar, public NodeWidget { NODEWIDGET_IMPLEMENTATIONS(QMenuBar) public: using QMenuBar::QMenuBar; // inherit all constructors of QMenuBar - void connectSignalsToEventEmitter() { QWIDGET_SIGNALS } + virtual void connectSignalsToEventEmitter() { QWIDGET_SIGNALS } }; diff --git a/src/cpp/include/nodegui/QtWidgets/QMessageBox/nmessagebox.hpp b/src/cpp/include/nodegui/QtWidgets/QMessageBox/nmessagebox.hpp index 079fe054d..6c9125935 100644 --- a/src/cpp/include/nodegui/QtWidgets/QMessageBox/nmessagebox.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QMessageBox/nmessagebox.hpp @@ -14,7 +14,7 @@ class DLL_EXPORT NMessageBox : public QMessageBox, public NodeWidget { NODEWIDGET_IMPLEMENTATIONS(QMessageBox) using QMessageBox::QMessageBox; - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QDIALOG_SIGNALS QObject::connect( this, &QMessageBox::buttonClicked, [=](QAbstractButton* button) { diff --git a/src/cpp/include/nodegui/QtWidgets/QPlainTextEdit/nplaintextedit.hpp b/src/cpp/include/nodegui/QtWidgets/QPlainTextEdit/nplaintextedit.hpp index 4353a7486..80f1ada5e 100644 --- a/src/cpp/include/nodegui/QtWidgets/QPlainTextEdit/nplaintextedit.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QPlainTextEdit/nplaintextedit.hpp @@ -11,7 +11,7 @@ class DLL_EXPORT NPlainTextEdit : public QPlainTextEdit, public NodeWidget { using QPlainTextEdit::QPlainTextEdit; // inherit all constructors of // QPlainTextEdit - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QABSTRACTSCROLLAREA_SIGNALS // Qt Connects: Implement all signal connects here diff --git a/src/cpp/include/nodegui/QtWidgets/QProgressBar/nprogressbar.hpp b/src/cpp/include/nodegui/QtWidgets/QProgressBar/nprogressbar.hpp index c0ee6674c..a542c7a48 100644 --- a/src/cpp/include/nodegui/QtWidgets/QProgressBar/nprogressbar.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QProgressBar/nprogressbar.hpp @@ -12,7 +12,7 @@ class DLL_EXPORT NProgressBar : public QProgressBar, public NodeWidget { public: using QProgressBar::QProgressBar; // inherit all constructors of QProgressBar - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QWIDGET_SIGNALS // Qt Connects: Implement all signal connects here QObject::connect(this, &QProgressBar::valueChanged, [=](int value) { diff --git a/src/cpp/include/nodegui/QtWidgets/QProgressDialog/nprogressdialog.hpp b/src/cpp/include/nodegui/QtWidgets/QProgressDialog/nprogressdialog.hpp index ae458d209..b29b97f35 100644 --- a/src/cpp/include/nodegui/QtWidgets/QProgressDialog/nprogressdialog.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QProgressDialog/nprogressdialog.hpp @@ -13,7 +13,7 @@ class DLL_EXPORT NProgressDialog : public QProgressDialog, public NodeWidget { public: using QProgressDialog::QProgressDialog; - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QDIALOG_SIGNALS // Qt Connects: Implement all signal connects here QObject::connect(this, &QProgressDialog::canceled, [=]() { diff --git a/src/cpp/include/nodegui/QtWidgets/QPushButton/npushbutton.hpp b/src/cpp/include/nodegui/QtWidgets/QPushButton/npushbutton.hpp index 35947c6a1..7db093377 100644 --- a/src/cpp/include/nodegui/QtWidgets/QPushButton/npushbutton.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QPushButton/npushbutton.hpp @@ -14,5 +14,5 @@ class DLL_EXPORT NPushButton : public QPushButton, public NodeWidget { public: using QPushButton::QPushButton; // inherit all constructors of QPushButton - void connectSignalsToEventEmitter() { QABSTRACT_BUTTON_SIGNALS } + virtual void connectSignalsToEventEmitter() { QABSTRACT_BUTTON_SIGNALS } }; diff --git a/src/cpp/include/nodegui/QtWidgets/QRadioButton/nradiobutton.hpp b/src/cpp/include/nodegui/QtWidgets/QRadioButton/nradiobutton.hpp index 2415fb3a0..93b35a4aa 100644 --- a/src/cpp/include/nodegui/QtWidgets/QRadioButton/nradiobutton.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QRadioButton/nradiobutton.hpp @@ -11,7 +11,7 @@ class DLL_EXPORT NRadioButton : public QRadioButton, public NodeWidget { NODEWIDGET_IMPLEMENTATIONS(QRadioButton) public: using QRadioButton::QRadioButton; // inherit all constructors of QRadioButton - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { // Qt Connects: Implement all signal connects here QABSTRACT_BUTTON_SIGNALS } diff --git a/src/cpp/include/nodegui/QtWidgets/QScrollArea/nscrollarea.hpp b/src/cpp/include/nodegui/QtWidgets/QScrollArea/nscrollarea.hpp index b481f1ece..3926e00ca 100644 --- a/src/cpp/include/nodegui/QtWidgets/QScrollArea/nscrollarea.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QScrollArea/nscrollarea.hpp @@ -12,7 +12,7 @@ class DLL_EXPORT NScrollArea : public QScrollArea, public NodeWidget { public: using QScrollArea::QScrollArea; // inherit all constructors of QScrollArea - void connectSignalsToEventEmitter() { QABSTRACTSCROLLAREA_SIGNALS } + virtual void connectSignalsToEventEmitter() { QABSTRACTSCROLLAREA_SIGNALS } // By-pass `protected` access and expose it. void setViewportMargins(int left, int top, int right, int bottom) { diff --git a/src/cpp/include/nodegui/QtWidgets/QScrollBar/nscrollbar.hpp b/src/cpp/include/nodegui/QtWidgets/QScrollBar/nscrollbar.hpp index 8266cd6e9..98f95f90a 100644 --- a/src/cpp/include/nodegui/QtWidgets/QScrollBar/nscrollbar.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QScrollBar/nscrollbar.hpp @@ -12,7 +12,7 @@ class DLL_EXPORT NScrollBar : public QScrollBar, public NodeWidget { public: using QScrollBar::QScrollBar; // inherit all constructors of QScrollBar - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { // Qt Connects: Implement all signal connects here QABSTRACT_SLIDER_SIGNALS } diff --git a/src/cpp/include/nodegui/QtWidgets/QShortcut/nshortcut.hpp b/src/cpp/include/nodegui/QtWidgets/QShortcut/nshortcut.hpp index 777548c38..5732a668d 100644 --- a/src/cpp/include/nodegui/QtWidgets/QShortcut/nshortcut.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QShortcut/nshortcut.hpp @@ -11,7 +11,7 @@ class DLL_EXPORT NShortcut : public QShortcut, public EventWidget { EVENTWIDGET_IMPLEMENTATIONS(QShortcut) public: using QShortcut::QShortcut; // inherit all constructors of QShortcut - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QOBJECT_SIGNALS // Qt Connects: Implement all signal connects here QObject::connect(this, &QShortcut::activated, [=]() { diff --git a/src/cpp/include/nodegui/QtWidgets/QSlider/nslider.hpp b/src/cpp/include/nodegui/QtWidgets/QSlider/nslider.hpp index ae3e2d9f5..b585100c5 100644 --- a/src/cpp/include/nodegui/QtWidgets/QSlider/nslider.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QSlider/nslider.hpp @@ -11,7 +11,7 @@ class DLL_EXPORT NSlider : public QSlider, public NodeWidget { public: using QSlider::QSlider; // inherit all constructors of QSlider - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { // Qt Connects: Implement all signal connects here QABSTRACT_SLIDER_SIGNALS } diff --git a/src/cpp/include/nodegui/QtWidgets/QSpinBox/nspinbox.hpp b/src/cpp/include/nodegui/QtWidgets/QSpinBox/nspinbox.hpp index e07ee9d31..06fff44eb 100644 --- a/src/cpp/include/nodegui/QtWidgets/QSpinBox/nspinbox.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QSpinBox/nspinbox.hpp @@ -13,7 +13,7 @@ class DLL_EXPORT NSpinBox : public QSpinBox, public NodeWidget { public: using QSpinBox::QSpinBox; // inherit all constructors of QSpinBox - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QABSTRACTSPINBOX_SIGNALS // Qt Connects: Implement all signal connects here QObject::connect( diff --git a/src/cpp/include/nodegui/QtWidgets/QStackedWidget/nstackedwidget.hpp b/src/cpp/include/nodegui/QtWidgets/QStackedWidget/nstackedwidget.hpp index 052f5a70f..4730042c4 100644 --- a/src/cpp/include/nodegui/QtWidgets/QStackedWidget/nstackedwidget.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QStackedWidget/nstackedwidget.hpp @@ -15,7 +15,7 @@ class DLL_EXPORT NStackedWidget : public QStackedWidget, public NodeWidget { using QStackedWidget::QStackedWidget; // inherit all constructors of // QStackedWidget - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QFRAME_SIGNALS // Qt Connects: Implement all signal connects here QObject::connect(this, &QStackedWidget::currentChanged, [=](int index) { diff --git a/src/cpp/include/nodegui/QtWidgets/QStandardItemModel/nstandarditemmodel.hpp b/src/cpp/include/nodegui/QtWidgets/QStandardItemModel/nstandarditemmodel.hpp index 5f8df278f..7c67ff3cc 100644 --- a/src/cpp/include/nodegui/QtWidgets/QStandardItemModel/nstandarditemmodel.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QStandardItemModel/nstandarditemmodel.hpp @@ -14,7 +14,7 @@ class DLL_EXPORT NStandardItemModel : public QStandardItemModel, public: using QStandardItemModel::QStandardItemModel; // inherit all constructors of // QStandardItemModel - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QOBJECT_SIGNALS QObject::connect( diff --git a/src/cpp/include/nodegui/QtWidgets/QStatusBar/nstatusbar.hpp b/src/cpp/include/nodegui/QtWidgets/QStatusBar/nstatusbar.hpp index 598b5563d..68662939c 100644 --- a/src/cpp/include/nodegui/QtWidgets/QStatusBar/nstatusbar.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QStatusBar/nstatusbar.hpp @@ -13,7 +13,7 @@ class DLL_EXPORT NStatusBar : public QStatusBar, public NodeWidget { NODEWIDGET_IMPLEMENTATIONS(QStatusBar) using QStatusBar::QStatusBar; // inherit all constructors of QStatusBar - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QObject::connect( this, &QStatusBar::messageChanged, [=](const QString &message) { Napi::Env env = this->emitOnNode.Env(); diff --git a/src/cpp/include/nodegui/QtWidgets/QSvgWidget/nsvgwidget.hpp b/src/cpp/include/nodegui/QtWidgets/QSvgWidget/nsvgwidget.hpp index 0878e174d..05964bc9a 100644 --- a/src/cpp/include/nodegui/QtWidgets/QSvgWidget/nsvgwidget.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QSvgWidget/nsvgwidget.hpp @@ -13,5 +13,5 @@ class DLL_EXPORT NSvgWidget : public QSvgWidget, public NodeWidget { public: using QSvgWidget::QSvgWidget; // inherit all constructors of QSvgWidget - void connectSignalsToEventEmitter() { QWIDGET_SIGNALS } + virtual void connectSignalsToEventEmitter() { QWIDGET_SIGNALS } }; diff --git a/src/cpp/include/nodegui/QtWidgets/QSystemTrayIcon/nsystemtrayicon.hpp b/src/cpp/include/nodegui/QtWidgets/QSystemTrayIcon/nsystemtrayicon.hpp index 4f8c2a7a8..d0cd9bdb1 100644 --- a/src/cpp/include/nodegui/QtWidgets/QSystemTrayIcon/nsystemtrayicon.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QSystemTrayIcon/nsystemtrayicon.hpp @@ -12,7 +12,7 @@ class DLL_EXPORT NSystemTrayIcon : public QSystemTrayIcon, public EventWidget { public: // inherit all constructors of QSystemTrayIcon using QSystemTrayIcon::QSystemTrayIcon; - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QOBJECT_SIGNALS QObject::connect(this, &QSystemTrayIcon::activated, [=](int reason) { Napi::Env env = this->emitOnNode.Env(); diff --git a/src/cpp/include/nodegui/QtWidgets/QTabBar/ntabbar.hpp b/src/cpp/include/nodegui/QtWidgets/QTabBar/ntabbar.hpp index bf5dbbd13..05dec8cfe 100644 --- a/src/cpp/include/nodegui/QtWidgets/QTabBar/ntabbar.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QTabBar/ntabbar.hpp @@ -13,7 +13,7 @@ class DLL_EXPORT NTabBar : public QTabBar, public NodeWidget { public: using QTabBar::QTabBar; // inherit all constructors of QTabBar - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QWIDGET_SIGNALS // Qt Connects: Implement all signal connects here QObject::connect(this, &QTabBar::currentChanged, [=](int index) { diff --git a/src/cpp/include/nodegui/QtWidgets/QTabWidget/ntabwidget.hpp b/src/cpp/include/nodegui/QtWidgets/QTabWidget/ntabwidget.hpp index 1c3bf656d..3d69c2a5c 100644 --- a/src/cpp/include/nodegui/QtWidgets/QTabWidget/ntabwidget.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QTabWidget/ntabwidget.hpp @@ -12,7 +12,7 @@ class DLL_EXPORT NTabWidget : public QTabWidget, public NodeWidget { public: using QTabWidget::QTabWidget; // inherit all constructors of QTabWidget - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QWIDGET_SIGNALS // Qt Connects: Implement all signal connects here QObject::connect(this, &QTabWidget::currentChanged, [=](int index) { diff --git a/src/cpp/include/nodegui/QtWidgets/QTableView/ntableview.hpp b/src/cpp/include/nodegui/QtWidgets/QTableView/ntableview.hpp index afeaaef32..c64c1596e 100644 --- a/src/cpp/include/nodegui/QtWidgets/QTableView/ntableview.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QTableView/ntableview.hpp @@ -12,5 +12,5 @@ class DLL_EXPORT NTableView : public QTableView, public NodeWidget { public: using QTableView::QTableView; - void connectSignalsToEventEmitter() { QTABLEVIEW_SIGNALS } + virtual void connectSignalsToEventEmitter() { QTABLEVIEW_SIGNALS } }; diff --git a/src/cpp/include/nodegui/QtWidgets/QTableWidget/ntablewidget.hpp b/src/cpp/include/nodegui/QtWidgets/QTableWidget/ntablewidget.hpp index 27bc11064..28e86b57c 100644 --- a/src/cpp/include/nodegui/QtWidgets/QTableWidget/ntablewidget.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QTableWidget/ntablewidget.hpp @@ -11,7 +11,7 @@ class DLL_EXPORT NTableWidget : public QTableWidget, public NodeWidget { Q_OBJECT NODEWIDGET_IMPLEMENTATIONS(QTableWidget) using QTableWidget::QTableWidget; - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { // Qt Connects: Implement all signal connects here QABSTRACTSCROLLAREA_SIGNALS QObject::connect( diff --git a/src/cpp/include/nodegui/QtWidgets/QTextBrowser/ntextbrowser.hpp b/src/cpp/include/nodegui/QtWidgets/QTextBrowser/ntextbrowser.hpp index 5da65e15a..31493fed4 100644 --- a/src/cpp/include/nodegui/QtWidgets/QTextBrowser/ntextbrowser.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QTextBrowser/ntextbrowser.hpp @@ -13,7 +13,7 @@ class DLL_EXPORT NTextBrowser : public QTextBrowser, public NodeWidget { public: using QTextBrowser::QTextBrowser; // inherit all constructors of QTextBrowser - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QTEXTEDIT_SIGNALS // Qt Connects: Implement all signal connects here QObject::connect(this, &QTextBrowser::anchorClicked, [=](const QUrl& link) { diff --git a/src/cpp/include/nodegui/QtWidgets/QTextEdit/ntextedit.hpp b/src/cpp/include/nodegui/QtWidgets/QTextEdit/ntextedit.hpp index 3587a0cac..a8ce5aa6c 100644 --- a/src/cpp/include/nodegui/QtWidgets/QTextEdit/ntextedit.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QTextEdit/ntextedit.hpp @@ -12,7 +12,7 @@ class DLL_EXPORT NTextEdit : public QTextEdit, public NodeWidget { public: using QTextEdit::QTextEdit; // inherit all constructors of QTextEdit - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QTEXTEDIT_SIGNALS // Qt Connects: Implement all signal connects here } diff --git a/src/cpp/include/nodegui/QtWidgets/QTimeEdit/ntimeedit.hpp b/src/cpp/include/nodegui/QtWidgets/QTimeEdit/ntimeedit.hpp index 0879c84e6..77734221f 100644 --- a/src/cpp/include/nodegui/QtWidgets/QTimeEdit/ntimeedit.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QTimeEdit/ntimeedit.hpp @@ -13,7 +13,7 @@ class DLL_EXPORT NTimeEdit : public QTimeEdit, public NodeWidget { // inherit all constructors of QTimeEdit using QTimeEdit::QTimeEdit; - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { // Qt Connects: Implement all signal connects here QDATETIMEEDIT_SIGNALS } diff --git a/src/cpp/include/nodegui/QtWidgets/QToolButton/ntoolbutton.hpp b/src/cpp/include/nodegui/QtWidgets/QToolButton/ntoolbutton.hpp index ac8a5fa51..45c0a94d0 100644 --- a/src/cpp/include/nodegui/QtWidgets/QToolButton/ntoolbutton.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QToolButton/ntoolbutton.hpp @@ -15,7 +15,7 @@ class DLL_EXPORT NToolButton : public QToolButton, public NodeWidget { public: using QToolButton::QToolButton; // inherit all constructors of QToolButton - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { // Qt Connects: Implement all signal connects here QABSTRACT_BUTTON_SIGNALS QObject::connect(this, &QToolButton::triggered, [=](QAction* action) { diff --git a/src/cpp/include/nodegui/QtWidgets/QTreeWidget/ntreewidget.hpp b/src/cpp/include/nodegui/QtWidgets/QTreeWidget/ntreewidget.hpp index 7a1756383..8c522d79a 100644 --- a/src/cpp/include/nodegui/QtWidgets/QTreeWidget/ntreewidget.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QTreeWidget/ntreewidget.hpp @@ -14,7 +14,7 @@ class DLL_EXPORT NTreeWidget : public QTreeWidget, public NodeWidget { public: using QTreeWidget::QTreeWidget; // inherit all constructors of QTreeWidget - void connectSignalsToEventEmitter() { + virtual void connectSignalsToEventEmitter() { QABSTRACTSCROLLAREA_SIGNALS QObject::connect(this, &QTreeWidget::itemSelectionChanged, [=]() { Napi::Env env = this->emitOnNode.Env(); diff --git a/src/cpp/include/nodegui/QtWidgets/QWidget/nwidget.hpp b/src/cpp/include/nodegui/QtWidgets/QWidget/nwidget.hpp index 47fc2f436..99f65b5d6 100644 --- a/src/cpp/include/nodegui/QtWidgets/QWidget/nwidget.hpp +++ b/src/cpp/include/nodegui/QtWidgets/QWidget/nwidget.hpp @@ -22,5 +22,5 @@ class DLL_EXPORT NWidget : public QWidget, public NodeWidget { QWidget::paintEvent(e); } - void connectSignalsToEventEmitter() { QWIDGET_SIGNALS } + virtual void connectSignalsToEventEmitter() { QWIDGET_SIGNALS } }; diff --git a/src/cpp/include/nodegui/core/Events/eventwidget.h b/src/cpp/include/nodegui/core/Events/eventwidget.h index b6e5935d2..0fc90c87f 100644 --- a/src/cpp/include/nodegui/core/Events/eventwidget.h +++ b/src/cpp/include/nodegui/core/Events/eventwidget.h @@ -17,7 +17,7 @@ class DLL_EXPORT EventWidget { bool event(QEvent* event); - void connectSignalsToEventEmitter(); + virtual void connectSignalsToEventEmitter(); ~EventWidget(); }; \ No newline at end of file diff --git a/src/cpp/include/nodegui/core/FlexLayout/flexlayout.hpp b/src/cpp/include/nodegui/core/FlexLayout/flexlayout.hpp index bf9524d37..24a53da52 100644 --- a/src/cpp/include/nodegui/core/FlexLayout/flexlayout.hpp +++ b/src/cpp/include/nodegui/core/FlexLayout/flexlayout.hpp @@ -54,5 +54,5 @@ class DLL_EXPORT FlexLayout : public QLayout, public EventWidget { bool hasHeightForWidth() const override; EVENTWIDGET_IMPLEMENTATIONS(QLayout) - void connectSignalsToEventEmitter(); + virtual void connectSignalsToEventEmitter(); };