From 2541feebe7fa98adc90cdf94dc18fa5771795843 Mon Sep 17 00:00:00 2001 From: Atul R Date: Thu, 24 Oct 2019 19:34:27 +0200 Subject: [PATCH] fixes the crash on keyevent (#155) --- .../include/nodegui/QtGui/QEvent/QKeyEvent/qkeyevent_wrap.h | 2 +- src/cpp/lib/QtGui/QEvent/QKeyEvent/qkeyevent_wrap.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/cpp/include/nodegui/QtGui/QEvent/QKeyEvent/qkeyevent_wrap.h b/src/cpp/include/nodegui/QtGui/QEvent/QKeyEvent/qkeyevent_wrap.h index 35c3e5974..f3e4699b9 100644 --- a/src/cpp/include/nodegui/QtGui/QEvent/QKeyEvent/qkeyevent_wrap.h +++ b/src/cpp/include/nodegui/QtGui/QEvent/QKeyEvent/qkeyevent_wrap.h @@ -6,7 +6,7 @@ class QKeyEventWrap : public Napi::ObjectWrap{ private: - std::unique_ptr instance; + QKeyEvent* instance; public: static Napi::Object init(Napi::Env env, Napi::Object exports); diff --git a/src/cpp/lib/QtGui/QEvent/QKeyEvent/qkeyevent_wrap.cpp b/src/cpp/lib/QtGui/QEvent/QKeyEvent/qkeyevent_wrap.cpp index cefb5160e..ff8836e9b 100644 --- a/src/cpp/lib/QtGui/QEvent/QKeyEvent/qkeyevent_wrap.cpp +++ b/src/cpp/lib/QtGui/QEvent/QKeyEvent/qkeyevent_wrap.cpp @@ -19,7 +19,7 @@ Napi::Object QKeyEventWrap::init(Napi::Env env, Napi::Object exports) { } QKeyEvent* QKeyEventWrap::getInternalInstance() { - return this->instance.get(); + return this->instance; } QKeyEventWrap::QKeyEventWrap(const Napi::CallbackInfo& info): Napi::ObjectWrap(info) { @@ -27,7 +27,7 @@ QKeyEventWrap::QKeyEventWrap(const Napi::CallbackInfo& info): Napi::ObjectWrap eventObject = info[0].As>(); - this->instance = std::unique_ptr(eventObject.Data()); + this->instance = static_cast(eventObject.Data()); } else { Napi::TypeError::New(env, "Wrong number of arguments").ThrowAsJavaScriptException(); }