From 68c910d107fb7f0f19667223d1ebc101bef4f999 Mon Sep 17 00:00:00 2001 From: Atul R Date: Tue, 12 Nov 2019 00:43:45 +0100 Subject: [PATCH] Fixes critical memory leak (#195) --- src/cpp/include/nodegui/Extras/Utils/nutils.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cpp/include/nodegui/Extras/Utils/nutils.h b/src/cpp/include/nodegui/Extras/Utils/nutils.h index 75423097b..5f3550e7d 100644 --- a/src/cpp/include/nodegui/Extras/Utils/nutils.h +++ b/src/cpp/include/nodegui/Extras/Utils/nutils.h @@ -18,8 +18,8 @@ bool isNapiValueInt(Napi::Env& env, Napi::Value& num); std::string getNapiObjectClassName(Napi::Object& object); template -void safeDelete(QPointer component) { - if (component.isNull()) { +void safeDelete(QPointer& component) { + if (!component.isNull()) { delete component; } }