diff --git a/.github/workflows/latest.yml b/.github/workflows/latest.yml
new file mode 100644
index 000000000..7a084f59c
--- /dev/null
+++ b/.github/workflows/latest.yml
@@ -0,0 +1,37 @@
+on:
+ push:
+ branches:
+ - master # Push events on master branch
+jobs:
+ build:
+ strategy:
+ fail-fast: false
+ matrix:
+ os: [ubuntu-18.04]
+ runs-on: ${{ matrix.os }}
+ steps:
+ - uses: actions/checkout@master
+ - uses: actions/setup-node@master
+ with:
+ node-version: '13.x'
+ - name: Install deps
+ run: npm install --ignore-scripts
+ - name: Build nodegui
+ run: npx tsc
+ - name: Archive using npm pack
+ run: npm --no-git-tag-version version 1.0.0-master && npm pack
+ - uses: actions/upload-artifact@v1
+ with:
+ name: latest-release
+ path: nodegui-nodegui-1.0.0-master.tgz
+ - uses: nodegui/create-release@master
+ with:
+ token: ${{ secrets.GITHUB_TOKEN }}
+ code: latest-master
+ name: Latest Master Release
+ body: >
+ Latest auto release corresponding to commit ${{github.sha}} π₯.
+ To install do, npm install https://github.com/@nodegui/nodegui/releases/download/latest-master/nodegui-master.tgz
+ assets: >
+ nodegui-nodegui-1.0.0-master.tgz:nodegui-master.tgz:application/tar+gzip
+ recreate: true
diff --git a/README.md b/README.md
index 678be0cc8..2b59252d8 100644
--- a/README.md
+++ b/README.md
@@ -39,41 +39,54 @@ https://github.com/nodegui/examples
## Features
-- 𧬠Cross platform. Should work on major Linux flavours, Windows and MacOS.
-- π Low CPU and memory footprint. Current CPU stays at 0% on idle and memory usage is under 20mb for a hello world program.
-- π Styling with CSS (includes actual cascading). Also has full support for Flexbox layout (thanks to Yoga).
-- β Complete Nodejs api support (Currently runs on Node v12.x - and is easily upgradable). Hence has access to all nodejs compatible npm modules.
-- πͺ Native widget event listener support. Supports all events available from Qt / NodeJs.
-- πΈ Can be used for Commercial applications.
-- π΅οΈββοΈ Good Devtools support.
-- π Good documentation and website.
-- π§ββοΈ Good documentation for contributors.
-- π¦Ήπ»ββοΈ Good support for dark mode (Thanks to QT).
-- π First class Typescript support. (Works on regular JS projects too π).
-
+- 𧬠Cross platform. Should work on major Linux flavours, Windows and MacOS.
+- π Low CPU and memory footprint. Current CPU stays at 0% on idle and memory usage is under 20mb for a hello world program.
+- π Styling with CSS (includes actual cascading). Also has full support for Flexbox layout (thanks to Yoga).
+- β Complete Nodejs api support (Currently runs on Node v12.x - and is easily upgradable). Hence has access to all nodejs compatible npm modules.
+- πͺ Native widget event listener support. Supports all events available from Qt / NodeJs.
+- πΈ Can be used for Commercial applications.
+- π΅οΈββοΈ Good Devtools support.
+- π Good documentation and website.
+- π§ββοΈ Good documentation for contributors.
+- π¦Ήπ»ββοΈ Good support for dark mode (Thanks to QT).
+- π First class Typescript support. (Works on regular JS projects too π).
## Getting Started
-- Check out [nodegui-starter](https://github.com/nodegui/nodegui-starter) to get up and running with your own React NodeGUI app!
-- Read through the [docs](https://nodegui.github.io/nodegui).
-- Checkout the examples: https://github.com/nodegui/examples .
+- Check out [nodegui-starter](https://github.com/nodegui/nodegui-starter) to get up and running with your own React NodeGUI app!
+- Read through the [docs](https://nodegui.github.io/nodegui).
+- Checkout the examples: https://github.com/nodegui/examples .
+
+## Installation
+
+To install latest stable release:
+
+```
+npm install @nodegui/nodegui
+```
+
+To install the latest version available on master branch:
+
+```
+npm install https://github.com/@nodegui/nodegui/releases/download/latest-master/nodegui-master.tgz
+```
**Community guides**
-- https://blog.logrocket.com/electron-alternatives-exploring-nodegui-and-react-nodegui/ - Electron alternatives: Exploring NodeGUI and React NodeGUI by [Siegfried Grimbeek](https://blog.logrocket.com/author/siegfriedgrimbeek/).
-- https://hibbard.eu/node-gui/ - Excellent guide from [James Hibbard](https://github.com/jameshibbard).
+- https://blog.logrocket.com/electron-alternatives-exploring-nodegui-and-react-nodegui/ - Electron alternatives: Exploring NodeGUI and React NodeGUI by [Siegfried Grimbeek](https://blog.logrocket.com/author/siegfriedgrimbeek/).
+- https://hibbard.eu/node-gui/ - Excellent guide from [James Hibbard](https://github.com/jameshibbard).
**Talks/Podcasts**
-- [NodeGui and React NodeGui at KarmaJS Nov 2019 meetup: https://www.youtube.com/watch?v=8jH5gaEEDv4](https://www.youtube.com/watch?v=8jH5gaEEDv4)
+- [NodeGui and React NodeGui at KarmaJS Nov 2019 meetup: https://www.youtube.com/watch?v=8jH5gaEEDv4](https://www.youtube.com/watch?v=8jH5gaEEDv4)
--
## Docs for contributing
- ```
- It is easier than you think, try it
- ```
+```
+It is easier than you think, try it
+```
Looking to contribute? If you wish to implement a new widget/add more features and need help understanding the codebase, you can start here: [Contributing developer docs](https://github.com/nodegui/nodegui/tree/master/website/docs/development).
@@ -81,11 +94,13 @@ Please read https://github.com/nodegui/.github/blob/master/CONTRIBUTING.md
## Building
-`npm run build [--qt_home_dir=/path/to/qt]`
+`npm run build`
+
+Optionally set `QT_INSTALL_DIR='/path/to/qt'` environment variable to build using your own version of Qt.
## Funding
-NodeGUI is an open source project and requires your support. If you like this project, please consider supporting my work by clicking on the Sponsor button on this Github repository or via Ko-Fi.
+NodeGUI is an open source project and requires your support. If you like this project, please consider supporting my work by clicking on the Sponsor button on this Github repository or via Ko-Fi.
Alternatively, Issues on NodeGui can be funded by anyone via Issuehunt and the amount will be distributed to respective contributors.
@@ -94,7 +109,7 @@ Alternatively, Issues on NodeGui can be funded by anyone via Issuehunt and the a
## Special Thanks
-- [Logo: Thanks to Vishwas Shetty from the Noun Project.](https://github.com/nodegui/nodegui/blob/master/extras/legal/logo/thanks.md)
+- [Logo: Thanks to Vishwas Shetty from the Noun Project.](https://github.com/nodegui/nodegui/blob/master/extras/legal/logo/thanks.md)
## Code of Conduct
@@ -117,7 +132,6 @@ Thanks goes to these wonderful people.
-
## Maintainers β¨
People maintaining this project.
@@ -130,7 +144,6 @@ People maintaining this project.
-
## Contributors β¨
Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/docs/en/emoji-key)):
@@ -170,6 +183,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
+
This project follows the [all-contributors](https://github.com/all-contributors/all-contributors) specification. Contributions of any kind welcome!
diff --git a/package.json b/package.json
index e7fbd6863..a8d92817f 100644
--- a/package.json
+++ b/package.json
@@ -17,8 +17,8 @@
"private": false,
"scripts": {
"dev": "npm run build && qode dist/demo.js",
- "postinstall": "npm run build:addon",
"build": "tsc && npm run build:addon",
+ "postinstall": "npm run build:addon",
"build:addon": "cross-env CMAKE_BUILD_PARALLEL_LEVEL=8 cmake-js compile",
"test": "qode ./node_modules/jest/bin/jest -i",
"lint:cpp": "clang-format -i --glob=src/cpp/**/*.[h,c]*",
diff --git a/src/cpp/lib/QtWidgets/QComboBox/qcombobox_wrap.cpp b/src/cpp/lib/QtWidgets/QComboBox/qcombobox_wrap.cpp
index 6787032c3..3f301db55 100644
--- a/src/cpp/lib/QtWidgets/QComboBox/qcombobox_wrap.cpp
+++ b/src/cpp/lib/QtWidgets/QComboBox/qcombobox_wrap.cpp
@@ -1,10 +1,11 @@
#include "QtWidgets/QComboBox/qcombobox_wrap.h"
+
#include
-#include "QtCore/QVariant/qvariant_wrap.h"
-#include "QtGui/QIcon/qicon_wrap.h"
#include "Extras/Utils/nutils.h"
+#include "QtCore/QVariant/qvariant_wrap.h"
+#include "QtGui/QIcon/qicon_wrap.h"
#include "QtWidgets/QWidget/qwidget_wrap.h"
Napi::FunctionReference QComboBoxWrap::constructor;