Fix some uninitialise memory access reported by Valgrind

This commit is contained in:
Simon Edwards 2022-04-27 10:04:14 +02:00
parent ac1c118ae3
commit 81c31f4de3
13 changed files with 14 additions and 0 deletions

View File

@ -44,6 +44,7 @@ Napi::Object QItemSelectionModelWrap::init(Napi::Env env,
QItemSelectionModel* QItemSelectionModelWrap::getInternalInstance() {
return this->instance;
}
QItemSelectionModelWrap::~QItemSelectionModelWrap() {
if (!this->disableDeletion) {
extrautils::safeDelete(this->instance);

View File

@ -42,6 +42,8 @@ NAction* QActionWrap::getInternalInstance() { return this->instance; }
QActionWrap::QActionWrap(const Napi::CallbackInfo& info)
: Napi::ObjectWrap<QActionWrap>(info) {
Napi::Env env = info.Env();
this->disableDeletion = false;
if (info.Length() > 0 && info[0].IsExternal()) {
// --- if external ---
this->instance = info[0].As<Napi::External<NAction>>().Data();

View File

@ -25,6 +25,7 @@ NCheckBox* QCheckBoxWrap::getInternalInstance() { return this->instance; }
QCheckBoxWrap::QCheckBoxWrap(const Napi::CallbackInfo& info)
: Napi::ObjectWrap<QCheckBoxWrap>(info) {
Napi::Env env = info.Env();
this->disableDeletion = false;
if (info.Length() > 0 && info[0].IsExternal()) {
// --- if external ---
this->instance = info[0].As<Napi::External<NCheckBox>>().Data();

View File

@ -25,6 +25,7 @@ QListViewWrap::~QListViewWrap() {
QListViewWrap::QListViewWrap(const Napi::CallbackInfo& info)
: Napi::ObjectWrap<QListViewWrap>(info) {
Napi::Env env = info.Env();
this->disableDeletion = false;
if (info.Length() > 0 && info[0].IsExternal()) {
// --- if external ---
this->instance = info[0].As<Napi::External<NListView>>().Data();

View File

@ -66,6 +66,7 @@ QListWidgetItemWrap::~QListWidgetItemWrap() {
QListWidgetItemWrap::QListWidgetItemWrap(const Napi::CallbackInfo& info)
: Napi::ObjectWrap<QListWidgetItemWrap>(info) {
Napi::Env env = info.Env();
this->disableDeletion = false;
if (info.Length() > 0 && info[0].IsExternal()) {
// --- if external ---
this->instance = info[0].As<Napi::External<QListWidgetItem>>().Data();

View File

@ -30,6 +30,7 @@ QPushButtonWrap::~QPushButtonWrap() {
QPushButtonWrap::QPushButtonWrap(const Napi::CallbackInfo& info)
: Napi::ObjectWrap<QPushButtonWrap>(info) {
Napi::Env env = info.Env();
this->disableDeletion = false;
if (info.Length() > 0 && info[0].IsExternal()) {
// --- if external ---
this->instance = info[0].As<Napi::External<NPushButton>>().Data();

View File

@ -24,6 +24,7 @@ NRadioButton* QRadioButtonWrap::getInternalInstance() { return this->instance; }
QRadioButtonWrap::QRadioButtonWrap(const Napi::CallbackInfo& info)
: Napi::ObjectWrap<QRadioButtonWrap>(info) {
Napi::Env env = info.Env();
this->disableDeletion = false;
if (info.Length() > 0 && info[0].IsExternal()) {
// --- if external ---
this->instance = info[0].As<Napi::External<NRadioButton>>().Data();

View File

@ -36,6 +36,7 @@ QStandardItemWrap::~QStandardItemWrap() {
QStandardItemWrap::QStandardItemWrap(const Napi::CallbackInfo& info)
: Napi::ObjectWrap<QStandardItemWrap>(info) {
Napi::Env env = info.Env();
this->disableDeletion = false;
if (info.Length() > 0 && info[0].IsExternal()) {
this->instance = info[0].As<Napi::External<QStandardItem>>().Data();
if (info.Length() == 2) {

View File

@ -57,6 +57,7 @@ QTabBarWrap::~QTabBarWrap() {
QTabBarWrap::QTabBarWrap(const Napi::CallbackInfo& info)
: Napi::ObjectWrap<QTabBarWrap>(info) {
Napi::Env env = info.Env();
this->disableDeletion = false;
if (info.Length() > 0 && info[0].IsExternal()) {
// --- if external ---
this->instance = info[0].As<Napi::External<NTabBar>>().Data();

View File

@ -26,6 +26,7 @@ QTableViewWrap::~QTableViewWrap() {
QTableViewWrap::QTableViewWrap(const Napi::CallbackInfo& info)
: Napi::ObjectWrap<QTableViewWrap>(info) {
Napi::Env env = info.Env();
this->disableDeletion = false;
if (info.Length() > 0 && info[0].IsExternal()) {
// --- if external ---
this->instance = info[0].As<Napi::External<NTableView>>().Data();

View File

@ -65,6 +65,7 @@ QTableWidgetItemWrap::~QTableWidgetItemWrap() {
QTableWidgetItemWrap::QTableWidgetItemWrap(const Napi::CallbackInfo& info)
: Napi::ObjectWrap<QTableWidgetItemWrap>(info) {
Napi::Env env = info.Env();
this->disableDeletion = false;
if (info.Length() > 0 && info[0].IsExternal()) {
// --- if external ---
this->instance = info[0].As<Napi::External<QTableWidgetItem>>().Data();

View File

@ -32,6 +32,7 @@ QToolButtonWrap::~QToolButtonWrap() {
QToolButtonWrap::QToolButtonWrap(const Napi::CallbackInfo& info)
: Napi::ObjectWrap<QToolButtonWrap>(info) {
Napi::Env env = info.Env();
this->disableDeletion = false;
if (info.Length() > 0 && info[0].IsExternal()) {
// --- if external ---
this->instance = info[0].As<Napi::External<NToolButton>>().Data();

View File

@ -64,6 +64,7 @@ QTreeWidgetItemWrap::QTreeWidgetItemWrap(const Napi::CallbackInfo &info)
Napi::Env env = info.Env();
Napi::HandleScope scope(env);
this->disableDeletion = false;
if (info.Length() > 0 && info[0].IsExternal()) {
// --- if external ---
this->instance = info[0].As<Napi::External<QTreeWidgetItem>>().Data();