From b0c9bca53a19282c5af4d4f4928492571ccc875a Mon Sep 17 00:00:00 2001 From: Atul R Date: Wed, 4 Dec 2019 20:19:39 +0100 Subject: [PATCH] bumps nodegui to 0.8.0 and fix tabwidget layout issue (#248) * bumps nodegui to 0.8.0 * Fixes a size issue with tabWidgets * Fixes tabwidget not stretching * change to nodewidget --- package-lock.json | 2 +- package.json | 2 +- src/lib/QtWidgets/QTabWidget.ts | 8 +++++++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index d87d69c8e..da12fa402 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "@nodegui/nodegui", - "version": "0.7.0", + "version": "0.8.0", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 9587c24e4..e32fedb4a 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@nodegui/nodegui", - "version": "0.7.0", + "version": "0.8.0", "description": "A cross platform library to build native desktop apps.", "main": "dist/index.js", "typings": "dist/index.d.ts", diff --git a/src/lib/QtWidgets/QTabWidget.ts b/src/lib/QtWidgets/QTabWidget.ts index 4095bd0bf..91196ae03 100644 --- a/src/lib/QtWidgets/QTabWidget.ts +++ b/src/lib/QtWidgets/QTabWidget.ts @@ -15,6 +15,7 @@ export const QTabWidgetEvents = Object.freeze({ export class QTabWidget extends NodeWidget { native: NativeElement; + tabs: NodeWidget[]; constructor(parent?: NodeWidget) { let native; if (parent) { @@ -24,12 +25,14 @@ export class QTabWidget extends NodeWidget { } super(native); this.nodeParent = parent; + this.tabs = []; this.native = native; } addTab(page: NodeWidget, icon: QIcon, label: string): void { - this.nodeChildren.add(page); this.native.addTab(page.native, icon.native, label); + this.tabs.push(page); + page.setFlexNodeSizeControlled(true); } setTabPosition(tabPosition: TabPosition): void { @@ -46,6 +49,9 @@ export class QTabWidget extends NodeWidget { removeTab(index: number): void { this.native.removeTab(index); + const toRemove = this.tabs[index]; + toRemove.setFlexNodeSizeControlled(false); + this.tabs.splice(index, 1); } setTabsClosable(closeable: boolean): void {