polymech/zeroclaw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(tools): surface pdf_read empty-text warning in output

Browse Source
This commit is contained in:
Chummy 2026-02-21 01:30:24 +08:00
parent a5521ab7bc
commit ac9e5cb03c
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/tools/pdf_read.rs
View File

@ -187,10 +187,11 @@ impl Tool for PdfReadTool {
if text.trim().is_empty() {
return Ok(ToolResult {
success: true,
output: String::new(),
error: Some(
"PDF contains no extractable text (may be image-only or encrypted)".into(),
),
// Agent dispatchers currently forward `error` only when `success=false`.
// Keep this as successful execution and expose the warning in `output`.
output: "PDF contains no extractable text (may be image-only or encrypted)"
.into(),
error: None,
});
}
@ -517,12 +518,7 @@ mod tests {
// Acceptable outcomes: empty text warning, or extraction error for
// malformed hand-crafted PDF.
let is_empty_warning = result.success
&& result
.error
.as_deref()
.unwrap_or("")
.contains("no extractable");
let is_empty_warning = result.success && result.output.contains("no extractable text");
let is_extraction_error =
!result.success && result.error.as_deref().unwrap_or("").contains("extraction");
let is_resolve_error =