From c2380f845771a88f2e14c867a24b75ecbb1a479a Mon Sep 17 00:00:00 2001 From: xj Date: Sun, 1 Mar 2026 15:08:31 -0800 Subject: [PATCH] fix(ci): honor legacy MB binary size overrides --- scripts/ci/check_binary_size.sh | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/scripts/ci/check_binary_size.sh b/scripts/ci/check_binary_size.sh index 4547310e6..989d1e49d 100755 --- a/scripts/ci/check_binary_size.sh +++ b/scripts/ci/check_binary_size.sh @@ -21,6 +21,10 @@ # BINARY_SIZE_HARD_LIMIT_BYTES # BINARY_SIZE_ADVISORY_LIMIT_BYTES # BINARY_SIZE_TARGET_LIMIT_BYTES +# Legacy compatibility: +# BINARY_SIZE_HARD_LIMIT_MB +# BINARY_SIZE_ADVISORY_MB +# BINARY_SIZE_TARGET_MB # # Writes to GITHUB_STEP_SUMMARY when the variable is set and label is provided. @@ -63,6 +67,17 @@ if [ -n "${BINARY_SIZE_TARGET_LIMIT_BYTES:-}" ]; then TARGET_LIMIT_BYTES="$BINARY_SIZE_TARGET_LIMIT_BYTES" fi +# Backward-compatible MB overrides (used in older workflow configs). +if [ -z "${BINARY_SIZE_HARD_LIMIT_BYTES:-}" ] && [ -n "${BINARY_SIZE_HARD_LIMIT_MB:-}" ]; then + HARD_LIMIT_BYTES=$((BINARY_SIZE_HARD_LIMIT_MB * 1024 * 1024)) +fi +if [ -z "${BINARY_SIZE_ADVISORY_LIMIT_BYTES:-}" ] && [ -n "${BINARY_SIZE_ADVISORY_MB:-}" ]; then + ADVISORY_LIMIT_BYTES=$((BINARY_SIZE_ADVISORY_MB * 1024 * 1024)) +fi +if [ -z "${BINARY_SIZE_TARGET_LIMIT_BYTES:-}" ] && [ -n "${BINARY_SIZE_TARGET_MB:-}" ]; then + TARGET_LIMIT_BYTES=$((BINARY_SIZE_TARGET_MB * 1024 * 1024)) +fi + HARD_LIMIT_MB=$((HARD_LIMIT_BYTES / 1024 / 1024)) ADVISORY_LIMIT_MB=$((ADVISORY_LIMIT_BYTES / 1024 / 1024)) TARGET_LIMIT_MB=$((TARGET_LIMIT_BYTES / 1024 / 1024))