Fix all clippy errors reported by `cargo clippy --all-targets -- -D warnings` on Rust 1.93, covering both the original codebase and upstream dev changes. Changes by category: - format!() appended to String → write!/writeln! (telegram, discord) - Redundant field names, unnecessary boolean not (agent/loop_) - Long numeric literals (wati, nextcloud, telegram, gemini) - Wildcard match on single variant (security/leak_detector) - Derivable Default impls (config/schema) - &Option<T> → Option<&T> or allow (config/schema, config/mod, gateway/api) - Identical match arms merged (gateway/ws, observability, providers, main, onboard) - Cast truncation allowed with rationale (discord, lark) - Unnecessary borrows/returns removed (multiple files) - Unused imports removed (channels/mod, peripherals/mod, tests) - MSRV-gated APIs allowed locally (memory/hygiene, tools/shell, tools/screenshot) - Unnecessary .get().is_none() → !contains_key() (gemini) - Explicit iteration → reference loop (gateway/api) - Test-only: useless vec!, field_reassign_with_default, doc indentation Validated: cargo fmt, cargo clippy --all-targets -- -D warnings, cargo test Co-authored-by: Cursor <cursoragent@cursor.com>
93 lines
3.5 KiB
Rust
93 lines
3.5 KiB
Rust
pub mod schema;
|
|
pub mod traits;
|
|
|
|
#[allow(unused_imports)]
|
|
pub use schema::{
|
|
apply_runtime_proxy_to_builder, build_runtime_proxy_client,
|
|
build_runtime_proxy_client_with_timeouts, runtime_proxy_config, set_runtime_proxy_config,
|
|
AgentConfig, AuditConfig, AutonomyConfig, BrowserComputerUseConfig, BrowserConfig,
|
|
BuiltinHooksConfig, ChannelsConfig, ClassificationRule, ComposioConfig, Config, CostConfig,
|
|
CronConfig, DelegateAgentConfig, DiscordConfig, DockerRuntimeConfig, EmbeddingRouteConfig,
|
|
EstopConfig, FeishuConfig, GatewayConfig, HardwareConfig, HardwareTransport, HeartbeatConfig,
|
|
HooksConfig, HttpRequestConfig, IMessageConfig, IdentityConfig, LarkConfig, MatrixConfig,
|
|
MemoryConfig, ModelRouteConfig, MultimodalConfig, NextcloudTalkConfig, ObservabilityConfig,
|
|
OtpConfig, OtpMethod, PeripheralBoardConfig, PeripheralsConfig, ProxyConfig, ProxyScope,
|
|
QdrantConfig, QueryClassificationConfig, ReliabilityConfig, ResourceLimitsConfig,
|
|
RuntimeConfig, SandboxBackend, SandboxConfig, SchedulerConfig, SecretsConfig, SecurityConfig,
|
|
SkillsConfig, SkillsPromptInjectionMode, SlackConfig, StorageConfig, StorageProviderConfig,
|
|
StorageProviderSection, StreamMode, TelegramConfig, TranscriptionConfig, TunnelConfig,
|
|
WebFetchConfig, WebSearchConfig, WebhookConfig,
|
|
};
|
|
|
|
pub fn name_and_presence<T: traits::ChannelConfig>(channel: Option<&T>) -> (&'static str, bool) {
|
|
(T::name(), channel.is_some())
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn reexported_config_default_is_constructible() {
|
|
let config = Config::default();
|
|
|
|
assert!(config.default_provider.is_some());
|
|
assert!(config.default_model.is_some());
|
|
assert!(config.default_temperature > 0.0);
|
|
}
|
|
|
|
#[test]
|
|
fn reexported_channel_configs_are_constructible() {
|
|
let telegram = TelegramConfig {
|
|
bot_token: "token".into(),
|
|
allowed_users: vec!["alice".into()],
|
|
stream_mode: StreamMode::default(),
|
|
draft_update_interval_ms: 1000,
|
|
interrupt_on_new_message: false,
|
|
mention_only: false,
|
|
};
|
|
|
|
let discord = DiscordConfig {
|
|
bot_token: "token".into(),
|
|
guild_id: Some("123".into()),
|
|
allowed_users: vec![],
|
|
listen_to_bots: false,
|
|
mention_only: false,
|
|
};
|
|
|
|
let lark = LarkConfig {
|
|
app_id: "app-id".into(),
|
|
app_secret: "app-secret".into(),
|
|
encrypt_key: None,
|
|
verification_token: None,
|
|
allowed_users: vec![],
|
|
mention_only: false,
|
|
use_feishu: false,
|
|
receive_mode: crate::config::schema::LarkReceiveMode::Websocket,
|
|
port: None,
|
|
};
|
|
let feishu = FeishuConfig {
|
|
app_id: "app-id".into(),
|
|
app_secret: "app-secret".into(),
|
|
encrypt_key: None,
|
|
verification_token: None,
|
|
allowed_users: vec![],
|
|
receive_mode: crate::config::schema::LarkReceiveMode::Websocket,
|
|
port: None,
|
|
};
|
|
|
|
let nextcloud_talk = NextcloudTalkConfig {
|
|
base_url: "https://cloud.example.com".into(),
|
|
app_token: "app-token".into(),
|
|
webhook_secret: None,
|
|
allowed_users: vec!["*".into()],
|
|
};
|
|
|
|
assert_eq!(telegram.allowed_users.len(), 1);
|
|
assert_eq!(discord.guild_id.as_deref(), Some("123"));
|
|
assert_eq!(lark.app_id, "app-id");
|
|
assert_eq!(feishu.app_id, "app-id");
|
|
assert_eq!(nextcloud_talk.base_url, "https://cloud.example.com");
|
|
}
|
|
}
|