Issue: #1391 The skill audit was too strict when validating markdown links in open-skills, causing many skills to fail loading with errors like: - "absolute markdown link paths are not allowed (../other-skill/SKILL.md)" - "markdown link points to a missing file (skill-name.md)" Root cause: 1. `looks_like_absolute_path()` rejected paths starting with ".." before canonicalization could validate they stay within root 2. Missing file errors were raised for cross-skill references that are valid but point to skills not installed locally Fix: 1. Allow ".." paths to pass through to canonicalization check which properly validates they resolve within the skill root 2. Treat cross-skill references (parent dir traversal or bare .md filenames) as non-fatal when pointing to missing files Cross-skill references are identified by: - Parent directory traversal: `../other-skill/SKILL.md` - Bare skill filename: `other-skill.md` - Explicit relative: `./other-skill.md` Added 6 new tests to cover edge cases for cross-skill references. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| audit.rs | ||
| mod.rs | ||
| symlink_tests.rs | ||