Addresses all 5 findings from CodeRabbit's second review on PR #1853:
1. [Major] list_all_blocks: add MAX_PAGES (200) hard cap to prevent
unbounded pagination loops on misbehaving APIs or huge documents.
2. [Major] Empty conversion guard: action_write, action_update_block,
and write_single_cell now bail with explicit error when
convert_markdown_blocks returns empty results, preventing silent
data loss (delete-then-write-nothing scenario).
3. [Minor] action_create: grant_owner_permission failure is now a soft
warning instead of hard error. Document is already created and
verified; permission failure is reported in the response JSON
'warning' field instead of propagating as an error.
4. [Nitpick] extract_ttl_seconds: remove unreachable as_i64 fallback
branch (as_u64 already covers all non-negative integers).
5. [Nitpick] Add unit tests: test_extract_ttl_seconds_defaults_and_clamps
and test_write_rejects_empty_conversion.
Validation:
- cargo check --features channel-lark ✅
- cargo clippy -p zeroclaw --lib --features channel-lark -- -D warnings ✅
- cargo test --features channel-lark -- feishu_doc ✅ (7/7 tests pass)
xuhao
762e6082ec