No implicit this codemod (#17235)

* Run no-implicit-this codemod for app templates
* Run tagless-ember-components-codemod for plugins
* Turn on no-implicit-this lint
This commit is contained in:
Peter Wagenet
2022-07-05 10:41:31 -07:00
committed by GitHub
parent fbc1bc4255
commit 371bbadb92
635 changed files with 4626 additions and 4634 deletions
@@ -8,7 +8,7 @@
<span class="poll-breakdown-option-color" style={{this.colorPreviewStyle}}></span>
<span class="poll-breakdown-option-count">
{{#if showPercentage}}
{{#if this.showPercentage}}
{{this.percent}}%
{{else}}
{{@option.votes}}
@@ -1,119 +1,118 @@
<DModalBody @title="poll.ui_builder.title" @class="poll-ui-builder">
<div class="input-group poll-type">
<a href {{action (mut pollType) "regular"}} class="poll-type-value {{if isRegular "active"}}">
<a href {{action (mut this.pollType) "regular"}} class="poll-type-value {{if this.isRegular "active"}}">
{{i18n "poll.ui_builder.poll_type.regular"}}
</a>
<a href {{action (mut pollType) "multiple"}} class="poll-type-value {{if isMultiple "active"}}">
<a href {{action (mut this.pollType) "multiple"}} class="poll-type-value {{if this.isMultiple "active"}}">
{{i18n "poll.ui_builder.poll_type.multiple"}}
</a>
{{#if showNumber}}
<a href {{action (mut pollType) "number"}} class="poll-type-value {{if isNumber "active"}}">
{{#if this.showNumber}}
<a href {{action (mut this.pollType) "number"}} class="poll-type-value {{if this.isNumber "active"}}">
{{i18n "poll.ui_builder.poll_type.number"}}
</a>
{{/if}}
</div>
{{#if showAdvanced}}
{{#if this.showAdvanced}}
<div class="input-group poll-title">
<label class="input-group-label">{{i18n "poll.ui_builder.poll_title.label"}}</label>
<Input @value={{pollTitle}} />
<Input @value={{this.pollTitle}} />
</div>
{{/if}}
{{#unless isNumber}}
{{#unless this.isNumber}}
<div class="poll-options">
{{#if showAdvanced}}
{{#if this.showAdvanced}}
<label class="input-group-label">{{i18n "poll.ui_builder.poll_options.label"}}</label>
<Textarea @value={{pollOptionsText}} @input={{action "onOptionsTextChange"}} />
{{#if showMinNumOfOptionsValidation}}
{{#unless minNumOfOptionsValidation.ok}}
<InputTip @validation={{minNumOfOptionsValidation}} />
<Textarea @value={{this.pollOptionsText}} @input={{action "onOptionsTextChange"}} />
{{#if this.showMinNumOfOptionsValidation}}
{{#unless this.minNumOfOptionsValidation.ok}}
<InputTip @validation={{this.minNumOfOptionsValidation}} />
{{/unless}}
{{/if}}
{{else}}
{{#each pollOptions as |option|}}
{{#each this.pollOptions as |option|}}
<div class="input-group poll-option-value">
<Input @value={{option.value}} @enter={{action "addOption" option}} />
{{#if canRemoveOption}}
{{#if this.canRemoveOption}}
<DButton @icon="trash-alt" @action={{action "removeOption" option}} />
{{/if}}
</div>
{{/each}}
<div class="poll-option-controls">
<DButton @class="btn-default" @icon="plus" @label="poll.ui_builder.poll_options.add" @action={{action "addOption" pollOptions.lastObject}} />
{{#if (and showMinNumOfOptionsValidation (not minNumOfOptionsValidation.ok))}}
<InputTip @validation={{minNumOfOptionsValidation}} />
<DButton @class="btn-default" @icon="plus" @label="poll.ui_builder.poll_options.add" @action={{action "addOption" this.pollOptions.lastObject}} />
{{#if (and this.showMinNumOfOptionsValidation (not this.minNumOfOptionsValidation.ok))}}
<InputTip @validation={{this.minNumOfOptionsValidation}} />
{{/if}}
</div>
{{/if}}
</div>
{{/unless}}
{{#unless isRegular}}
{{#unless this.isRegular}}
<div class="options">
<div class="input-group poll-number">
<label class="input-group-label">{{i18n "poll.ui_builder.poll_config.min"}}</label>
<Input @type="number" @value={{pollMin}} @valueProperty="value" class="poll-options-min" @min={{1}} />
<Input @type="number" @value={{this.pollMin}} @valueProperty="value" class="poll-options-min" @min={{1}} />
</div>
<div class="input-group poll-number">
<label class="input-group-label">{{i18n "poll.ui_builder.poll_config.max"}}</label>
<Input @type="number" @value={{pollMax}} @valueProperty="value" class="poll-options-max" @min={{1}} />
<Input @type="number" @value={{this.pollMax}} @valueProperty="value" class="poll-options-max" @min={{1}} />
</div>
{{#if isNumber}}
{{#if this.isNumber}}
<div class="input-group poll-number">
<label class="input-group-label">{{i18n "poll.ui_builder.poll_config.step"}}</label>
<Input @type="number" @value={{pollStep}} @valueProperty="value" @min="1" class="poll-options-step" />
<Input @type="number" @value={{this.pollStep}} @valueProperty="value" @min="1" class="poll-options-step" />
</div>
{{/if}}
</div>
{{#unless minMaxValueValidation.ok}}
<InputTip @validation={{minMaxValueValidation}} />
{{#unless this.minMaxValueValidation.ok}}
<InputTip @validation={{this.minMaxValueValidation}} />
{{/unless}}
{{/unless}}
{{#if showAdvanced}}
{{#if this.showAdvanced}}
<div class="input-group poll-allowed-groups">
<label class="input-group-label">{{i18n "poll.ui_builder.poll_groups.label"}}</label>
<GroupChooser @content={{siteGroups}} @value={{pollGroups}} @onChange={{action (mut pollGroups)}} @labelProperty="name" @valueProperty="name" />
<GroupChooser @content={{this.siteGroups}} @value={{this.pollGroups}} @onChange={{action (mut this.pollGroups)}} @labelProperty="name" @valueProperty="name" />
</div>
<div class="input-group poll-date">
<label class="input-group-label">{{i18n "poll.ui_builder.automatic_close.label"}}</label>
<DateTimeInput @date={{pollAutoClose}} @onChange={{action (mut pollAutoClose)}} @clearable={{true}} @useGlobalPickerContainer={{true}} />
<DateTimeInput @date={{this.pollAutoClose}} @onChange={{action (mut this.pollAutoClose)}} @clearable={{true}} @useGlobalPickerContainer={{true}} />
</div>
<div class="input-group poll-select">
<label class="input-group-label">{{i18n "poll.ui_builder.poll_result.label"}}</label>
<ComboBox @content={{pollResults}} @value={{pollResult}} @class="poll-result" @valueProperty="value" @onChange={{action (mut pollResult)}} />
<ComboBox @content={{this.pollResults}} @value={{this.pollResult}} @class="poll-result" @valueProperty="value" @onChange={{action (mut this.pollResult)}} />
</div>
{{#unless isNumber}}
{{#unless this.isNumber}}
<div class="input-group poll-select column">
<label class="input-group-label">{{i18n "poll.ui_builder.poll_chart_type.label"}}</label>
<div class="radio-group">
<RadioButton @id="poll-chart-type-bar" @name="poll-chart-type" @value="bar" @selection={{chartType}} />
<RadioButton @id="poll-chart-type-bar" @name="poll-chart-type" @value="bar" @selection={{this.chartType}} />
<label for="poll-chart-type-bar">{{d-icon "chart-bar"}} {{i18n "poll.ui_builder.poll_chart_type.bar"}}</label>
</div>
<div class="radio-group">
<RadioButton @id="poll-chart-type-pie" @name="poll-chart-type" @value="pie" @selection={{chartType}} />
<RadioButton @id="poll-chart-type-pie" @name="poll-chart-type" @value="pie" @selection={{this.chartType}} />
<label for="poll-chart-type-pie">{{d-icon "chart-pie"}} {{i18n "poll.ui_builder.poll_chart_type.pie"}}</label>
</div>
</div>
{{/unless}}
{{#unless isPie}}
{{#unless this.isPie}}
<div class="input-group poll-checkbox column">
<label>
<Input @type="checkbox" @checked={{publicPoll}} />
<Input @type="checkbox" @checked={{this.publicPoll}} />
{{i18n "poll.ui_builder.poll_public.label"}}
</label>
</div>
@@ -122,9 +121,9 @@
</DModalBody>
<div class="modal-footer">
<DButton @action={{action "insertPoll"}} @icon="chart-bar" @class="btn-primary" @label="poll.ui_builder.insert" @disabled={{disableInsert}} />
<DButton @action={{action "insertPoll"}} @icon="chart-bar" @class="btn-primary" @label="poll.ui_builder.insert" @disabled={{this.disableInsert}} />
<DButton @label="cancel" @class="btn-flat" @action={{route-action "closeModal"}} />
<DButton @action={{action "toggleAdvanced"}} @class="btn-default show-advanced" @icon="cog" @title={{if showAdvanced "poll.ui_builder.hide_advanced" "poll.ui_builder.show_advanced"}} />
<DButton @action={{action "toggleAdvanced"}} @class="btn-default show-advanced" @icon="cog" @title={{if this.showAdvanced "poll.ui_builder.hide_advanced" "poll.ui_builder.show_advanced"}} />
</div>