This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.
osr-discourse-src/app/assets/javascripts/discourse/tests/unit
Jarek Radosz a17d54d0bf
DEV: De-arrowify tests (#11068)
Using arrow functions changes `this` context, which is undesired in tests, e.g. it makes it impossible to setup things like pretender (`this.server`) in `beforeEach` hooks.

Ember guides always use classic functions in examples (e.g. https://guides.emberjs.com/release/testing/test-types/), and that's what it uses in its own test suite, as do various addons and ember apps.

It was also already used in Discourse where `this` was required. Moving forward, it will be needed in more places as we migrate toward ember-cli.

(I might later add a custom rule to eslint-discourse-ember to enforce this)
2020-10-30 17:37:32 +01:00
..
controllers FEATURE: Ask user to confirm topic deletion when views exceed a certain amount (#11006) 2020-10-29 14:18:43 +11:00
ember DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
lib DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
mixins DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
models DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
services REFACTOR: Import QUnit and related helpers rather than globals 2020-10-07 11:50:49 -04:00
utils REFACTOR: Test assertions should be imported. 2020-10-28 11:39:06 -04:00
localization-test.js REFACTOR: Import QUnit and related helpers rather than globals 2020-10-07 11:50:49 -04:00