This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.
osr-discourse-src/app/assets/javascripts/discourse/tests/unit/models
Jarek Radosz a17d54d0bf
DEV: De-arrowify tests (#11068)
Using arrow functions changes `this` context, which is undesired in tests, e.g. it makes it impossible to setup things like pretender (`this.server`) in `beforeEach` hooks.

Ember guides always use classic functions in examples (e.g. https://guides.emberjs.com/release/testing/test-types/), and that's what it uses in its own test suite, as do various addons and ember apps.

It was also already used in Discourse where `this` was required. Moving forward, it will be needed in more places as we migrate toward ember-cli.

(I might later add a custom rule to eslint-discourse-ember to enforce this)
2020-10-30 17:37:32 +01:00
..
badge-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
category-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
composer-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
email-log-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
group-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
invite-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
nav-item-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
post-stream-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
post-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
report-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
rest-model-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
result-set-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
session-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
site-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
staff-action-log-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
store-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
topic-details-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
topic-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
topic-tracking-state-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
user-action-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
user-badge-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
user-drafts-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
user-stream-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00
user-test.js DEV: De-arrowify tests (#11068) 2020-10-30 17:37:32 +01:00