Using arrow functions changes `this` context, which is undesired in tests, e.g. it makes it impossible to setup things like pretender (`this.server`) in `beforeEach` hooks. Ember guides always use classic functions in examples (e.g. https://guides.emberjs.com/release/testing/test-types/), and that's what it uses in its own test suite, as do various addons and ember apps. It was also already used in Discourse where `this` was required. Moving forward, it will be needed in more places as we migrate toward ember-cli. (I might later add a custom rule to eslint-discourse-ember to enforce this)
52 lines
1.4 KiB
JavaScript
52 lines
1.4 KiB
JavaScript
import { test, module } from "qunit";
|
|
import EmberObject from "@ember/object";
|
|
import Setting from "admin/mixins/setting-object";
|
|
|
|
module("mixin:setting-object");
|
|
|
|
test("flat array", function (assert) {
|
|
const FooSetting = EmberObject.extend(Setting);
|
|
|
|
const fooSettingInstance = FooSetting.create({
|
|
valid_values: ["foo", "bar"],
|
|
});
|
|
|
|
assert.equal(fooSettingInstance.computedValueProperty, null);
|
|
assert.equal(fooSettingInstance.computedNameProperty, null);
|
|
});
|
|
|
|
test("object", function (assert) {
|
|
const FooSetting = EmberObject.extend(Setting);
|
|
|
|
const fooSettingInstance = FooSetting.create({
|
|
valid_values: [{ value: "foo", name: "bar" }],
|
|
});
|
|
|
|
assert.equal(fooSettingInstance.computedValueProperty, "value");
|
|
assert.equal(fooSettingInstance.computedNameProperty, "name");
|
|
});
|
|
|
|
test("no values", function (assert) {
|
|
const FooSetting = EmberObject.extend(Setting);
|
|
|
|
const fooSettingInstance = FooSetting.create({
|
|
valid_values: [],
|
|
});
|
|
|
|
assert.equal(fooSettingInstance.computedValueProperty, null);
|
|
assert.equal(fooSettingInstance.computedNameProperty, null);
|
|
});
|
|
|
|
test("value/name properties defined", function (assert) {
|
|
const FooSetting = EmberObject.extend(Setting);
|
|
|
|
const fooSettingInstance = FooSetting.create({
|
|
valueProperty: "foo",
|
|
nameProperty: "bar",
|
|
valid_values: [],
|
|
});
|
|
|
|
assert.equal(fooSettingInstance.computedValueProperty, "foo");
|
|
assert.equal(fooSettingInstance.computedNameProperty, "bar");
|
|
});
|