a17d54d0bf
Using arrow functions changes `this` context, which is undesired in tests, e.g. it makes it impossible to setup things like pretender (`this.server`) in `beforeEach` hooks. Ember guides always use classic functions in examples (e.g. https://guides.emberjs.com/release/testing/test-types/), and that's what it uses in its own test suite, as do various addons and ember apps. It was also already used in Discourse where `this` was required. Moving forward, it will be needed in more places as we migrate toward ember-cli. (I might later add a custom rule to eslint-discourse-ember to enforce this)
44 lines
1.2 KiB
JavaScript
44 lines
1.2 KiB
JavaScript
import { skip } from "qunit";
|
|
import { test, module } from "qunit";
|
|
import { loadScript, cacheBuster } from "discourse/lib/load-script";
|
|
import { PUBLIC_JS_VERSIONS as jsVersions } from "discourse/lib/public-js-versions";
|
|
|
|
module("lib:load-script");
|
|
|
|
skip("load with a script tag, and callbacks are only executed after script is loaded", async function (assert) {
|
|
assert.ok(
|
|
typeof window.ace === "undefined",
|
|
"ensures ace is not previously loaded"
|
|
);
|
|
|
|
const src = "/javascripts/ace/ace.js";
|
|
|
|
await loadScript(src);
|
|
assert.ok(
|
|
typeof window.ace !== "undefined",
|
|
"callbacks should only be executed after the script has fully loaded"
|
|
);
|
|
});
|
|
|
|
test("works when a value is not present", function (assert) {
|
|
assert.equal(
|
|
cacheBuster("/javascripts/my-script.js"),
|
|
"/javascripts/my-script.js"
|
|
);
|
|
assert.equal(
|
|
cacheBuster("/javascripts/my-project/script.js"),
|
|
"/javascripts/my-project/script.js"
|
|
);
|
|
});
|
|
|
|
test("generates URLs with version number in the query params", function (assert) {
|
|
assert.equal(
|
|
cacheBuster("/javascripts/pikaday.js"),
|
|
`/javascripts/${jsVersions["pikaday.js"]}`
|
|
);
|
|
assert.equal(
|
|
cacheBuster("/javascripts/ace/ace.js"),
|
|
`/javascripts/${jsVersions["ace/ace.js"]}`
|
|
);
|
|
});
|