This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.

Osama Sayegh e67670c1e4 FIX: Consistently show history modal when clicking edit notifications (#13912) ... Currently when a user clicks on an edit notification, we use `appEvents` to notify the topics controller that it should open up the history modal for the edited post and the appEvents callback opens up the history modal in the next Ember runloop (by scheduling an `afterRender` callback). There are 2 problems with this implementation: 1) the callbacks are fired/executed too early and if the post has never been loaded from the server (i.e. not in cache), we will not get a modal history because the method that shows the modal `return`s if it can't find the post: 016efeadf6/app/assets/javascripts/discourse/app/controllers/topic.js (L145-L152) 2) when clicking an edit notification from a non-topic page, you're redirected to the topic page that contains the edited post and you'll see the history modal briefly and it'll be closed immediately. The reason for this is because we attempt to show the history modal before the route transition finishes completely, and we have cleanup code in `initializers/page-tracking.js` that's called after every transition and it does several things one of which is closing any open modals. The fix in this commit defers showing the history modal until posts are loaded (whether fresh or cached). It works by storing some bits of information (topic id, post number, revision number) whenever the user clicks on an edit notification, and when the user is redirected to the topic (or scrolled to the edited post if they're already in the topic), the post stream model checks if we have stored information of an edit notification and requests the history modal to be shown by the topics controller.		2021-08-03 19:06:23 +03:00
..
acceptance	FIX: Consistently show history modal when clicking edit notifications (#13912)	2021-08-03 19:06:23 +03:00
fixtures	FIX: Consistently show history modal when clicking edit notifications (#13912)	2021-08-03 19:06:23 +03:00
helpers	FIX: Consistently show history modal when clicking edit notifications (#13912)	2021-08-03 19:06:23 +03:00
integration	FIX: Consistently show history modal when clicking edit notifications (#13912)	2021-08-03 19:06:23 +03:00
unit	FEATURE: Initial implementation of direct S3 uploads with uppy and stubs (#13787)	2021-07-28 08:42:25 +10:00
core_plugins_tests.js	FEATURE: Allow theme tests to be run in production (take 2) (#12845)	2021-04-28 23:12:08 +03:00
index.html	DEV: Allow plugin tests to run in Ember CLI qunit	2021-06-24 10:13:35 -04:00
plugin_tests.js.erb	FIX: Load .js files from plugins in qunit testing env (#11304)	2020-12-03 10:25:42 -06:00
setup-tests.js	DEV: Plugin API to add directory columns (#13440)	2021-06-22 13:00:04 -05:00
test_helper.js	DEV: Move pretty-text into vendor and use that (#13273)	2021-06-04 11:01:59 -04:00
test_starter.js	Update menu swipe (#13277)	2021-06-07 12:31:16 -07:00
test-helper.js	DEV: avoids using document.write (#13858)	2021-07-27 14:42:21 +02:00
theme_qunit_ember_jquery.js	FIX: Theme tests should work in production (#13333)	2021-06-08 22:03:59 +03:00
theme_qunit_helper.js	DEV: Arrange theme QUnit dependencies in the right order (#12907)	2021-04-30 13:28:33 +03:00
theme_qunit_tests_vendor.js	FIX: Theme tests should work in production (#13333)	2021-06-08 22:03:59 +03:00
theme_qunit_vendor.js	FEATURE: Optimize images before upload (#13432)	2021-06-23 12:31:12 -03:00