osr-plastic/osr-discourse-src
Archived
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.
bd70de5c07
osr-discourse-src/app/assets/javascripts/discourse/tests/acceptance
History
Osama Sayegh e67670c1e4
FIX: Consistently show history modal when clicking edit notifications (#13912) 
Currently when a user clicks on an edit notification, we use `appEvents` to
notify the topics controller that it should open up the history modal for the
edited post and the appEvents callback opens up the history modal in the next
Ember runloop (by scheduling an `afterRender` callback).

There are 2 problems with this implementation:

1) the callbacks are fired/executed too early and if the post has never been
loaded from the server (i.e. not in cache), we will not get a modal history
because the method that shows the modal `return`s if it can't find the post:

016efeadf6/app/assets/javascripts/discourse/app/controllers/topic.js (L145-L152)

2) when clicking an edit notification from a non-topic page, you're redirected
to the topic page that contains the edited post and you'll see the history
modal briefly and it'll be closed immediately. The reason for this is because
we attempt to show the history modal before the route transition finishes
completely, and we have cleanup code in `initializers/page-tracking.js` that's
called after every transition and it does several things one of which is
closing any open modals.

The fix in this commit defers showing the history modal until posts are loaded
(whether fresh or cached). It works by storing some bits of information (topic
id, post number, revision number) whenever the user clicks on an edit
notification, and when the user is redirected to the topic (or scrolled to the
edited post if they're already in the topic), the post stream model checks if
we have stored information of an edit notification and requests the history
modal to be shown by the topics controller.
2021-08-03 19:06:23 +03:00
..
about-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
account-created-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
admin-badges-award-test.js FEATURE: Add option to grant badge multiple times to users using Bulk Award (#13571) 2021-07-15 05:53:26 +03:00
admin-badges-show-test.js DEV: prevents badges tests to log 404 (#13859) 2021-07-27 14:46:49 +02:00
admin-emails-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
admin-install-theme-modal-test.js FIX: Allow CodeCommit-style theme .git url format (#12739) 2021-04-16 12:46:34 -04:00
admin-search-log-term-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
admin-search-logs-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
admin-silence-user-test.js DEV: add more tests for future-date-input-selector (#13836) 2021-07-23 22:44:23 +04:00
admin-site-settings-test.js FIX: force refresh staff action logs when transitioning from site settings (#12096) 2021-02-17 00:18:39 +05:30
admin-site-text-test.js UX: Text customization for different languages. (#11729) 2021-01-18 14:53:45 -03:00
admin-suspend-user-test.js DEV: add more tests for future-date-input-selector (#13836) 2021-07-23 22:44:23 +04:00
admin-user-badges-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
admin-user-emails-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
admin-user-index-test.js FEATURE: Add post edits count to user activity (#13495) 2021-08-02 10:15:53 -04:00
admin-users-list-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
admin-watched-words-test.js FIX: only delete the word/phrase when the 'x' icon is clicked (#13547) 2021-06-28 15:14:18 +05:30
auth-complete-test.js UX: login; smaller titles, more consistent spacing, other fixes (#12317) 2021-03-09 17:00:46 -05:00
badges-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
bookmarks-test.js FIX: topic level bookmark button (#13530) 2021-06-28 12:24:23 +04:00
category-banner-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
category-chooser-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
category-edit-security-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
category-edit-test.js SECURITY: Do not allow unauthorized access to category edit UI (#13252) 2021-06-02 13:18:45 -04:00
category-new-test.js Add category breadcrumbs to edit category page (#13126) 2021-05-25 13:40:11 -05:00
click-track-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
composer-actions-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
composer-attachment-test.js FEATURE: pass supported file extensions to the system file picker (#13583) 2021-07-01 17:13:20 +04:00
composer-draft-saving-test.js FEATURE: Don't show the draft checkmark when drafts are saved (#13292) 2021-06-08 13:22:49 +04:00
composer-edit-conflict-test.js FIX: Skip failing tests for composer (#13394) 2021-06-16 11:42:43 +10:00
composer-hyperlink-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
composer-onebox-test.js FIX: Cache missing inline oneboxes (#12953) 2021-05-06 19:08:04 +03:00
composer-tags-test.js FIX: Clientside validate min tags for required tag group (#12758) 2021-04-20 10:39:13 +10:00
composer-test.js FIX: Do not offer to save draft if invalid (#13863) 2021-07-30 10:43:09 +03:00
composer-topic-links-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
composer-uncategorized-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
create-account-external-test.js UX: login; smaller titles, more consistent spacing, other fixes (#12317) 2021-03-09 17:00:46 -05:00
create-account-user-fields-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
create-invite-modal-test.js DEV: add more tests for future-date-input-selector (#13836) 2021-07-23 22:44:23 +04:00
custom-html-set-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
custom-html-template-test.js DEV: Remove ember export which has long been deprecated. 2021-07-30 09:39:31 +08:00
dashboard-test.js FEATURE: Add new features section in admin dashboard (#11731) 2021-01-22 10:09:02 -05:00
do-not-disturb-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
edit-notification-click-test.js FIX: Consistently show history modal when clicking edit notifications (#13912) 2021-08-03 19:06:23 +03:00
email-notice-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
emoji-picker-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
emoji-test.js DEV: Remove JoyPixels emoji option (#12197) 2021-02-26 07:44:52 -05:00
encoded-category-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
enforce-second-factor-test.js DEV: Sync up more Ember CLI features (#11790) 2021-01-21 15:55:39 -05:00
flag-post-test.js FEATURE: Accept the flag modal on CTRL + ENTER and CMD + ENTER (#13497) 2021-06-24 14:13:38 +04:00
forgot-password-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
group-index-test.js FEATURE: Split Add Members into Add Users & Invite (#13482) 2021-06-23 17:31:25 +03:00
group-manage-categories-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
group-manage-email-settings-test.js DEV: Do not re-throw in popupAjaxError (#13462) 2021-06-22 19:29:20 +02:00
group-manage-interaction-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
group-manage-logs-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
group-manage-membership-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
group-manage-profile-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
group-manage-tags-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
group-requests-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
group-test.js FIX: Don't downcase "all groups" in dropdown 2021-07-13 20:29:07 +02:00
groups-index-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
groups-new-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
hamburger-menu-test.js DEV: prettier 2.2.1 (#11862) 2021-01-27 12:39:20 +01:00
hashtags-test.js FIX: Make category slugs lowercase (#11277) 2021-01-12 17:28:33 +02:00
invite-accept-test.js FIX: display warning when SSO email is different from invite email (#13804) 2021-07-21 17:03:04 +10:00
invite-show-user-fields-test.js DEV: Sync up more Ember CLI features (#11790) 2021-01-21 15:55:39 -05:00
jump-to-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
keyboard-shortcuts-test.js DEV: Try fix keyboard shortcut acceptance tests (#13576) 2021-07-01 12:25:26 +10:00
login-redirect-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
login-required-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
login-with-email-and-hide-email-address-taken-test.js UX: add link for email login below username, remove button (#12118) 2021-02-24 16:30:08 -05:00
login-with-email-and-no-social-logins-test.js UX: add link for email login below username, remove button (#12118) 2021-02-24 16:30:08 -05:00
login-with-email-disabled-test.js UX: add link for email login below username, remove button (#12118) 2021-02-24 16:30:08 -05:00
login-with-email-test.js UX: add link for email login below username, remove button (#12118) 2021-02-24 16:30:08 -05:00
mobile-discovery-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
mobile-pan-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
mobile-sign-in-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
mobile-users-test.js FEATURE: Add user custom fields to user directory (#13238) 2021-06-07 12:34:01 -05:00
modal-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
new-message-test.js DEV: {{user-selector}} replacement (#11726) 2021-02-01 13:07:11 +03:00
new-topic-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
notifications-filter-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
notifications-test.js FIX: Consistently show history modal when clicking edit notifications (#13912) 2021-08-03 19:06:23 +03:00
opengraph-tag-updater-test.js FIX: Safari iOS page title and url regression when sharing (#11699) 2021-01-13 11:10:43 -05:00
page-publishing-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
password-reset-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
personal-message-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
plugin-keyboard-shortcut-test.js FIX: Isolate modal and global key-binds (#12477) 2021-03-29 13:58:03 +02:00
plugin-outlet-connector-class-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
plugin-outlet-decorator-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
plugin-outlet-multi-template-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
plugin-outlet-single-template-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
post-admin-menu-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
preferences-test.js FIX: don't allow category and tag tracking settings on staged users (#13688) 2021-07-16 14:50:40 -04:00
raw-plugin-outlet-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
redirect-to-top-test.js FEATURE: add period filter in top topics route for tags. (#13415) 2021-07-06 15:25:11 +05:30
reports-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
review-test.js FIX: Clear stale status of reloaded reviewables (#13750) 2021-07-16 19:57:12 +03:00
search-full-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
search-mobile-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
search-test.js UX: Improve quick search suggestions (#13813) 2021-07-21 14:00:27 -04:00
share-topic-test.js UX: consistent share modal & popup, refactoring (#13759) 2021-07-19 09:34:44 +08:00
shared-drafts-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
sign-in-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
static-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
tag-groups-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
tags-intersection-test.js FEATURE: Always show tag dropdown when tagging is enabled (#12209) 2021-03-10 21:13:15 -05:00
tags-test.js FEATURE: Add last visit indication to topic view page. (#13471) 2021-07-05 14:17:31 +08:00
topic-admin-menu-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
topic-anonymous-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
topic-bulk-actions-test.js DEV: add JS test for topic bulk action modal (#12621) 2021-04-07 06:34:36 +05:30
topic-discovery-test.js FEATURE: add period filter in top topics route for tags. (#13415) 2021-07-06 15:25:11 +05:30
topic-edit-timer-test.js FIX: Reorder and hide topic timer options (#13597) 2021-07-01 13:18:38 +10:00
topic-footer-buttons-mobile-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
topic-list-tracker-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
topic-move-posts-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
topic-notifications-button-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
topic-quote-button-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
topic-set-slow-mode-test.js DEV: add more tests for future-date-input-selector (#13836) 2021-07-23 22:44:23 +04:00
topic-slow-mode-test.js UX: show Update button instead of Enable button when slow mode is already enabled (#13077) 2021-05-25 13:33:39 +04:00
topic-test.js UX: consistent share modal & popup, refactoring (#13759) 2021-07-19 09:34:44 +08:00
topic-timeline-test.js FIX: Use created_at if last_posted_at is null (#13668) 2021-07-12 19:35:40 +03:00
unknown-test.js FIX: handle permalinks with query parameters (#12700) 2021-04-14 20:03:25 +02:00
user-anonymous-test.js FIX: user/badges grid fix (#13729) 2021-07-14 16:43:24 +02:00
user-bookmarks-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
user-card-test.js DEV: Sync up more Ember CLI features (#11790) 2021-01-21 15:55:39 -05:00
user-drafts-stream-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
user-preferences-interface-test.js Code review comments. 2021-06-21 11:06:58 +08:00
user-preferences-notifications-test.js DEV: add more tests for future-date-input-selector (#13836) 2021-07-23 22:44:23 +04:00
user-private-messages-test.js FEATURE: New and Unread messages for user personal messages. (#13603) 2021-08-02 12:41:41 +08:00
user-test.js FIX: Consistently show history modal when clicking edit notifications (#13912) 2021-08-03 19:06:23 +03:00
users-test.js FEATURE: Add user custom fields to user directory (#13238) 2021-06-07 12:34:01 -05:00