This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.
osr-discourse-src/app/assets/javascripts/discourse/app
David Taylor c44650eec5
FIX: Do not render user-avatar-flair element when user has no flair (#13369)
Rendering an empty flair element with the css `background-image: url();` causes the browser to attempt an image request against the current document URL. Making duplicate requests for the document URL can cause some unusual race conditions, especially related to cookies. If this user-avatar-flair element was present on the site homepage (e.g. if categories+latest is the homepage), then it can prevent the signup flow from working correctly.

This commit updates the user-avatar-flair component to be a transparent wrapper around the avatar-flair component. If the user has no flair, no avatar-flair element will be rendered. This avoids the `background-image: url();` situation, and fixes the auth flow.

This commit also removes the duplicate avatar flair rendering from the `latest-topic-list-item` component. This wasn't particularly obvious, since the duplicate flairs were being rendered directly on top of each other.
2021-06-14 15:12:57 +01:00
..
adapters DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
components FIX: Do not render user-avatar-flair element when user has no flair (#13369) 2021-06-14 15:12:57 +01:00
controllers UX: Improvements for reordering categories (#13013) 2021-06-09 13:01:06 +03:00
helpers A11Y: Adjust heading rules on topic lists (#13353) 2021-06-10 10:59:30 +10:00
initializers FIX: Escape periods in current user's username before generating RegExp (#13247) 2021-06-03 14:15:38 +10:00
lib FIX: Clicking on a URL with a different url prefix did not work (#13349) 2021-06-11 11:44:30 +10:00
mixins PERF: Animate request animation frame (#13337) 2021-06-09 04:26:52 -10:00
models FIX: Do not reload post if raw is present (#13335) 2021-06-11 11:00:41 +10:00
pre-initializers DEV: Remove cache option from ajax() (#13142) 2021-05-31 14:41:35 +02:00
raw-views A11Y: makes replies count a button and not a link (#12570) 2021-04-06 08:27:43 +02:00
routes FEATURE: Add group filter to user directory (#13330) 2021-06-08 13:20:08 -05:00
services FEATURE: Introduce theme/component QUnit tests (take 2) (#12661) 2021-04-12 15:02:58 +03:00
styles DEV: Migrate to Ember CLI (#11932) 2021-02-03 14:22:20 -05:00
templates FIX: Do not render user-avatar-flair element when user has no flair (#13369) 2021-06-14 15:12:57 +01:00
widgets FIX: Lots of plugin tests were using old, non-Ember compat CLI APIs (#13320) 2021-06-09 10:58:55 -04:00
app.js FEATURE: Introduce theme/component QUnit tests (take 2) (#12661) 2021-04-12 15:02:58 +03:00
index.html DEV: Remove unused offscreen-content (#13133) 2021-05-25 18:39:06 +02:00
mapping-router.js DEV: prettier 2.2.1 (#11862) 2021-01-27 12:39:20 +01:00