This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.
osr-discourse-src/app/assets/javascripts/discourse
David Taylor c44650eec5
FIX: Do not render user-avatar-flair element when user has no flair (#13369)
Rendering an empty flair element with the css `background-image: url();` causes the browser to attempt an image request against the current document URL. Making duplicate requests for the document URL can cause some unusual race conditions, especially related to cookies. If this user-avatar-flair element was present on the site homepage (e.g. if categories+latest is the homepage), then it can prevent the signup flow from working correctly.

This commit updates the user-avatar-flair component to be a transparent wrapper around the avatar-flair component. If the user has no flair, no avatar-flair element will be rendered. This avoids the `background-image: url();` situation, and fixes the auth flow.

This commit also removes the duplicate avatar flair rendering from the `latest-topic-list-item` component. This wasn't particularly obvious, since the duplicate flairs were being rendered directly on top of each other.
2021-06-14 15:12:57 +01:00
..
app FIX: Do not render user-avatar-flair element when user has no flair (#13369) 2021-06-14 15:12:57 +01:00
config FIX: ember-cli proxy subfolder fix (#12996) 2021-05-10 10:02:33 -07:00
lib DEV: Correct typos and spelling mistakes (#12812) 2021-05-21 11:43:47 +10:00
public/assets/scripts REFACTOR: Use a <script src> tag to start the app (#12401) 2021-03-16 09:36:11 -04:00
tests FIX: Do not render user-avatar-flair element when user has no flair (#13369) 2021-06-14 15:12:57 +01:00
.ember-cli REFACTOR: Sync up master with changes for Ember-CLI (#11671) 2021-01-12 10:13:21 -05:00
ember-cli-build.js FIX: Lots of plugin tests were using old, non-Ember compat CLI APIs (#13320) 2021-06-09 10:58:55 -04:00
package.json DEV: Add peer dependencies (#13132) 2021-05-25 18:39:40 +02:00
testem.js FIX: Use the no-sandbox flag when running Ember CLI tests. (#12951) 2021-05-05 14:02:26 -03:00