This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.
osr-discourse-src/app/assets/javascripts/discourse/tests
David Taylor c44650eec5
FIX: Do not render user-avatar-flair element when user has no flair (#13369)
Rendering an empty flair element with the css `background-image: url();` causes the browser to attempt an image request against the current document URL. Making duplicate requests for the document URL can cause some unusual race conditions, especially related to cookies. If this user-avatar-flair element was present on the site homepage (e.g. if categories+latest is the homepage), then it can prevent the signup flow from working correctly.

This commit updates the user-avatar-flair component to be a transparent wrapper around the avatar-flair component. If the user has no flair, no avatar-flair element will be rendered. This avoids the `background-image: url();` situation, and fixes the auth flow.

This commit also removes the duplicate avatar flair rendering from the `latest-topic-list-item` component. This wasn't particularly obvious, since the duplicate flairs were being rendered directly on top of each other.
2021-06-14 15:12:57 +01:00
..
acceptance DEV: Remove test that is no longer providing value. 2021-06-11 12:45:37 +08:00
fixtures FEATURE: Add user custom fields to user directory (#13238) 2021-06-07 12:34:01 -05:00
helpers FIX: flaky javascript tests with fake timers (#13235) 2021-06-11 13:51:27 +04:00
integration FIX: Do not render user-avatar-flair element when user has no flair (#13369) 2021-06-14 15:12:57 +01:00
unit FIX: flaky javascript tests with fake timers (#13235) 2021-06-11 13:51:27 +04:00
core_plugins_tests.js FEATURE: Allow theme tests to be run in production (take 2) (#12845) 2021-04-28 23:12:08 +03:00
index.html FIX: Clicking on a URL with a different url prefix did not work (#13349) 2021-06-11 11:44:30 +10:00
plugin_tests.js.erb FIX: Load .js files from plugins in qunit testing env (#11304) 2020-12-03 10:25:42 -06:00
setup-tests.js FEATURE: Add user custom fields to user directory (#13238) 2021-06-07 12:34:01 -05:00
test_helper.js DEV: Move pretty-text into vendor and use that (#13273) 2021-06-04 11:01:59 -04:00
test_starter.js Update menu swipe (#13277) 2021-06-07 12:31:16 -07:00
test-helper.js DEV: Make dockcontainer and hidepassed the defaults (#12416) 2021-03-16 14:34:59 -04:00
theme_qunit_ember_jquery.js FIX: Theme tests should work in production (#13333) 2021-06-08 22:03:59 +03:00
theme_qunit_helper.js DEV: Arrange theme QUnit dependencies in the right order (#12907) 2021-04-30 13:28:33 +03:00
theme_qunit_tests_vendor.js FIX: Theme tests should work in production (#13333) 2021-06-08 22:03:59 +03:00
theme_qunit_vendor.js FIX: Theme tests should work in production (#13333) 2021-06-08 22:03:59 +03:00