This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.
osr-discourse-src/app/assets/javascripts/discourse/tests
Martin Brennan 357186ab7e
FIX: User option fields definition was being mutated on save (#15837)
In the commit d8bf2810ff we hoisted
the userOptionFields array to a module-level variable, but kept
the code inside save() the same. This causes an issue where if
save() is called twice on the same user with some array of user
option fields, the userOptionFields array is mutated, which means
the second save is likely not saving the fields intended.

This commit fixes the issue by not mutating the array. We cannot
change them into consts though, because we have an API to add more
items to the array.
2022-02-07 16:58:27 +10:00
..
acceptance FIX: User option fields definition was being mutated on save (#15837) 2022-02-07 16:58:27 +10:00
fixtures FEATURE: Validate domain settings for blocked_onebox_domain only (#15754) 2022-02-03 11:26:53 +08:00
helpers FIX: Table pasting issues with uppy (#15787) 2022-02-04 08:45:55 +10:00
integration FIX: Table pasting issues with uppy (#15787) 2022-02-04 08:45:55 +10:00
unit FIX: User option fields definition was being mutated on save (#15837) 2022-02-07 16:58:27 +10:00
active-plugins.js.erb DEV: Support for running theme test with Ember CLI (third attempt) 2022-01-13 16:02:07 -05:00
core-tests.js DEV: Support for running theme test with Ember CLI (third attempt) 2022-01-13 16:02:07 -05:00
index.html DEV: Update plugin JS loading in Ember CLI testem environment 2022-01-18 10:16:29 +00:00
plugin-tests.js.erb DEV: Support for running theme test with Ember CLI (third attempt) 2022-01-13 16:02:07 -05:00
setup-tests.js DEV: Refactor Site creation in tests (#15707) 2022-02-03 10:02:47 +00:00
test_starter.js DEV: Bump eslint-config-discourse (#14868) 2021-11-10 09:31:41 +10:00
test-boot-ember-cli.js Revert "Revert "DEV: Run Ember CLI tests in random order" (#15717)" 2022-01-27 12:22:20 -05:00
test-helpers-rails.js DEV: Support for running theme test with Ember CLI (third attempt) 2022-01-13 16:02:07 -05:00
test-support-rails.js DEV: Support for running theme test with Ember CLI (third attempt) 2022-01-13 16:02:07 -05:00
theme_qunit_ember_jquery.js FIX: Theme tests should work in production (#13333) 2021-06-08 22:03:59 +03:00