This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.
osr-discourse-src/app/assets/javascripts/discourse/tests/acceptance
Martin Brennan 357186ab7e
FIX: User option fields definition was being mutated on save (#15837)
In the commit d8bf2810ff we hoisted
the userOptionFields array to a module-level variable, but kept
the code inside save() the same. This causes an issue where if
save() is called twice on the same user with some array of user
option fields, the userOptionFields array is mutated, which means
the second save is likely not saving the fields intended.

This commit fixes the issue by not mutating the array. We cannot
change them into consts though, because we have an API to add more
items to the array.
2022-02-07 16:58:27 +10:00
..
about-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
account-created-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
admin-badges-award-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
admin-badges-show-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
admin-emails-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
admin-install-theme-modal-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
admin-search-log-term-test.js DEV: updates chart.js to 3.5.1 (#14107) 2021-08-23 13:49:49 +02:00
admin-search-logs-test.js DEV: select-kit third major update with focus on accessibility (#13303) 2021-08-23 10:44:19 +02:00
admin-silence-user-test.js DEV: select-kit third major update with focus on accessibility (#13303) 2021-08-23 10:44:19 +02:00
admin-site-settings-test.js FEATURE: Validate domain settings for blocked_onebox_domain only (#15754) 2022-02-03 11:26:53 +08:00
admin-site-text-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
admin-suspend-user-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
admin-user-badges-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
admin-user-emails-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
admin-user-index-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
admin-users-list-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
admin-watched-words-test.js DEV: Avoid using globals (#14909) 2021-11-13 13:10:13 +01:00
auth-complete-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
badges-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
bookmarks-test.js DEV: Clean up skipped tests (#15747) 2022-01-31 15:31:13 -05:00
category-banner-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
category-chooser-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
category-edit-security-test.js DEV: Fix qunit/assert-args (#14932) 2021-11-15 04:30:42 +01:00
category-edit-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
category-new-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
click-track-test.js DEV: Revisit skipped tests (#15769) 2022-02-02 12:09:03 -05:00
composer-actions-test.js DEV: Clean up skipped tests (#15747) 2022-01-31 15:31:13 -05:00
composer-draft-saving-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
composer-edit-conflict-test.js DEV: Clean up skipped tests (#15747) 2022-01-31 15:31:13 -05:00
composer-editor-mentions-test.js FIX: Autocomplete incorrectly replacing text if used mid sentence. 2022-01-18 14:25:39 +08:00
composer-hyperlink-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
composer-image-preview-test.js FIX: Add a confirm and cancel button when editing alt text (#15003) 2021-11-19 10:57:09 +08:00
composer-onebox-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
composer-tags-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
composer-test.js DEV: Clean up skipped tests (#15747) 2022-01-31 15:31:13 -05:00
composer-topic-links-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
composer-uncategorized-test.js DEV: Refactor Site creation in tests (#15707) 2022-02-03 10:02:47 +00:00
composer-uploads-uppy-test.js FIX: Caret moves to a wrong position when uploading an image via toolbar (#15684) 2022-02-04 18:26:48 +04:00
create-account-external-test.js FEATURE: Allow linking an existing account during external-auth signup 2021-08-10 15:07:40 +01:00
create-account-user-fields-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
create-invite-modal-test.js Improved create invite modal (#14151) 2021-11-18 20:19:02 +02:00
custom-html-set-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
custom-html-template-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
dashboard-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
dismiss-notification-modal-test.js Refine dismiss notification confirmation (#15017) 2021-11-22 09:11:24 +08:00
do-not-disturb-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
edit-notification-click-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
email-notice-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
emoji-picker-test.js FIX: Don't display duplicated emoji in picker 2022-01-11 10:37:02 +08:00
emoji-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
encoded-category-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
enforce-second-factor-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
fast-edit-test.js DEV: Revisit skipped tests (#15769) 2022-02-02 12:09:03 -05:00
flag-post-test.js DEV: avoid sending events to a destroying object and enable few skipped tests (#15030) 2021-12-01 18:21:44 +04:00
forgot-password-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
group-index-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
group-manage-categories-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
group-manage-email-settings-test.js FEATURE: Allow sending group SMTP emails with from alias (#15687) 2022-02-07 13:52:01 +10:00
group-manage-interaction-test.js DEV: Avoid using globals (#14909) 2021-11-13 13:10:13 +01:00
group-manage-logs-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
group-manage-membership-test.js FEATURE: Experimental support for group membership via google auth (#14835) 2021-12-09 12:30:27 +00:00
group-manage-profile-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
group-manage-tags-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
group-requests-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
group-test.js DEV: Avoid using globals (#14909) 2021-11-13 13:10:13 +01:00
groups-index-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
groups-new-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
hamburger-menu-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
hashtags-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
invite-accept-test.js DEV: Bump eslint-config-discourse (#14868) 2021-11-10 09:31:41 +10:00
invite-show-user-fields-test.js DEV: Sync up more Ember CLI features (#11790) 2021-01-21 15:55:39 -05:00
jump-to-test.js DEV: Revisit skipped tests (#15769) 2022-02-02 12:09:03 -05:00
keyboard-shortcuts-test.js DEV: Improve stability of Tests (#15591) 2022-01-17 08:57:05 +01:00
login-redirect-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
login-required-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
login-with-email-and-hide-email-address-taken-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
login-with-email-and-no-social-logins-test.js UX: add link for email login below username, remove button (#12118) 2021-02-24 16:30:08 -05:00
login-with-email-disabled-test.js UX: add link for email login below username, remove button (#12118) 2021-02-24 16:30:08 -05:00
login-with-email-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
mobile-discovery-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
mobile-pan-test.js DEV: Bump eslint-config-discourse (#14868) 2021-11-10 09:31:41 +10:00
mobile-sign-in-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
mobile-users-test.js FEATURE: Add user custom fields to user directory (#13238) 2021-06-07 12:34:01 -05:00
modal-test.js DEV: Revisit skipped tests (#15769) 2022-02-02 12:09:03 -05:00
new-message-test.js FEATURE: allow sending message via a link to multiple users (#15412) 2021-12-28 06:35:22 +05:30
new-topic-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
notifications-filter-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
notifications-test.js DEV: Avoid using globals (#14909) 2021-11-13 13:10:13 +01:00
opengraph-tag-updater-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
page-publishing-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
password-reset-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
pending-posts-test.js DEV: Fix pending posts page, make tests work in legacy env (#15132) 2021-11-30 13:01:39 +01:00
personal-message-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
plugin-keyboard-shortcut-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
plugin-outlet-connector-class-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
plugin-outlet-decorator-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
plugin-outlet-multi-template-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
plugin-outlet-single-template-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
post-admin-menu-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
post-history-test.js DEV: Revisit skipped tests (#15769) 2022-02-02 12:09:03 -05:00
preferences-test.js DEV: Use a real image to fix a net::err in tests (#15597) 2022-01-17 08:57:52 +01:00
raw-plugin-outlet-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
redirect-to-top-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
reports-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
review-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
search-full-test.js DEV: Revisit skipped tests (#15769) 2022-02-02 12:09:03 -05:00
search-mobile-test.js DEV: fix tests (#15587) 2022-01-14 16:59:26 +01:00
search-test.js FEATURE: show recent searches in quick search panel (#15024) 2021-11-25 15:44:15 -05:00
share-topic-test.js DEV: Quick fix to flaky test (#15644) 2022-01-19 11:23:35 +08:00
shared-drafts-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
sign-in-test.js DEV: Revisit skipped tests (#15769) 2022-02-02 12:09:03 -05:00
static-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
tag-groups-test.js DEV: select-kit third major update with focus on accessibility (#13303) 2021-08-23 10:44:19 +02:00
tags-intersection-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
tags-test.js FIX: uses new format for search tag endpoint to prevent issues (#15328) 2021-12-16 11:57:47 +01:00
topic-admin-menu-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
topic-anonymous-test.js DEV: Clean up QUnit tests (#13328) 2021-06-08 17:54:12 +02:00
topic-bulk-actions-test.js FEATURE: Select range in topic list with Shift + click (#15682) 2022-02-04 15:20:38 +01:00
topic-discovery-test.js DEV: Add integration test for refreshing discovery-topics views 2022-01-12 12:18:37 +00:00
topic-edit-timer-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
topic-footer-button-api-mobile-test.js DEV: adds a new topic footer dropdown api (#14747) 2021-11-12 10:21:34 +01:00
topic-footer-button-api-test.js DEV: Avoid using globals (#14909) 2021-11-13 13:10:13 +01:00
topic-footer-dropdown-api-test.js DEV: adds a new topic footer dropdown api (#14747) 2021-11-12 10:21:34 +01:00
topic-list-tracker-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
topic-move-posts-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
topic-notifications-button-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
topic-quote-button-test.js DEV: Revisit skipped tests (#15769) 2022-02-02 12:09:03 -05:00
topic-set-slow-mode-test.js DEV: select-kit third major update with focus on accessibility (#13303) 2021-08-23 10:44:19 +02:00
topic-slow-mode-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
topic-test.js DEV: Clean up skipped tests (#15747) 2022-01-31 15:31:13 -05:00
topic-timeline-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
unknown-test.js DEV: Revisit skipped tests (#15769) 2022-02-02 12:09:03 -05:00
user-activity-all-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
user-activity-drafts-test.js FEATURE: improve blank page syndrome on the user activity pages (#14311) 2021-09-16 21:35:34 +04:00
user-activity-likes-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
user-activity-read-test.js FIX: This was causing a flaky test in Ember CLI 2022-01-26 14:53:25 -05:00
user-activity-replies-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
user-activity-topic-test.js Segment Ember CLI tests 2021-11-26 12:14:30 -05:00
user-anonymous-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
user-bookmarks-test.js FEATURE: improve "blank page syndrome" on the user bookmarks page 2021-08-20 00:08:59 +04:00
user-card-test.js DEV: Fix a test leak (#15135) 2021-11-30 13:45:26 +11:00
user-drafts-stream-test.js DEV: Update emojis constants (#15506) 2022-01-10 14:53:52 -03:00
user-preferences-interface-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
user-preferences-notifications-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
user-preferences-profile-test.js FEATURE: save local date to calendar (#14486) 2021-10-06 14:11:52 +11:00
user-private-messages-test.js DEV: Use @bind instead of repeated .bind(this) (#14931) 2021-11-15 10:07:53 +01:00
user-test.js FIX: User option fields definition was being mutated on save (#15837) 2022-02-07 16:58:27 +10:00
users-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00