This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.
osr-discourse-src/app/assets/javascripts/discourse/tests/unit/models
Martin Brennan 357186ab7e
FIX: User option fields definition was being mutated on save (#15837)
In the commit d8bf2810ff we hoisted
the userOptionFields array to a module-level variable, but kept
the code inside save() the same. This causes an issue where if
save() is called twice on the same user with some array of user
option fields, the userOptionFields array is mutated, which means
the second save is likely not saving the fields intended.

This commit fixes the issue by not mutating the array. We cannot
change them into consts though, because we have an API to add more
items to the array.
2022-02-07 16:58:27 +10:00
..
badge-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
category-test.js FIX: ensures minimum tags logic is correct and shared (#14723) 2021-11-12 14:04:48 +01:00
composer-test.js DEV: Bump eslint-config-discourse (#14868) 2021-11-10 09:31:41 +10:00
email-log-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
group-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
invite-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
nav-item-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
pending-post-test.js FEATURE: Display pending posts on user’s page 2021-11-29 10:26:33 +01:00
post-stream-test.js DEV: Fix qunit/assert-args (#14932) 2021-11-15 04:30:42 +01:00
post-test.js DEV: Bump eslint-config-discourse (#14868) 2021-11-10 09:31:41 +10:00
private-message-topic-tracking-state-test.js DEV: Allow onStateChange callbacks for PM topic tracking state. (#14479) 2021-10-05 14:12:01 +08:00
report-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
rest-model-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
result-set-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
session-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
site-test.js FIX: Include all categories in sortedCategories (#14979) 2021-11-17 00:12:04 +01:00
staff-action-log-test.js DEV: Sort imports alphabetically (#11382) 2020-12-01 15:31:26 -03:00
theme-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
topic-details-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
topic-test.js DEV: Fix a computed override in tests (#15596) 2022-01-17 08:58:37 +01:00
topic-tracking-state-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
user-action-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
user-badge-test.js DEV: Fix a test leak (#15135) 2021-11-30 13:45:26 +11:00
user-drafts-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
user-stream-test.js DEV: Replace equal() with strictEqual() (#14827) 2021-11-08 10:26:28 +01:00
user-test.js FIX: User option fields definition was being mutated on save (#15837) 2022-02-07 16:58:27 +10:00