This repository has been archived on 2023-03-18. You can view files and clone it, but cannot push or open issues or pull requests.
osr-discourse-src/spec
Dan Singerman dbf2f4efec Fix bug when sso_overrides_avatar is true but no avatar_url is passed
If a user has a current avatar, and sso_overrides_avatar is true, but no avatar_url is
passed in the sso attributes, the current code errors, as it tries to parse a nil
as a URL. It seems to me valid that a third party system may not pass an avatar_url in
some cases (e.g. avatars may not be mandatory, so not all users may have them)

This might warrant a discussion about what should happen in this case; maybe the current
avatar in discourse should be removed? This branch merely stops the login process erroring.
2015-01-28 16:01:39 +00:00
..
components FIX: on topic page, don't try to render post counts for a deleted user 2015-01-15 15:39:34 -05:00
controllers FEATURE: Log username changes by staff 2015-01-17 02:26:12 -08:00
fabricators Fix bug when sso_overrides_avatar is true but no avatar_url is passed 2015-01-28 16:01:39 +00:00
fixtures FIX: auto response email replies should not be accepted 2014-12-04 22:39:13 +05:30
helpers Update rspec syntax to v3 2015-01-05 11:59:30 -03:00
integration update specs to remove deprecation warnings 2014-11-07 06:05:44 -08:00
integrity FIX: double periods. How did that work?? 2014-02-14 17:57:38 -05:00
jobs FIX: old csv's were not getting deleted 2015-01-15 00:00:39 +05:30
mailers remove enable_email_names setting 2015-01-13 13:35:40 +05:30
models Fix bug when sso_overrides_avatar is true but no avatar_url is passed 2015-01-28 16:01:39 +00:00
phantom_js Rename "User Expansion" to the much clearer "User Card" 2014-10-20 12:11:59 -04:00
serializers Update rspec syntax to v3 2015-01-05 11:59:30 -03:00
services FIX: Don't raise an error when trying to log nothing 2014-12-15 14:14:12 -05:00
support models with rspec3 syntax 2015-01-05 13:04:23 -03:00
views/omniauth_callbacks Update rspec syntax to v3 2015-01-05 11:59:30 -03:00
spec_helper.rb Ruby 2.2 fixes 2014-12-29 13:31:15 +11:00