If a user has a current avatar, and sso_overrides_avatar is true, but no avatar_url is passed in the sso attributes, the current code errors, as it tries to parse a nil as a URL. It seems to me valid that a third party system may not pass an avatar_url in some cases (e.g. avatars may not be mandatory, so not all users may have them) This might warrant a discussion about what should happen in this case; maybe the current avatar in discourse should be removed? This branch merely stops the login process erroring. |
||
|---|---|---|
| .. | ||
| api_key_fabricator.rb | ||
| badge_fabricator.rb | ||
| category_fabricator.rb | ||
| color_scheme_color_fabricator.rb | ||
| color_scheme_fabricator.rb | ||
| email_log_fabricator.rb | ||
| flag_fabricator.rb | ||
| group_fabricator.rb | ||
| incoming_link_fabricator.rb | ||
| invite_fabricator.rb | ||
| like_fabricator.rb | ||
| notification_fabricator.rb | ||
| optimized_image_fabricator.rb | ||
| permalink_fabricator.rb | ||
| post_detail_fabricator.rb | ||
| post_fabricator.rb | ||
| post_revision_fabricator.rb | ||
| screened_email_fabricator.rb | ||
| screened_ip_address_fabricator.rb | ||
| screened_url_fabricator.rb | ||
| single_sign_on_record_fabrictor.rb | ||
| site_text_fabricator.rb | ||
| topic_fabricator.rb | ||
| upload_fabricator.rb | ||
| user_action_fabricator.rb | ||
| user_fabricator.rb | ||
| user_field_fabricator.rb | ||
| user_profile_fabricator.rb | ||