Compare commits

...

29 Commits

Author SHA1 Message Date
argenis de la rosa a965b129f8 chore: bump version to 0.5.8
Release trigger bump after recent fixes.
2026-03-22 16:29:45 -04:00
Argenis c135de41b7 feat(matrix): add allowed_rooms config for room-level gating (#4230) (#4260)
Add an `allowed_rooms` field to MatrixConfig that controls which rooms
the bot will accept messages from and join invites for. When the list
is non-empty, messages from unlisted rooms are silently dropped and
room invites are auto-rejected. When empty (default), all rooms are
allowed, preserving backward compatibility.

- Config: add `allowed_rooms: Vec<String>` with `#[serde(default)]`
- Message handler: replace disabled room_id filter with allowlist check
- Invite handler: auto-accept allowed rooms, auto-reject others
- Support both canonical room IDs and aliases, case-insensitive
2026-03-22 14:41:43 -04:00
Argenis 2d2c2ac9e6 feat(telegram): support forwarded messages with attribution (#4265)
Parse forward_from, forward_from_chat, and forward_sender_name fields
from Telegram message updates. Prepend forwarding attribution to message
content so the LLM has context about the original sender.

Closes #4118
2026-03-22 14:36:31 -04:00
Argenis 5e774bbd70 feat(multimodal): route image messages to dedicated vision provider (#4264)
When vision_provider is configured in [multimodal] config, messages
containing [IMAGE:] markers are automatically routed to the specified
vision-capable provider instead of failing on the default text provider.

Closes #4119
2026-03-22 14:36:29 -04:00
Argenis 33015067eb feat(tts): add local Piper TTS provider (#4263)
Add a piper TTS provider that communicates with a local Piper/Coqui TTS
server via an OpenAI-compatible HTTP endpoint. This enables fully offline
voice pipelines: Whisper (STT) → LLM → Piper (TTS).

Closes #4116
2026-03-22 14:36:26 -04:00
Argenis 6b10c0b891 fix(approval): merge default auto_approve entries with user config (#4262)
When a user provides a custom `auto_approve` list in their TOML
config (e.g. to add an MCP tool), serde replaces the built-in
defaults instead of merging. This causes default safe tools like
`weather`, `calculator`, and `file_read` to lose auto-approve
status and get silently denied in non-interactive channel runs.

Add `ensure_default_auto_approve()` which merges built-in entries
into the user's list after deserialization, preserving user
additions while guaranteeing defaults are always present. Users
who want to require approval for a default tool can use
`always_ask`, which takes precedence.

Closes #4247
2026-03-22 14:28:09 -04:00
Argenis bf817e30d2 fix(provider): prevent async runtime panic during model refresh (#4261)
Wrap `fetch_live_models_for_provider` calls in
`tokio::task::spawn_blocking` so the `reqwest::blocking::Client`
is created and dropped on a dedicated thread pool instead of
inside the async Tokio context. This prevents the
"Cannot drop a runtime in a context where blocking is not allowed"
panic when running `models refresh --provider openai`.

Closes #4253
2026-03-22 14:22:47 -04:00
Alix-007 0051a0c296 fix(matrix): enforce configured room scope on inbound events (#4251)
Co-authored-by: Alix-007 <267018309+Alix-007@users.noreply.github.com>
2026-03-22 14:08:13 -04:00
Canberk Özkan d753de91f1 fix(skills): prevent panic by ensuring UTF-8 char boundary during truncation (#4252)
Fixed issue #4139.

Previously, slicing a string at exactly 64 bytes could land in the middle of a multi-byte UTF-8 character (e.g., Chinese characters), causing a runtime panic.

Changes:
- Replaced direct byte slicing with a safe boundary lookup using .char_indices().
- Ensures truncation always occurs at a valid character boundary at or before the 64-byte limit.
- Maintained existing hyphen-trimming logic.

Co-authored-by: loriscience <loriscience@gmail.com>
2026-03-22 14:08:01 -04:00
Argenis f6b2f61a01 fix(matrix): disable automatic key backup when no backup key is configured (#4259)
Explicitly call `client.encryption().backups().disable()` when backups
are not enabled, preventing the matrix_sdk_crypto crate from attempting
room key backups on every sync cycle and spamming the logs with
"Trying to backup room keys but no backup key was found" warnings.

Closes #4227
2026-03-22 13:55:45 -04:00
Argenis 70e7910cb9 fix(web): remove unused import blocking release pipeline (#4234)
fix(web): remove unused import blocking release pipeline
2026-03-22 01:35:26 -04:00
argenis de la rosa a8868768e8 fix(web): remove unused ChevronsUpDown import blocking release pipeline
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-22 01:20:51 -04:00
Argenis 67293c50df chore: bump version to 0.5.7 (#4232)
chore: bump version to 0.5.7
2026-03-22 01:14:08 -04:00
argenis de la rosa 1646079d25 chore: bump version to 0.5.7
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-22 00:49:41 -04:00
Argenis 25b639435f fix: merge voice-wake feature (PR #4162) with conflict resolution (#4225)
* feat(channels): add voice wake word detection channel

Add VoiceWakeChannel behind the `voice-wake` feature flag that:
- Captures audio from the default microphone via cpal
- Uses energy-based VAD to detect speech activity
- Transcribes speech via the existing transcription API (Whisper)
- Checks for a configurable wake word in the transcription
- On detection, captures the following utterance and dispatches it
  as a ChannelMessage

State machine: Listening -> Triggered -> Capturing -> Processing -> Listening

Config keys (under [channels_config.voice_wake]):
- wake_word (default: "hey zeroclaw")
- silence_timeout_ms (default: 2000)
- energy_threshold (default: 0.01)
- max_capture_secs (default: 30)

Includes tests for config parsing, state machine, RMS energy
computation, and WAV encoding.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(config): fix pre-existing test compilation errors in schema.rs

- Remove #[cfg(unix)] gate on `use tempfile::TempDir` import since
  TempDir is used unconditionally in bootstrap file tests
- Add explicit type annotations on tokio::fs::* calls to resolve
  type inference failures (create_dir_all, write, read_to_string)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(channels): exclude voice-wake from all-features CI check

Add a `ci-all` meta-feature in Cargo.toml that includes every feature
except `voice-wake`, which requires `libasound2-dev` (ALSA) not present
on CI runners. Update the check-all-features CI job to use
`--features ci-all` instead of `--all-features`.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Giulio V <vannini.gv@gmail.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-22 00:49:12 -04:00
Argenis 77779844e5 feat(memory): layered architecture upgrade + remove mem0 backend (#4226)
feat(memory): layered architecture upgrade + remove mem0 backend
2026-03-22 00:47:42 -04:00
Argenis f658d5806a fix: honor [autonomy] config section in daemon/channel mode
Fixes #4171
2026-03-22 00:47:32 -04:00
Argenis 7134fe0824 Merge pull request #4223 from zeroclaw-labs/fix/4214-heartbeat-utf8-safety
fix(heartbeat): prevent UTF-8 panic, add memory bounds and path validation
2026-03-22 00:41:47 -04:00
Argenis 263802b3df Merge pull request #4224 from zeroclaw-labs/fix/4215-thai-i18n-cleanup
fix(i18n): remove extra keys and translate notion in th.toml
2026-03-22 00:41:21 -04:00
Argenis 3c25fddb2a fix: merge Gmail Pub/Sub push PR #4164 (already integrated via #4200) (#4222)
* feat(channels): add Gmail Pub/Sub push notifications for real-time email

Add GmailPushChannel that replaces IMAP polling with Google's Pub/Sub
push notification system for real-time email-driven automation.

- New channel at src/channels/gmail_push.rs implementing the Channel trait
- Registers Gmail watch subscription (POST /gmail/v1/users/me/watch)
  with automatic renewal before the 7-day expiry
- Handles incoming Pub/Sub notifications at POST /webhook/gmail
- Fetches new messages via Gmail History API (startHistoryId-based)
- Dispatches email messages to the agent with full metadata
- Sends replies via Gmail messages.send API
- Config: gmail_push.enabled, topic, label_filter, oauth_token,
  allowed_senders, webhook_url
- OAuth token encrypted at rest via existing secret store
- Webhook endpoint added to gateway router
- 30+ unit tests covering notification parsing, header extraction,
  body decoding, sender allowlist, and config serialization

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(config): fix pre-existing test compilation errors in schema.rs

- Remove #[cfg(unix)] gate on `use tempfile::TempDir` import since
  TempDir is used unconditionally in bootstrap file tests
- Add explicit type annotations on tokio::fs::* calls to resolve
  type inference failures (create_dir_all, write, read_to_string)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(channels): fix extract_body_text_plain test

Gmail API sends base64url without padding. The decode_body function
converted URL-safe chars back to standard base64 but did not restore
the padding, causing STANDARD decoder to fail and falling back to
snippet. Add padding restoration before decoding.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Giulio V <vannini.gv@gmail.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-22 00:40:42 -04:00
Argenis a6a46bdd25 fix: add weather tool to default auto_approve list
Fixes #4170
2026-03-22 00:21:33 -04:00
Argenis 235d4d2f1c fix: replace ILIKE substring matching with full-text search in postgres memory recall()
Fixes #4204
2026-03-22 00:20:11 -04:00
argenis de la rosa bd1e8c8e1a merge: resolve conflicts with master + remove memory-mem0 from ci-all
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-22 00:18:09 -04:00
Argenis f81807bff6 fix: serialize env-dependent codex tests to prevent race (#4210) (#4218)
Add a process-scoped Mutex that all env-var-mutating tests in
openai_codex::tests must hold.  This prevents std::env::set_var /
remove_var calls from racing when Rust's test harness runs them on
parallel threads.

Affected tests:
- resolve_responses_url_prefers_explicit_endpoint_env
- resolve_responses_url_uses_provider_api_url_override
- resolve_reasoning_effort_prefers_configured_override
- resolve_reasoning_effort_uses_legacy_env_when_unconfigured
2026-03-22 00:14:01 -04:00
argenis de la rosa bb7006313c feat(memory): layered architecture upgrade + remove mem0 backend
Implement 6-phase memory system improvement:
- Multi-stage retrieval pipeline (cache → FTS → vector)
- Namespace isolation with strict filtering
- Importance scoring (category + keyword heuristics)
- Conflict resolution via Jaccard similarity + superseded_by
- Audit trail decorator (AuditedMemory<M>)
- Policy engine (quotas, read-only namespaces, retention rules)
- Deterministic sort tiebreaker on equal scores

Remove mem0 (OpenMemory) backend — all capabilities now covered
natively with better performance (local SQLite vs external REST API).

46 battle tests + 262 existing tests pass. Backward-compatible:
existing databases auto-migrate, existing configs work unchanged.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-22 00:09:43 -04:00
Argenis 9a49626376 fix: use POSIX-compatible sh -c instead of dash-specific -lc (#4209) (#4217)
* fix: build web dashboard during install.sh (#4207)

* fix: use POSIX-compatible sh -c instead of dash-specific -lc in cron scheduler (#4209)
2026-03-22 00:07:37 -04:00
Argenis 8b978a721f fix: build web dashboard during install.sh (#4207) (#4216) 2026-03-22 00:02:54 -04:00
argenis de la rosa 75b4c1d4a4 fix(heartbeat): prevent UTF-8 panic, add memory bounds and path validation in session context
- Use char_indices for safe UTF-8 truncation instead of byte slicing
- Replace unbounded Vec with VecDeque rolling window in load_jsonl_messages
- Add path separator validation for channel/to to prevent directory traversal
2026-03-22 00:01:44 -04:00
Martin Minkus cb0779d761 feat(heartbeat): add load_session_context to inject conversation history
When `load_session_context = true` in `[heartbeat]`, the daemon loads the
last 20 messages from the target user's JSONL session file and prepends them
to the heartbeat task prompt before calling the LLM.

This gives the companion context — who the user is, what was last discussed —
so outreach messages feel like a natural continuation rather than a blank-slate
ping. Defaults to `false` (opt-in, no change to existing behaviour).

Key behaviours:
- Session context is re-read on every heartbeat tick (not cached at startup)
- Skips context injection if only assistant messages are present (prevents
  heartbeat outputs feeding back in a loop)
- Scans sessions directory for matching JSONL files using flexible filename
  matching: {channel}_{to}.jsonl, {channel}_*_{to}.jsonl, or
  {channel}_{to}_*.jsonl — handles varying session key formats
- Injects file mtime as "last message ~Xh ago" so the LLM knows how long
  the user has been silent

Config example:
  [heartbeat]
  enabled = true
  interval_minutes = 120
  load_session_context = true
  target = "telegram"
  to = "your_username"

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-22 02:44:19 +00:00
49 changed files with 4009 additions and 1553 deletions
-97
View File
@@ -1,97 +0,0 @@
# Mem0 Integration: Dual-Scope Recall + Per-Turn Memory
## Context
Mem0 auto-save works but the integration is missing key features from mem0 best practices: per-turn recall, multi-level scoping, and proper context injection. This causes the bot to "forget" on follow-up turns and not differentiate users.
## What's Missing (vs mem0 docs)
1. **Per-turn recall** — only first turn gets memory context, follow-ups get nothing
2. **Dual-scope** — no sender vs group distinction. All memories use single hardcoded `user_id`
3. **System prompt injection** — memory prepended to user message (pollutes session history)
4. **`agent_id` scoping** — mem0 supports agent-level patterns, not used
## Changes
### 1. `src/memory/mem0.rs` — Use session_id for multi-level scoping
Map zeroclaw's `session_id` param to mem0's `user_id`. This enables per-user and per-group memory namespaces without changing the `Memory` trait.
```rust
// Add helper:
fn effective_user_id(&self, session_id: Option<&str>) -> &str {
session_id.filter(|s| !s.is_empty()).unwrap_or(&self.user_id)
}
// In store(): use effective_user_id(session_id) as mem0 user_id
// In recall(): use effective_user_id(session_id) as mem0 user_id
// In list(): use effective_user_id(session_id) as mem0 user_id
```
### 2. `src/channels/mod.rs` ~line 2229 — Per-turn dual-scope recall
Remove `if !had_prior_history` gate. Always recall from both sender scope and group scope (for group chats).
```rust
// Detect group chat
let is_group = msg.reply_target.contains("@g.us")
|| msg.reply_target.starts_with("group:");
// Sender-scope recall (always)
let sender_context = build_memory_context(
ctx.memory.as_ref(), &msg.content, ctx.min_relevance_score,
Some(&msg.sender),
).await;
// Group-scope recall (groups only)
let group_context = if is_group {
build_memory_context(
ctx.memory.as_ref(), &msg.content, ctx.min_relevance_score,
Some(&history_key),
).await
} else {
String::new()
};
// Merge (deduplicate by checking substring overlap)
let memory_context = merge_memory_contexts(&sender_context, &group_context);
```
### 3. `src/channels/mod.rs` ~line 2244 — Inject into system prompt
Move memory context from user message to system prompt. Re-fetched each turn, doesn't pollute session.
```rust
let mut system_prompt = build_channel_system_prompt(...);
if !memory_context.is_empty() {
system_prompt.push_str(&format!("\n\n{memory_context}"));
}
let mut history = vec![ChatMessage::system(system_prompt)];
```
### 4. `src/channels/mod.rs` — Dual-scope auto-save
Find existing auto-save call. For group messages, store twice:
- `store(key, content, category, Some(&msg.sender))` — personal facts
- `store(key, content, category, Some(&history_key))` — group context
Both async, non-blocking. DMs only store to sender scope.
### 5. `src/memory/mem0.rs` — Add `agent_id` support (optional)
Pass `self.app_name` as `agent_id` param to mem0 API for agent behavior tracking.
## Files to Modify
1. `src/memory/mem0.rs` — session_id → user_id mapping
2. `src/channels/mod.rs` — per-turn recall, dual-scope, system prompt injection, dual-scope save
## Verification
1. `cargo check --features whatsapp-web,memory-mem0`
2. `cargo test --features whatsapp-web,memory-mem0`
3. Deploy to Synology
4. Test DM: "我鍾意食壽司" → next turn "我鍾意食咩" → should recall
5. Test group: Joe says "我鍾意食壽司" → someone else asks "Joe 鍾意食咩" → should recall from group scope
6. Check mem0 server logs: GET with `user_id=sender` AND `user_id=group_key`
7. Check mem0 server logs: POST with both user_ids for group messages
Generated
+1 -1
View File
@@ -9530,7 +9530,7 @@ dependencies = [
[[package]]
name = "zeroclawlabs"
version = "0.5.6"
version = "0.5.8"
dependencies = [
"aardvark-sys",
"anyhow",
+1 -4
View File
@@ -4,7 +4,7 @@ resolver = "2"
[package]
name = "zeroclawlabs"
version = "0.5.6"
version = "0.5.8"
edition = "2021"
authors = ["theonlyhennygod"]
license = "MIT OR Apache-2.0"
@@ -231,8 +231,6 @@ channel-matrix = ["dep:matrix-sdk"]
channel-lark = ["dep:prost"]
channel-feishu = ["channel-lark"] # Alias for Feishu users (Lark and Feishu are the same platform)
memory-postgres = ["dep:postgres"]
# memory-mem0 = Mem0 (OpenMemory) memory backend via REST API
memory-mem0 = []
observability-prometheus = ["dep:prometheus"]
observability-otel = ["dep:opentelemetry", "dep:opentelemetry_sdk", "dep:opentelemetry-otlp"]
peripheral-rpi = ["rppal"]
@@ -267,7 +265,6 @@ ci-all = [
"channel-matrix",
"channel-lark",
"memory-postgres",
"memory-mem0",
"observability-prometheus",
"observability-otel",
"peripheral-rpi",
-80
View File
@@ -1,80 +0,0 @@
#!/bin/bash
# Start mem0 + reranker GPU container for ZeroClaw memory backend.
#
# Required env vars:
# MEM0_LLM_API_KEY or ZAI_API_KEY — API key for the LLM used in fact extraction
#
# Optional env vars (with defaults):
# MEM0_LLM_PROVIDER — mem0 LLM provider (default: "openai" i.e. OpenAI-compatible)
# MEM0_LLM_MODEL — LLM model for fact extraction (default: "glm-5-turbo")
# MEM0_LLM_BASE_URL — LLM API base URL (default: "https://api.z.ai/api/coding/paas/v4")
# MEM0_EMBEDDER_MODEL — embedding model (default: "BAAI/bge-m3")
# MEM0_EMBEDDER_DIMS — embedding dimensions (default: "1024")
# MEM0_EMBEDDER_DEVICE — "cuda", "cpu", or "auto" (default: "cuda")
# MEM0_VECTOR_COLLECTION — Qdrant collection name (default: "zeroclaw_mem0")
# RERANKER_MODEL — reranker model (default: "BAAI/bge-reranker-v2-m3")
# RERANKER_DEVICE — "cuda" or "cpu" (default: "cuda")
# MEM0_PORT — mem0 server port (default: 8765)
# RERANKER_PORT — reranker server port (default: 8678)
# CONTAINER_IMAGE — base container image (default: docker.io/kyuz0/amd-strix-halo-comfyui:latest)
# CONTAINER_NAME — container name (default: mem0-gpu)
# DATA_DIR — host path for Qdrant data (default: ~/mem0-data)
# SCRIPT_DIR — host path for server scripts (default: directory of this script)
set -e
# Resolve script directory for mounting server scripts
SCRIPT_DIR="${SCRIPT_DIR:-$(cd "$(dirname "$0")" && pwd)}"
# API key — accept either name
export MEM0_LLM_API_KEY="${MEM0_LLM_API_KEY:-${ZAI_API_KEY:?MEM0_LLM_API_KEY or ZAI_API_KEY must be set}}"
# Defaults
MEM0_LLM_MODEL="${MEM0_LLM_MODEL:-glm-5-turbo}"
MEM0_LLM_BASE_URL="${MEM0_LLM_BASE_URL:-https://api.z.ai/api/coding/paas/v4}"
MEM0_PORT="${MEM0_PORT:-8765}"
RERANKER_PORT="${RERANKER_PORT:-8678}"
CONTAINER_IMAGE="${CONTAINER_IMAGE:-docker.io/kyuz0/amd-strix-halo-comfyui:latest}"
CONTAINER_NAME="${CONTAINER_NAME:-mem0-gpu}"
DATA_DIR="${DATA_DIR:-$HOME/mem0-data}"
# Stop existing CPU services (if any)
kill -9 $(pgrep -f "mem0-server.py") 2>/dev/null || true
kill -9 $(pgrep -f "reranker-server.py") 2>/dev/null || true
# Stop existing container
podman stop "$CONTAINER_NAME" 2>/dev/null || true
podman rm "$CONTAINER_NAME" 2>/dev/null || true
podman run -d --name "$CONTAINER_NAME" \
--device /dev/dri --device /dev/kfd \
--group-add video --group-add render \
--restart unless-stopped \
-p "$MEM0_PORT:$MEM0_PORT" -p "$RERANKER_PORT:$RERANKER_PORT" \
-v "$DATA_DIR":/root/mem0-data:Z \
-v "$SCRIPT_DIR/mem0-server.py":/app/mem0-server.py:ro,Z \
-v "$SCRIPT_DIR/reranker-server.py":/app/reranker-server.py:ro,Z \
-v "$HOME/.cache/huggingface":/root/.cache/huggingface:Z \
-e MEM0_LLM_API_KEY="$MEM0_LLM_API_KEY" \
-e ZAI_API_KEY="$MEM0_LLM_API_KEY" \
-e MEM0_LLM_MODEL="$MEM0_LLM_MODEL" \
-e MEM0_LLM_BASE_URL="$MEM0_LLM_BASE_URL" \
${MEM0_LLM_PROVIDER:+-e MEM0_LLM_PROVIDER="$MEM0_LLM_PROVIDER"} \
${MEM0_EMBEDDER_MODEL:+-e MEM0_EMBEDDER_MODEL="$MEM0_EMBEDDER_MODEL"} \
${MEM0_EMBEDDER_DIMS:+-e MEM0_EMBEDDER_DIMS="$MEM0_EMBEDDER_DIMS"} \
${MEM0_EMBEDDER_DEVICE:+-e MEM0_EMBEDDER_DEVICE="$MEM0_EMBEDDER_DEVICE"} \
${MEM0_VECTOR_COLLECTION:+-e MEM0_VECTOR_COLLECTION="$MEM0_VECTOR_COLLECTION"} \
${RERANKER_MODEL:+-e RERANKER_MODEL="$RERANKER_MODEL"} \
${RERANKER_DEVICE:+-e RERANKER_DEVICE="$RERANKER_DEVICE"} \
-e RERANKER_PORT="$RERANKER_PORT" \
-e RERANKER_URL="http://127.0.0.1:$RERANKER_PORT/rerank" \
-e TORCH_ROCM_AOTRITON_ENABLE_EXPERIMENTAL=1 \
-e HOME=/root \
"$CONTAINER_IMAGE" \
bash -c "pip install -q FlagEmbedding mem0ai flask httpx qdrant-client 2>&1 | tail -3; echo '=== Starting reranker (GPU) on :$RERANKER_PORT ==='; python3 /app/reranker-server.py & sleep 3; echo '=== Starting mem0 (GPU) on :$MEM0_PORT ==='; exec python3 /app/mem0-server.py"
echo "Container started, waiting for init..."
sleep 15
echo "=== Container logs ==="
podman logs "$CONTAINER_NAME" 2>&1 | tail -25
echo "=== Port check ==="
ss -tlnp | grep "$MEM0_PORT\|$RERANKER_PORT" || echo "Ports not yet ready, check: podman logs $CONTAINER_NAME"
-288
View File
@@ -1,288 +0,0 @@
"""Minimal OpenMemory-compatible REST server wrapping mem0 Python SDK."""
import asyncio
import json, os, uuid, httpx
from datetime import datetime, timezone
from fastapi import FastAPI, Query
from pydantic import BaseModel
from typing import Optional
from mem0 import Memory
app = FastAPI()
RERANKER_URL = os.environ.get("RERANKER_URL", "http://127.0.0.1:8678/rerank")
CUSTOM_EXTRACTION_PROMPT = """You are a memory extraction specialist for a Cantonese/Chinese chat assistant.
Extract ONLY important, persistent facts from the conversation. Rules:
1. Extract personal preferences, habits, relationships, names, locations
2. Extract decisions, plans, and commitments people make
3. SKIP small talk, greetings, reactions ("ok", "哈哈", "係呀")
4. SKIP temporary states ("我依家食緊飯") unless they reveal a habit
5. Keep facts in the ORIGINAL language (Cantonese/Chinese/English)
6. For each fact, note WHO it's about (use their name or identifier if known)
7. Merge/update existing facts rather than creating duplicates
Return a list of facts in JSON format: {"facts": ["fact1", "fact2", ...]}
"""
PROCEDURAL_EXTRACTION_PROMPT = """You are a procedural memory specialist for an AI assistant.
Extract HOW-TO patterns and reusable procedures from the conversation trace. Rules:
1. Identify step-by-step procedures the assistant followed to accomplish a task
2. Extract tool usage patterns: which tools were called, in what order, with what arguments
3. Capture decision points: why the assistant chose one approach over another
4. Note error-recovery patterns: what failed, how it was fixed
5. Keep the procedure generic enough to apply to similar future tasks
6. Preserve technical details (commands, file paths, API calls) that are reusable
7. SKIP greetings, small talk, and conversational filler
8. Format each procedure as: "To [goal]: [step1] -> [step2] -> ... -> [result]"
Return a list of procedures in JSON format: {"facts": ["procedure1", "procedure2", ...]}
"""
# ── Configurable via environment variables ─────────────────────────
# LLM (for fact extraction when infer=true)
MEM0_LLM_PROVIDER = os.environ.get("MEM0_LLM_PROVIDER", "openai") # "openai" (compatible), "anthropic", etc.
MEM0_LLM_MODEL = os.environ.get("MEM0_LLM_MODEL", "glm-5-turbo")
MEM0_LLM_API_KEY = os.environ.get("MEM0_LLM_API_KEY") or os.environ.get("ZAI_API_KEY", "")
MEM0_LLM_BASE_URL = os.environ.get("MEM0_LLM_BASE_URL", "https://api.z.ai/api/coding/paas/v4")
# Embedder
MEM0_EMBEDDER_PROVIDER = os.environ.get("MEM0_EMBEDDER_PROVIDER", "huggingface") # "huggingface", "openai", etc.
MEM0_EMBEDDER_MODEL = os.environ.get("MEM0_EMBEDDER_MODEL", "BAAI/bge-m3")
MEM0_EMBEDDER_DIMS = int(os.environ.get("MEM0_EMBEDDER_DIMS", "1024"))
MEM0_EMBEDDER_DEVICE = os.environ.get("MEM0_EMBEDDER_DEVICE", "cuda") # "cuda", "cpu", "auto"
# Vector store
MEM0_VECTOR_PROVIDER = os.environ.get("MEM0_VECTOR_PROVIDER", "qdrant") # "qdrant", "chroma", etc.
MEM0_VECTOR_COLLECTION = os.environ.get("MEM0_VECTOR_COLLECTION", "zeroclaw_mem0")
MEM0_VECTOR_PATH = os.environ.get("MEM0_VECTOR_PATH", os.path.expanduser("~/mem0-data/qdrant"))
config = {
"llm": {
"provider": MEM0_LLM_PROVIDER,
"config": {
"model": MEM0_LLM_MODEL,
"api_key": MEM0_LLM_API_KEY,
"openai_base_url": MEM0_LLM_BASE_URL,
},
},
"embedder": {
"provider": MEM0_EMBEDDER_PROVIDER,
"config": {
"model": MEM0_EMBEDDER_MODEL,
"embedding_dims": MEM0_EMBEDDER_DIMS,
"model_kwargs": {"device": MEM0_EMBEDDER_DEVICE},
},
},
"vector_store": {
"provider": MEM0_VECTOR_PROVIDER,
"config": {
"collection_name": MEM0_VECTOR_COLLECTION,
"embedding_model_dims": MEM0_EMBEDDER_DIMS,
"path": MEM0_VECTOR_PATH,
},
},
"custom_fact_extraction_prompt": CUSTOM_EXTRACTION_PROMPT,
}
m = Memory.from_config(config)
def rerank_results(query: str, items: list, top_k: int = 10) -> list:
"""Rerank search results using bge-reranker-v2-m3."""
if not items:
return items
documents = [item.get("memory", "") for item in items]
try:
resp = httpx.post(
RERANKER_URL,
json={"query": query, "documents": documents, "top_k": top_k},
timeout=10.0,
)
resp.raise_for_status()
ranked = resp.json().get("results", [])
return [items[r["index"]] for r in ranked]
except Exception as e:
print(f"Reranker failed, using original order: {e}")
return items
class AddMemoryRequest(BaseModel):
user_id: str
text: str
metadata: Optional[dict] = None
infer: bool = True
app: Optional[str] = None
custom_instructions: Optional[str] = None
@app.post("/api/v1/memories/")
async def add_memory(req: AddMemoryRequest):
# Use client-supplied prompt, fall back to server default, then mem0 SDK default
prompt = req.custom_instructions or CUSTOM_EXTRACTION_PROMPT
result = await asyncio.to_thread(m.add, req.text, user_id=req.user_id, metadata=req.metadata or {}, prompt=prompt)
return {"id": str(uuid.uuid4()), "status": "ok", "result": result}
class ProceduralMemoryRequest(BaseModel):
user_id: str
messages: list[dict]
metadata: Optional[dict] = None
@app.post("/api/v1/memories/procedural")
async def add_procedural_memory(req: ProceduralMemoryRequest):
"""Store a conversation trace as procedural memory.
Accepts a list of messages (role/content dicts) representing a full
conversation turn including tool calls, then uses mem0's native
procedural memory extraction to learn reusable "how to" patterns.
"""
# Build metadata with procedural type marker
meta = {"type": "procedural"}
if req.metadata:
meta.update(req.metadata)
# Use mem0's native message list support + procedural prompt
result = await asyncio.to_thread(m.add,
req.messages,
user_id=req.user_id,
metadata=meta,
prompt=PROCEDURAL_EXTRACTION_PROMPT,
)
return {"id": str(uuid.uuid4()), "status": "ok", "result": result}
def _parse_mem0_results(raw_results) -> list:
raw = raw_results.get("results", raw_results) if isinstance(raw_results, dict) else raw_results
items = []
for r in raw:
item = r if isinstance(r, dict) else {"memory": str(r)}
items.append({
"id": item.get("id", str(uuid.uuid4())),
"memory": item.get("memory", item.get("text", "")),
"created_at": item.get("created_at", datetime.now(timezone.utc).isoformat()),
"metadata_": item.get("metadata", {}),
})
return items
def _parse_iso_timestamp(value: str) -> Optional[datetime]:
"""Parse an ISO 8601 timestamp string, returning None on failure."""
try:
dt = datetime.fromisoformat(value)
if dt.tzinfo is None:
dt = dt.replace(tzinfo=timezone.utc)
return dt
except (ValueError, TypeError):
return None
def _item_created_at(item: dict) -> Optional[datetime]:
"""Extract created_at from an item as a timezone-aware datetime."""
raw = item.get("created_at")
if raw is None:
return None
if isinstance(raw, datetime):
if raw.tzinfo is None:
raw = raw.replace(tzinfo=timezone.utc)
return raw
return _parse_iso_timestamp(str(raw))
def _apply_post_filters(
items: list,
created_after: Optional[str],
created_before: Optional[str],
) -> list:
"""Filter items by created_after / created_before timestamps (post-query)."""
after_dt = _parse_iso_timestamp(created_after) if created_after else None
before_dt = _parse_iso_timestamp(created_before) if created_before else None
if after_dt is None and before_dt is None:
return items
filtered = []
for item in items:
ts = _item_created_at(item)
if ts is None:
# Keep items without a parseable timestamp
filtered.append(item)
continue
if after_dt and ts < after_dt:
continue
if before_dt and ts > before_dt:
continue
filtered.append(item)
return filtered
@app.get("/api/v1/memories/")
async def list_or_search_memories(
user_id: str = Query(...),
search_query: Optional[str] = Query(None),
size: int = Query(10),
rerank: bool = Query(True),
created_after: Optional[str] = Query(None),
created_before: Optional[str] = Query(None),
metadata_filter: Optional[str] = Query(None),
):
# Build mem0 SDK filters dict from metadata_filter JSON param
sdk_filters = None
if metadata_filter:
try:
sdk_filters = json.loads(metadata_filter)
except json.JSONDecodeError:
sdk_filters = None
if search_query:
# Fetch more results than needed so reranker has candidates to work with
fetch_size = min(size * 3, 50)
results = await asyncio.to_thread(m.search,
search_query,
user_id=user_id,
limit=fetch_size,
filters=sdk_filters,
)
items = _parse_mem0_results(results)
items = _apply_post_filters(items, created_after, created_before)
if rerank and items:
items = rerank_results(search_query, items, top_k=size)
else:
items = items[:size]
return {"items": items, "total": len(items)}
else:
results = await asyncio.to_thread(m.get_all,user_id=user_id, filters=sdk_filters)
items = _parse_mem0_results(results)
items = _apply_post_filters(items, created_after, created_before)
return {"items": items, "total": len(items)}
@app.delete("/api/v1/memories/{memory_id}")
async def delete_memory(memory_id: str):
try:
await asyncio.to_thread(m.delete, memory_id)
except Exception:
pass
return {"status": "ok"}
@app.get("/api/v1/memories/{memory_id}/history")
async def get_memory_history(memory_id: str):
"""Return the edit history of a specific memory."""
try:
history = await asyncio.to_thread(m.history, memory_id)
# Normalize to list of dicts
entries = []
raw = history if isinstance(history, list) else history.get("results", history) if isinstance(history, dict) else [history]
for h in raw:
entry = h if isinstance(h, dict) else {"event": str(h)}
entries.append(entry)
return {"memory_id": memory_id, "history": entries}
except Exception as e:
return {"memory_id": memory_id, "history": [], "error": str(e)}
if __name__ == "__main__":
import uvicorn
uvicorn.run(app, host="0.0.0.0", port=8765)
-50
View File
@@ -1,50 +0,0 @@
from flask import Flask, request, jsonify
from FlagEmbedding import FlagReranker
import os, torch
app = Flask(__name__)
reranker = None
# ── Configurable via environment variables ─────────────────────────
RERANKER_MODEL = os.environ.get("RERANKER_MODEL", "BAAI/bge-reranker-v2-m3")
RERANKER_DEVICE = os.environ.get("RERANKER_DEVICE", "cuda" if torch.cuda.is_available() else "cpu")
RERANKER_PORT = int(os.environ.get("RERANKER_PORT", "8678"))
def get_reranker():
global reranker
if reranker is None:
reranker = FlagReranker(RERANKER_MODEL, use_fp16=True, device=RERANKER_DEVICE)
return reranker
@app.route('/rerank', methods=['POST'])
def rerank():
data = request.json
query = data.get('query', '')
documents = data.get('documents', [])
top_k = data.get('top_k', len(documents))
if not query or not documents:
return jsonify({'error': 'query and documents required'}), 400
pairs = [[query, doc] for doc in documents]
scores = get_reranker().compute_score(pairs)
if isinstance(scores, float):
scores = [scores]
results = sorted(
[{'index': i, 'document': doc, 'score': score}
for i, (doc, score) in enumerate(zip(documents, scores))],
key=lambda x: x['score'], reverse=True
)[:top_k]
return jsonify({'results': results})
@app.route('/health', methods=['GET'])
def health():
return jsonify({'status': 'ok', 'model': RERANKER_MODEL, 'device': RERANKER_DEVICE})
if __name__ == '__main__':
print(f'Loading reranker model ({RERANKER_MODEL}) on {RERANKER_DEVICE}...')
get_reranker()
print(f'Reranker server ready on :{RERANKER_PORT}')
app.run(host='0.0.0.0', port=RERANKER_PORT)
+2 -2
View File
@@ -1,6 +1,6 @@
pkgbase = zeroclaw
pkgdesc = Zero overhead. Zero compromise. 100% Rust. The fastest, smallest AI assistant.
pkgver = 0.5.6
pkgver = 0.5.8
pkgrel = 1
url = https://github.com/zeroclaw-labs/zeroclaw
arch = x86_64
@@ -10,7 +10,7 @@ pkgbase = zeroclaw
makedepends = git
depends = gcc-libs
depends = openssl
source = zeroclaw-0.5.6.tar.gz::https://github.com/zeroclaw-labs/zeroclaw/archive/refs/tags/v0.5.6.tar.gz
source = zeroclaw-0.5.8.tar.gz::https://github.com/zeroclaw-labs/zeroclaw/archive/refs/tags/v0.5.8.tar.gz
sha256sums = SKIP
pkgname = zeroclaw
+1 -1
View File
@@ -1,6 +1,6 @@
# Maintainer: zeroclaw-labs <bot@zeroclaw.dev>
pkgname=zeroclaw
pkgver=0.5.6
pkgver=0.5.8
pkgrel=1
pkgdesc="Zero overhead. Zero compromise. 100% Rust. The fastest, smallest AI assistant."
arch=('x86_64')
+2 -2
View File
@@ -1,11 +1,11 @@
{
"version": "0.5.6",
"version": "0.5.8",
"description": "Zero overhead. Zero compromise. 100% Rust. The fastest, smallest AI assistant.",
"homepage": "https://github.com/zeroclaw-labs/zeroclaw",
"license": "MIT|Apache-2.0",
"architecture": {
"64bit": {
"url": "https://github.com/zeroclaw-labs/zeroclaw/releases/download/v0.5.6/zeroclaw-x86_64-pc-windows-msvc.zip",
"url": "https://github.com/zeroclaw-labs/zeroclaw/releases/download/v0.5.8/zeroclaw-x86_64-pc-windows-msvc.zip",
"hash": "",
"bin": "zeroclaw.exe"
}
@@ -411,30 +411,6 @@ allowed_roots = [\"~/Desktop/projects\", \"/opt/shared-repo\"]
- 内存上下文注入忽略旧的 `assistant_resp*` 自动保存键,以防止旧模型生成的摘要被视为事实。
### `[memory.mem0]`
Mem0 (OpenMemory) 后端 — 连接自托管 mem0 服务器,提供基于向量的记忆存储和 LLM 事实提取。构建时需要 `memory-mem0` feature flag,配置需设置 `backend = "mem0"`
| 键 | 默认值 | 环境变量 | 用途 |
|---|---|---|---|
| `url` | `http://localhost:8765` | `MEM0_URL` | OpenMemory 服务器地址 |
| `user_id` | `zeroclaw` | `MEM0_USER_ID` | 记忆作用域的用户 ID |
| `app_name` | `zeroclaw` | `MEM0_APP_NAME` | 在 mem0 中注册的应用名称 |
| `infer` | `true` | — | 使用 LLM 从存储文本中提取事实 (`true`) 或原样存储 (`false`) |
| `extraction_prompt` | 未设置 | `MEM0_EXTRACTION_PROMPT` | 自定义 LLM 事实提取提示词(如适用于非英文内容) |
```toml
[memory]
backend = "mem0"
[memory.mem0]
url = "http://192.168.0.171:8765"
user_id = "zeroclaw-bot"
extraction_prompt = "用原始语言提取事实..."
```
服务器部署脚本位于 `deploy/mem0/`
## `[[model_routes]]` 和 `[[embedding_routes]]`
使用路由提示,以便集成可以在模型 ID 演变时保持稳定的名称。
-24
View File
@@ -508,30 +508,6 @@ Notes:
- Memory context injection ignores legacy `assistant_resp*` auto-save keys to prevent old model-authored summaries from being treated as facts.
### `[memory.mem0]`
Mem0 (OpenMemory) backend — connects to a self-hosted mem0 server for vector-based memory with LLM-powered fact extraction. Requires feature flag `memory-mem0` at build time and `backend = "mem0"` in config.
| Key | Default | Env var | Purpose |
|---|---|---|---|
| `url` | `http://localhost:8765` | `MEM0_URL` | OpenMemory server URL |
| `user_id` | `zeroclaw` | `MEM0_USER_ID` | User ID for scoping memories |
| `app_name` | `zeroclaw` | `MEM0_APP_NAME` | Application name registered in mem0 |
| `infer` | `true` | — | Use LLM to extract facts from stored text (`true`) or store raw (`false`) |
| `extraction_prompt` | unset | `MEM0_EXTRACTION_PROMPT` | Custom prompt for LLM fact extraction (e.g. for non-English content) |
```toml
[memory]
backend = "mem0"
[memory.mem0]
url = "http://192.168.0.171:8765"
user_id = "zeroclaw-bot"
extraction_prompt = "Extract facts in the original language..."
```
Server deployment scripts are in `deploy/mem0/`.
## `[[model_routes]]` and `[[embedding_routes]]`
Use route hints so integrations can keep stable names while model IDs evolve.
-24
View File
@@ -337,30 +337,6 @@ Lưu ý:
- Chèn ngữ cảnh memory bỏ qua khóa auto-save `assistant_resp*` kiểu cũ để tránh tóm tắt do model tạo bị coi là sự thật.
### `[memory.mem0]`
Backend Mem0 (OpenMemory) — kết nối đến server mem0 tự host, cung cấp bộ nhớ vector với trích xuất sự kiện bằng LLM. Cần feature flag `memory-mem0` khi build và `backend = "mem0"` trong config.
| Khóa | Mặc định | Biến môi trường | Mục đích |
|---|---|---|---|
| `url` | `http://localhost:8765` | `MEM0_URL` | URL server OpenMemory |
| `user_id` | `zeroclaw` | `MEM0_USER_ID` | User ID để phân vùng memory |
| `app_name` | `zeroclaw` | `MEM0_APP_NAME` | Tên ứng dụng đăng ký trong mem0 |
| `infer` | `true` | — | Dùng LLM trích xuất sự kiện từ text (`true`) hoặc lưu nguyên (`false`) |
| `extraction_prompt` | chưa đặt | `MEM0_EXTRACTION_PROMPT` | Prompt tùy chỉnh cho trích xuất sự kiện LLM (vd: cho nội dung không phải tiếng Anh) |
```toml
[memory]
backend = "mem0"
[memory.mem0]
url = "http://192.168.0.171:8765"
user_id = "zeroclaw-bot"
extraction_prompt = "Trích xuất sự kiện bằng ngôn ngữ gốc..."
```
Script triển khai server nằm trong `deploy/mem0/`.
## `[[model_routes]]` và `[[embedding_routes]]`
Route hint giúp tên tích hợp ổn định khi model ID thay đổi.
+19
View File
@@ -1448,6 +1448,25 @@ else
step_dot "Skipping install"
fi
# --- Build web dashboard ---
if [[ "$SKIP_BUILD" == false && -d "$WORK_DIR/web" ]]; then
if have_cmd node && have_cmd npm; then
step_dot "Building web dashboard"
if (cd "$WORK_DIR/web" && npm ci --ignore-scripts 2>/dev/null && npm run build 2>/dev/null); then
step_ok "Web dashboard built"
else
warn "Web dashboard build failed — dashboard will not be available"
fi
else
warn "node/npm not found — skipping web dashboard build"
warn "Install Node.js (>=18) and re-run, or build manually: cd web && npm ci && npm run build"
fi
else
if [[ "$SKIP_BUILD" == true ]]; then
step_dot "Skipping web dashboard build"
fi
fi
ZEROCLAW_BIN=""
if [[ -x "$HOME/.cargo/bin/zeroclaw" ]]; then
ZEROCLAW_BIN="$HOME/.cargo/bin/zeroclaw"
+373 -29
View File
@@ -2707,16 +2707,53 @@ pub(crate) async fn run_tool_call_loop(
let use_native_tools = provider.supports_native_tools() && !tool_specs.is_empty();
let image_marker_count = multimodal::count_image_markers(history);
if image_marker_count > 0 && !provider.supports_vision() {
return Err(ProviderCapabilityError {
provider: provider_name.to_string(),
capability: "vision".to_string(),
message: format!(
"received {image_marker_count} image marker(s), but this provider does not support vision input"
),
// ── Vision provider routing ──────────────────────────
// When the default provider lacks vision support but a dedicated
// vision_provider is configured, create it on demand and use it
// for this iteration. Otherwise, preserve the original error.
let vision_provider_box: Option<Box<dyn Provider>> = if image_marker_count > 0
&& !provider.supports_vision()
{
if let Some(ref vp) = multimodal_config.vision_provider {
let vp_instance = providers::create_provider(vp, None)
.map_err(|e| anyhow::anyhow!("failed to create vision provider '{vp}': {e}"))?;
if !vp_instance.supports_vision() {
return Err(ProviderCapabilityError {
provider: vp.clone(),
capability: "vision".to_string(),
message: format!(
"configured vision_provider '{vp}' does not support vision input"
),
}
.into());
}
Some(vp_instance)
} else {
return Err(ProviderCapabilityError {
provider: provider_name.to_string(),
capability: "vision".to_string(),
message: format!(
"received {image_marker_count} image marker(s), but this provider does not support vision input"
),
}
.into());
}
.into());
}
} else {
None
};
let (active_provider, active_provider_name, active_model): (&dyn Provider, &str, &str) =
if let Some(ref vp_box) = vision_provider_box {
let vp_name = multimodal_config
.vision_provider
.as_deref()
.unwrap_or(provider_name);
let vm = multimodal_config.vision_model.as_deref().unwrap_or(model);
(vp_box.as_ref(), vp_name, vm)
} else {
(provider, provider_name, model)
};
let prepared_messages =
multimodal::prepare_messages_for_provider(history, multimodal_config).await?;
@@ -2732,15 +2769,15 @@ pub(crate) async fn run_tool_call_loop(
}
observer.record_event(&ObserverEvent::LlmRequest {
provider: provider_name.to_string(),
model: model.to_string(),
provider: active_provider_name.to_string(),
model: active_model.to_string(),
messages_count: history.len(),
});
runtime_trace::record_event(
"llm_request",
Some(channel_name),
Some(provider_name),
Some(model),
Some(active_provider_name),
Some(active_model),
Some(&turn_id),
None,
None,
@@ -2778,12 +2815,12 @@ pub(crate) async fn run_tool_call_loop(
None
};
let chat_future = provider.chat(
let chat_future = active_provider.chat(
ChatRequest {
messages: &prepared_messages.messages,
tools: request_tools,
},
model,
active_model,
temperature,
);
@@ -2836,8 +2873,8 @@ pub(crate) async fn run_tool_call_loop(
.unwrap_or((None, None));
observer.record_event(&ObserverEvent::LlmResponse {
provider: provider_name.to_string(),
model: model.to_string(),
provider: active_provider_name.to_string(),
model: active_model.to_string(),
duration: llm_started_at.elapsed(),
success: true,
error_message: None,
@@ -2846,10 +2883,9 @@ pub(crate) async fn run_tool_call_loop(
});
// Record cost via task-local tracker (no-op when not scoped)
let _ = resp
.usage
.as_ref()
.and_then(|usage| record_tool_loop_cost_usage(provider_name, model, usage));
let _ = resp.usage.as_ref().and_then(|usage| {
record_tool_loop_cost_usage(active_provider_name, active_model, usage)
});
let response_text = resp.text_or_empty().to_string();
// First try native structured tool calls (OpenAI-format).
@@ -2872,8 +2908,8 @@ pub(crate) async fn run_tool_call_loop(
runtime_trace::record_event(
"tool_call_parse_issue",
Some(channel_name),
Some(provider_name),
Some(model),
Some(active_provider_name),
Some(active_model),
Some(&turn_id),
Some(false),
Some(&parse_issue),
@@ -2890,8 +2926,8 @@ pub(crate) async fn run_tool_call_loop(
runtime_trace::record_event(
"llm_response",
Some(channel_name),
Some(provider_name),
Some(model),
Some(active_provider_name),
Some(active_model),
Some(&turn_id),
Some(true),
None,
@@ -2940,8 +2976,8 @@ pub(crate) async fn run_tool_call_loop(
Err(e) => {
let safe_error = crate::providers::sanitize_api_error(&e.to_string());
observer.record_event(&ObserverEvent::LlmResponse {
provider: provider_name.to_string(),
model: model.to_string(),
provider: active_provider_name.to_string(),
model: active_model.to_string(),
duration: llm_started_at.elapsed(),
success: false,
error_message: Some(safe_error.clone()),
@@ -2951,8 +2987,8 @@ pub(crate) async fn run_tool_call_loop(
runtime_trace::record_event(
"llm_response",
Some(channel_name),
Some(provider_name),
Some(model),
Some(active_provider_name),
Some(active_model),
Some(&turn_id),
Some(false),
Some(&safe_error),
@@ -5094,6 +5130,7 @@ mod tests {
max_images: 4,
max_image_size_mb: 1,
allow_remote_fetch: false,
..Default::default()
};
let err = run_tool_call_loop(
@@ -5171,6 +5208,313 @@ mod tests {
assert_eq!(calls.load(Ordering::SeqCst), 1);
}
/// When `vision_provider` is not set and the default provider lacks vision
/// support, the original `ProviderCapabilityError` should be returned.
#[tokio::test]
async fn run_tool_call_loop_no_vision_provider_config_preserves_error() {
let calls = Arc::new(AtomicUsize::new(0));
let provider = NonVisionProvider {
calls: Arc::clone(&calls),
};
let mut history = vec![ChatMessage::user(
"check [IMAGE:data:image/png;base64,iVBORw0KGgo=]".to_string(),
)];
let tools_registry: Vec<Box<dyn Tool>> = Vec::new();
let observer = NoopObserver;
let err = run_tool_call_loop(
&provider,
&mut history,
&tools_registry,
&observer,
"mock-provider",
"mock-model",
0.0,
true,
None,
"cli",
None,
&crate::config::MultimodalConfig::default(),
3,
None,
None,
None,
&[],
&[],
None,
None,
&crate::config::PacingConfig::default(),
)
.await
.expect_err("should fail without vision_provider config");
assert!(err.to_string().contains("capability=vision"));
assert_eq!(calls.load(Ordering::SeqCst), 0);
}
/// When `vision_provider` is set but the provider factory cannot resolve
/// the name, a descriptive error should be returned (not the generic
/// capability error).
#[tokio::test]
async fn run_tool_call_loop_vision_provider_creation_failure() {
let calls = Arc::new(AtomicUsize::new(0));
let provider = NonVisionProvider {
calls: Arc::clone(&calls),
};
let mut history = vec![ChatMessage::user(
"inspect [IMAGE:data:image/png;base64,iVBORw0KGgo=]".to_string(),
)];
let tools_registry: Vec<Box<dyn Tool>> = Vec::new();
let observer = NoopObserver;
let multimodal = crate::config::MultimodalConfig {
vision_provider: Some("nonexistent-provider-xyz".to_string()),
vision_model: Some("some-model".to_string()),
..Default::default()
};
let err = run_tool_call_loop(
&provider,
&mut history,
&tools_registry,
&observer,
"mock-provider",
"mock-model",
0.0,
true,
None,
"cli",
None,
&multimodal,
3,
None,
None,
None,
&[],
&[],
None,
None,
&crate::config::PacingConfig::default(),
)
.await
.expect_err("should fail when vision provider cannot be created");
assert!(
err.to_string().contains("failed to create vision provider"),
"expected creation failure error, got: {}",
err
);
assert_eq!(calls.load(Ordering::SeqCst), 0);
}
/// Messages without image markers should use the default provider even
/// when `vision_provider` is configured.
#[tokio::test]
async fn run_tool_call_loop_no_images_uses_default_provider() {
let provider = ScriptedProvider::from_text_responses(vec!["hello world"]);
let mut history = vec![ChatMessage::user("just text, no images".to_string())];
let tools_registry: Vec<Box<dyn Tool>> = Vec::new();
let observer = NoopObserver;
let multimodal = crate::config::MultimodalConfig {
vision_provider: Some("nonexistent-provider-xyz".to_string()),
vision_model: Some("some-model".to_string()),
..Default::default()
};
// Even though vision_provider points to a nonexistent provider, this
// should succeed because there are no image markers to trigger routing.
let result = run_tool_call_loop(
&provider,
&mut history,
&tools_registry,
&observer,
"scripted",
"scripted-model",
0.0,
true,
None,
"cli",
None,
&multimodal,
3,
None,
None,
None,
&[],
&[],
None,
None,
&crate::config::PacingConfig::default(),
)
.await
.expect("text-only messages should succeed with default provider");
assert_eq!(result, "hello world");
}
/// When `vision_provider` is set but `vision_model` is not, the default
/// model should be used as fallback for the vision provider.
#[tokio::test]
async fn run_tool_call_loop_vision_provider_without_model_falls_back() {
let calls = Arc::new(AtomicUsize::new(0));
let provider = NonVisionProvider {
calls: Arc::clone(&calls),
};
let mut history = vec![ChatMessage::user(
"look [IMAGE:data:image/png;base64,iVBORw0KGgo=]".to_string(),
)];
let tools_registry: Vec<Box<dyn Tool>> = Vec::new();
let observer = NoopObserver;
// vision_provider set but vision_model is None — the code should
// fall back to the default model. Since the provider name is invalid,
// we just verify the error path references the correct provider.
let multimodal = crate::config::MultimodalConfig {
vision_provider: Some("nonexistent-provider-xyz".to_string()),
vision_model: None,
..Default::default()
};
let err = run_tool_call_loop(
&provider,
&mut history,
&tools_registry,
&observer,
"mock-provider",
"mock-model",
0.0,
true,
None,
"cli",
None,
&multimodal,
3,
None,
None,
None,
&[],
&[],
None,
None,
&crate::config::PacingConfig::default(),
)
.await
.expect_err("should fail due to nonexistent vision provider");
// Verify the routing was attempted (not the generic capability error).
assert!(
err.to_string().contains("failed to create vision provider"),
"expected creation failure, got: {}",
err
);
}
/// Empty `[IMAGE:]` markers (which are preserved as literal text by the
/// parser) should not trigger vision provider routing.
#[tokio::test]
async fn run_tool_call_loop_empty_image_markers_use_default_provider() {
let provider = ScriptedProvider::from_text_responses(vec!["handled"]);
let mut history = vec![ChatMessage::user(
"empty marker [IMAGE:] should be ignored".to_string(),
)];
let tools_registry: Vec<Box<dyn Tool>> = Vec::new();
let observer = NoopObserver;
let multimodal = crate::config::MultimodalConfig {
vision_provider: Some("nonexistent-provider-xyz".to_string()),
..Default::default()
};
let result = run_tool_call_loop(
&provider,
&mut history,
&tools_registry,
&observer,
"scripted",
"scripted-model",
0.0,
true,
None,
"cli",
None,
&multimodal,
3,
None,
None,
None,
&[],
&[],
None,
None,
&crate::config::PacingConfig::default(),
)
.await
.expect("empty image markers should not trigger vision routing");
assert_eq!(result, "handled");
}
/// Multiple image markers should still trigger vision routing when
/// vision_provider is configured.
#[tokio::test]
async fn run_tool_call_loop_multiple_images_trigger_vision_routing() {
let calls = Arc::new(AtomicUsize::new(0));
let provider = NonVisionProvider {
calls: Arc::clone(&calls),
};
let mut history = vec![ChatMessage::user(
"two images [IMAGE:data:image/png;base64,aQ==] and [IMAGE:data:image/png;base64,bQ==]"
.to_string(),
)];
let tools_registry: Vec<Box<dyn Tool>> = Vec::new();
let observer = NoopObserver;
let multimodal = crate::config::MultimodalConfig {
vision_provider: Some("nonexistent-provider-xyz".to_string()),
vision_model: Some("llava:7b".to_string()),
..Default::default()
};
let err = run_tool_call_loop(
&provider,
&mut history,
&tools_registry,
&observer,
"mock-provider",
"mock-model",
0.0,
true,
None,
"cli",
None,
&multimodal,
3,
None,
None,
None,
&[],
&[],
None,
None,
&crate::config::PacingConfig::default(),
)
.await
.expect_err("should attempt vision provider creation for multiple images");
assert!(
err.to_string().contains("failed to create vision provider"),
"expected creation failure for multiple images, got: {}",
err
);
}
#[test]
fn should_execute_tools_in_parallel_returns_false_for_single_call() {
let calls = vec![ParsedToolCall {
+9
View File
@@ -118,6 +118,9 @@ mod tests {
timestamp: "now".into(),
session_id: None,
score: None,
namespace: "default".into(),
importance: None,
superseded_by: None,
}])
}
@@ -226,6 +229,9 @@ mod tests {
timestamp: "now".into(),
session_id: None,
score: Some(0.95),
namespace: "default".into(),
importance: None,
superseded_by: None,
},
MemoryEntry {
id: "2".into(),
@@ -235,6 +241,9 @@ mod tests {
timestamp: "now".into(),
session_id: None,
score: Some(0.9),
namespace: "default".into(),
importance: None,
superseded_by: None,
},
]),
};
+46
View File
@@ -562,4 +562,50 @@ mod tests {
let parsed: ApprovalRequest = serde_json::from_str(&json).unwrap();
assert_eq!(parsed.tool_name, "shell");
}
// ── Regression: #4247 default approved tools in channels ──
#[test]
fn non_interactive_allows_default_auto_approve_tools() {
let config = AutonomyConfig::default();
let mgr = ApprovalManager::for_non_interactive(&config);
for tool in &config.auto_approve {
assert!(
!mgr.needs_approval(tool),
"default auto_approve tool '{tool}' should not need approval in non-interactive mode"
);
}
}
#[test]
fn non_interactive_denies_unknown_tools() {
let config = AutonomyConfig::default();
let mgr = ApprovalManager::for_non_interactive(&config);
assert!(
mgr.needs_approval("some_unknown_tool"),
"unknown tool should need approval"
);
}
#[test]
fn non_interactive_weather_is_auto_approved() {
let config = AutonomyConfig::default();
let mgr = ApprovalManager::for_non_interactive(&config);
assert!(
!mgr.needs_approval("weather"),
"weather tool must not need approval — it is in the default auto_approve list"
);
}
#[test]
fn always_ask_overrides_auto_approve() {
let mut config = AutonomyConfig::default();
config.always_ask = vec!["weather".into()];
let mgr = ApprovalManager::for_non_interactive(&config);
assert!(
mgr.needs_approval("weather"),
"always_ask must override auto_approve"
);
}
}
+210 -7
View File
@@ -8,6 +8,7 @@ use matrix_sdk::{
events::reaction::ReactionEventContent,
events::receipt::ReceiptThread,
events::relation::{Annotation, Thread},
events::room::member::StrippedRoomMemberEvent,
events::room::message::{
MessageType, OriginalSyncRoomMessageEvent, Relation, RoomMessageEventContent,
},
@@ -32,6 +33,7 @@ pub struct MatrixChannel {
access_token: String,
room_id: String,
allowed_users: Vec<String>,
allowed_rooms: Vec<String>,
session_owner_hint: Option<String>,
session_device_id_hint: Option<String>,
zeroclaw_dir: Option<PathBuf>,
@@ -48,6 +50,7 @@ impl std::fmt::Debug for MatrixChannel {
.field("homeserver", &self.homeserver)
.field("room_id", &self.room_id)
.field("allowed_users", &self.allowed_users)
.field("allowed_rooms", &self.allowed_rooms)
.finish_non_exhaustive()
}
}
@@ -121,7 +124,16 @@ impl MatrixChannel {
room_id: String,
allowed_users: Vec<String>,
) -> Self {
Self::new_with_session_hint(homeserver, access_token, room_id, allowed_users, None, None)
Self::new_full(
homeserver,
access_token,
room_id,
allowed_users,
vec![],
None,
None,
None,
)
}
pub fn new_with_session_hint(
@@ -132,11 +144,12 @@ impl MatrixChannel {
owner_hint: Option<String>,
device_id_hint: Option<String>,
) -> Self {
Self::new_with_session_hint_and_zeroclaw_dir(
Self::new_full(
homeserver,
access_token,
room_id,
allowed_users,
vec![],
owner_hint,
device_id_hint,
None,
@@ -151,6 +164,28 @@ impl MatrixChannel {
owner_hint: Option<String>,
device_id_hint: Option<String>,
zeroclaw_dir: Option<PathBuf>,
) -> Self {
Self::new_full(
homeserver,
access_token,
room_id,
allowed_users,
vec![],
owner_hint,
device_id_hint,
zeroclaw_dir,
)
}
pub fn new_full(
homeserver: String,
access_token: String,
room_id: String,
allowed_users: Vec<String>,
allowed_rooms: Vec<String>,
owner_hint: Option<String>,
device_id_hint: Option<String>,
zeroclaw_dir: Option<PathBuf>,
) -> Self {
let homeserver = homeserver.trim_end_matches('/').to_string();
let access_token = access_token.trim().to_string();
@@ -160,12 +195,18 @@ impl MatrixChannel {
.map(|user| user.trim().to_string())
.filter(|user| !user.is_empty())
.collect();
let allowed_rooms = allowed_rooms
.into_iter()
.map(|room| room.trim().to_string())
.filter(|room| !room.is_empty())
.collect();
Self {
homeserver,
access_token,
room_id,
allowed_users,
allowed_rooms,
session_owner_hint: Self::normalize_optional_field(owner_hint),
session_device_id_hint: Self::normalize_optional_field(device_id_hint),
zeroclaw_dir,
@@ -220,6 +261,21 @@ impl MatrixChannel {
allowed_users.iter().any(|u| u.eq_ignore_ascii_case(sender))
}
/// Check whether a room (by its canonical ID) is in the allowed_rooms list.
/// If allowed_rooms is empty, all rooms are allowed.
fn is_room_allowed_static(allowed_rooms: &[String], room_id: &str) -> bool {
if allowed_rooms.is_empty() {
return true;
}
allowed_rooms
.iter()
.any(|r| r.eq_ignore_ascii_case(room_id))
}
fn is_room_allowed(&self, room_id: &str) -> bool {
Self::is_room_allowed_static(&self.allowed_rooms, room_id)
}
fn is_supported_message_type(msgtype: &str) -> bool {
matches!(msgtype, "m.text" | "m.notice")
}
@@ -228,6 +284,10 @@ impl MatrixChannel {
!body.trim().is_empty()
}
fn room_matches_target(target_room_id: &str, incoming_room_id: &str) -> bool {
target_room_id == incoming_room_id
}
fn cache_event_id(
event_id: &str,
recent_order: &mut std::collections::VecDeque<String>,
@@ -526,8 +586,9 @@ impl MatrixChannel {
if client.encryption().backups().are_enabled().await {
tracing::info!("Matrix room-key backup is enabled for this device.");
} else {
client.encryption().backups().disable().await;
tracing::warn!(
"Matrix room-key backup is not enabled for this device; `matrix_sdk_crypto::backups` warnings about missing backup keys may appear until recovery is configured."
"Matrix room-key backup is not enabled for this device; automatic backup attempts have been disabled to suppress recurring warnings. To enable backups, configure server-side key backup and recovery for this device."
);
}
}
@@ -697,6 +758,7 @@ impl Channel for MatrixChannel {
let target_room_for_handler = target_room.clone();
let my_user_id_for_handler = my_user_id.clone();
let allowed_users_for_handler = self.allowed_users.clone();
let allowed_rooms_for_handler = self.allowed_rooms.clone();
let dedupe_for_handler = Arc::clone(&recent_event_cache);
let homeserver_for_handler = self.homeserver.clone();
let access_token_for_handler = self.access_token.clone();
@@ -704,18 +766,29 @@ impl Channel for MatrixChannel {
client.add_event_handler(move |event: OriginalSyncRoomMessageEvent, room: Room| {
let tx = tx_handler.clone();
let _target_room = target_room_for_handler.clone();
let target_room = target_room_for_handler.clone();
let my_user_id = my_user_id_for_handler.clone();
let allowed_users = allowed_users_for_handler.clone();
let allowed_rooms = allowed_rooms_for_handler.clone();
let dedupe = Arc::clone(&dedupe_for_handler);
let homeserver = homeserver_for_handler.clone();
let access_token = access_token_for_handler.clone();
let voice_mode = Arc::clone(&voice_mode_for_handler);
async move {
if false
/* multi-room: room_id filter disabled */
{
if !MatrixChannel::room_matches_target(
target_room.as_str(),
room.room_id().as_str(),
) {
return;
}
// Room allowlist: skip messages from rooms not in the configured list
if !MatrixChannel::is_room_allowed_static(&allowed_rooms, room.room_id().as_ref()) {
tracing::debug!(
"Matrix: ignoring message from room {} (not in allowed_rooms)",
room.room_id()
);
return;
}
@@ -907,6 +980,45 @@ impl Channel for MatrixChannel {
}
});
// Invite handler: auto-accept invites for allowed rooms, auto-reject others
let allowed_rooms_for_invite = self.allowed_rooms.clone();
client.add_event_handler(move |event: StrippedRoomMemberEvent, room: Room| {
let allowed_rooms = allowed_rooms_for_invite.clone();
async move {
// Only process invite events targeting us
if event.content.membership
!= matrix_sdk::ruma::events::room::member::MembershipState::Invite
{
return;
}
let room_id_str = room.room_id().to_string();
if MatrixChannel::is_room_allowed_static(&allowed_rooms, &room_id_str) {
// Room is allowed (or no allowlist configured): auto-accept
tracing::info!(
"Matrix: auto-accepting invite for allowed room {}",
room_id_str
);
if let Err(error) = room.join().await {
tracing::warn!("Matrix: failed to auto-join room {}: {error}", room_id_str);
}
} else {
// Room is NOT in allowlist: auto-reject
tracing::info!(
"Matrix: auto-rejecting invite for room {} (not in allowed_rooms)",
room_id_str
);
if let Err(error) = room.leave().await {
tracing::warn!(
"Matrix: failed to reject invite for room {}: {error}",
room_id_str
);
}
}
}
});
let sync_settings = SyncSettings::new().timeout(std::time::Duration::from_secs(30));
client
.sync_with_result_callback(sync_settings, |sync_result| {
@@ -1294,6 +1406,22 @@ mod tests {
assert_eq!(value["room"]["timeline"]["limit"], 1);
}
#[test]
fn room_scope_matches_configured_room() {
assert!(MatrixChannel::room_matches_target(
"!ops:matrix.org",
"!ops:matrix.org"
));
}
#[test]
fn room_scope_rejects_other_rooms() {
assert!(!MatrixChannel::room_matches_target(
"!ops:matrix.org",
"!other:matrix.org"
));
}
#[test]
fn event_id_cache_deduplicates_and_evicts_old_entries() {
let mut recent_order = std::collections::VecDeque::new();
@@ -1549,4 +1677,79 @@ mod tests {
let resp: SyncResponse = serde_json::from_str(json).unwrap();
assert!(resp.rooms.join.is_empty());
}
#[test]
fn empty_allowed_rooms_permits_all() {
let ch = make_channel();
assert!(ch.is_room_allowed("!any:matrix.org"));
assert!(ch.is_room_allowed("!other:evil.org"));
}
#[test]
fn allowed_rooms_filters_by_id() {
let ch = MatrixChannel::new_full(
"https://m.org".to_string(),
"tok".to_string(),
"!r:m".to_string(),
vec!["@user:m".to_string()],
vec!["!allowed:matrix.org".to_string()],
None,
None,
None,
);
assert!(ch.is_room_allowed("!allowed:matrix.org"));
assert!(!ch.is_room_allowed("!forbidden:matrix.org"));
}
#[test]
fn allowed_rooms_supports_aliases() {
let ch = MatrixChannel::new_full(
"https://m.org".to_string(),
"tok".to_string(),
"!r:m".to_string(),
vec!["@user:m".to_string()],
vec![
"#ops:matrix.org".to_string(),
"!direct:matrix.org".to_string(),
],
None,
None,
None,
);
assert!(ch.is_room_allowed("!direct:matrix.org"));
assert!(ch.is_room_allowed("#ops:matrix.org"));
assert!(!ch.is_room_allowed("!other:matrix.org"));
}
#[test]
fn allowed_rooms_case_insensitive() {
let ch = MatrixChannel::new_full(
"https://m.org".to_string(),
"tok".to_string(),
"!r:m".to_string(),
vec![],
vec!["!Room:Matrix.org".to_string()],
None,
None,
None,
);
assert!(ch.is_room_allowed("!room:matrix.org"));
assert!(ch.is_room_allowed("!ROOM:MATRIX.ORG"));
}
#[test]
fn allowed_rooms_trims_whitespace() {
let ch = MatrixChannel::new_full(
"https://m.org".to_string(),
"tok".to_string(),
"!r:m".to_string(),
vec![],
vec![" !room:matrix.org ".to_string(), " ".to_string()],
None,
None,
None,
);
assert_eq!(ch.allowed_rooms.len(), 1);
assert!(ch.is_room_allowed("!room:matrix.org"));
}
}
+5 -1
View File
@@ -3855,11 +3855,12 @@ fn collect_configured_channels(
if let Some(ref mx) = config.channels_config.matrix {
channels.push(ConfiguredChannel {
display_name: "Matrix",
channel: Arc::new(MatrixChannel::new_with_session_hint_and_zeroclaw_dir(
channel: Arc::new(MatrixChannel::new_full(
mx.homeserver.clone(),
mx.access_token.clone(),
mx.room_id.clone(),
mx.allowed_users.clone(),
mx.allowed_rooms.clone(),
mx.user_id.clone(),
mx.device_id.clone(),
config.config_path.parent().map(|path| path.to_path_buf()),
@@ -6875,6 +6876,9 @@ BTC is currently around $65,000 based on latest tool output."#
timestamp: "2026-02-20T00:00:00Z".to_string(),
session_id: None,
score: Some(0.9),
namespace: "default".into(),
importance: None,
superseded_by: None,
}])
}
+203
View File
@@ -1140,6 +1140,11 @@ Allowlist Telegram username (without '@') or numeric user ID.",
content = format!("{quote}\n\n{content}");
}
// Prepend forwarding attribution when the message was forwarded
if let Some(attr) = Self::format_forward_attribution(message) {
content = format!("{attr}{content}");
}
Some(ChannelMessage {
id: format!("telegram_{chat_id}_{message_id}"),
sender: sender_identity,
@@ -1263,6 +1268,13 @@ Allowlist Telegram username (without '@') or numeric user ID.",
format!("[Voice] {text}")
};
// Prepend forwarding attribution when the message was forwarded
let content = if let Some(attr) = Self::format_forward_attribution(message) {
format!("{attr}{content}")
} else {
content
};
Some(ChannelMessage {
id: format!("telegram_{chat_id}_{message_id}"),
sender: sender_identity,
@@ -1299,6 +1311,41 @@ Allowlist Telegram username (without '@') or numeric user ID.",
(username, sender_id, sender_identity)
}
/// Build a forwarding attribution prefix from Telegram forward fields.
///
/// Returns `Some("[Forwarded from ...] ")` when the message is forwarded,
/// `None` otherwise.
fn format_forward_attribution(message: &serde_json::Value) -> Option<String> {
if let Some(from_chat) = message.get("forward_from_chat") {
// Forwarded from a channel or group
let title = from_chat
.get("title")
.and_then(serde_json::Value::as_str)
.unwrap_or("unknown channel");
Some(format!("[Forwarded from channel: {title}] "))
} else if let Some(from_user) = message.get("forward_from") {
// Forwarded from a user (privacy allows identity)
let label = from_user
.get("username")
.and_then(serde_json::Value::as_str)
.map(|u| format!("@{u}"))
.or_else(|| {
from_user
.get("first_name")
.and_then(serde_json::Value::as_str)
.map(String::from)
})
.unwrap_or_else(|| "unknown".to_string());
Some(format!("[Forwarded from {label}] "))
} else {
// Forwarded from a user who hides their identity
message
.get("forward_sender_name")
.and_then(serde_json::Value::as_str)
.map(|name| format!("[Forwarded from {name}] "))
}
}
/// Extract reply context from a Telegram `reply_to_message`, if present.
fn extract_reply_context(&self, message: &serde_json::Value) -> Option<String> {
let reply = message.get("reply_to_message")?;
@@ -1420,6 +1467,13 @@ Allowlist Telegram username (without '@') or numeric user ID.",
content
};
// Prepend forwarding attribution when the message was forwarded
let content = if let Some(attr) = Self::format_forward_attribution(message) {
format!("{attr}{content}")
} else {
content
};
// Exit voice-chat mode when user switches back to typing
if let Ok(mut vc) = self.voice_chats.lock() {
vc.remove(&reply_target);
@@ -4871,4 +4925,153 @@ mod tests {
TelegramChannel::new("token".into(), vec!["*".into()], false).with_ack_reactions(true);
assert!(ch.ack_reactions);
}
// ── Forwarded message tests ─────────────────────────────────────
#[test]
fn parse_update_message_forwarded_from_user_with_username() {
let ch = TelegramChannel::new("token".into(), vec!["*".into()], false);
let update = serde_json::json!({
"update_id": 100,
"message": {
"message_id": 50,
"text": "Check this out",
"from": { "id": 1, "username": "alice" },
"chat": { "id": 999 },
"forward_from": {
"id": 42,
"first_name": "Bob",
"username": "bob"
},
"forward_date": 1_700_000_000
}
});
let msg = ch
.parse_update_message(&update)
.expect("forwarded message should parse");
assert_eq!(msg.content, "[Forwarded from @bob] Check this out");
}
#[test]
fn parse_update_message_forwarded_from_channel() {
let ch = TelegramChannel::new("token".into(), vec!["*".into()], false);
let update = serde_json::json!({
"update_id": 101,
"message": {
"message_id": 51,
"text": "Breaking news",
"from": { "id": 1, "username": "alice" },
"chat": { "id": 999 },
"forward_from_chat": {
"id": -1_001_234_567_890_i64,
"title": "Daily News",
"username": "dailynews",
"type": "channel"
},
"forward_date": 1_700_000_000
}
});
let msg = ch
.parse_update_message(&update)
.expect("channel-forwarded message should parse");
assert_eq!(
msg.content,
"[Forwarded from channel: Daily News] Breaking news"
);
}
#[test]
fn parse_update_message_forwarded_hidden_sender() {
let ch = TelegramChannel::new("token".into(), vec!["*".into()], false);
let update = serde_json::json!({
"update_id": 102,
"message": {
"message_id": 52,
"text": "Secret tip",
"from": { "id": 1, "username": "alice" },
"chat": { "id": 999 },
"forward_sender_name": "Hidden User",
"forward_date": 1_700_000_000
}
});
let msg = ch
.parse_update_message(&update)
.expect("hidden-sender forwarded message should parse");
assert_eq!(msg.content, "[Forwarded from Hidden User] Secret tip");
}
#[test]
fn parse_update_message_non_forwarded_unaffected() {
let ch = TelegramChannel::new("token".into(), vec!["*".into()], false);
let update = serde_json::json!({
"update_id": 103,
"message": {
"message_id": 53,
"text": "Normal message",
"from": { "id": 1, "username": "alice" },
"chat": { "id": 999 }
}
});
let msg = ch
.parse_update_message(&update)
.expect("non-forwarded message should parse");
assert_eq!(msg.content, "Normal message");
}
#[test]
fn parse_update_message_forwarded_from_user_no_username() {
let ch = TelegramChannel::new("token".into(), vec!["*".into()], false);
let update = serde_json::json!({
"update_id": 104,
"message": {
"message_id": 54,
"text": "Hello there",
"from": { "id": 1, "username": "alice" },
"chat": { "id": 999 },
"forward_from": {
"id": 77,
"first_name": "Charlie"
},
"forward_date": 1_700_000_000
}
});
let msg = ch
.parse_update_message(&update)
.expect("forwarded message without username should parse");
assert_eq!(msg.content, "[Forwarded from Charlie] Hello there");
}
#[test]
fn forwarded_photo_attachment_has_attribution() {
// Verify that format_forward_attribution produces correct prefix
// for a photo message (the actual download is async, so we test the
// helper directly with a photo-bearing message structure).
let message = serde_json::json!({
"message_id": 60,
"from": { "id": 1, "username": "alice" },
"chat": { "id": 999 },
"photo": [
{ "file_id": "abc123", "file_unique_id": "u1", "width": 320, "height": 240 }
],
"forward_from": {
"id": 42,
"username": "bob"
},
"forward_date": 1_700_000_000
});
let attr =
TelegramChannel::format_forward_attribution(&message).expect("should detect forward");
assert_eq!(attr, "[Forwarded from @bob] ");
// Simulate what try_parse_attachment_message does after building content
let photo_content = "[IMAGE:/tmp/photo.jpg]".to_string();
let content = format!("{attr}{photo_content}");
assert_eq!(content, "[Forwarded from @bob] [IMAGE:/tmp/photo.jpg]");
}
}
+130 -1
View File
@@ -1,6 +1,7 @@
//! Multi-provider Text-to-Speech (TTS) subsystem.
//!
//! Supports OpenAI, ElevenLabs, Google Cloud TTS, and Edge TTS (free, subprocess-based).
//! Supports OpenAI, ElevenLabs, Google Cloud TTS, Edge TTS (free, subprocess-based),
//! and Piper TTS (local GPU-accelerated, OpenAI-compatible endpoint).
//! Provider selection is driven by [`TtsConfig`] in `config.toml`.
use std::collections::HashMap;
@@ -451,6 +452,80 @@ impl TtsProvider for EdgeTtsProvider {
}
}
// ── Piper TTS (local, OpenAI-compatible) ─────────────────────────
/// Piper TTS provider — local GPU-accelerated server with an OpenAI-compatible endpoint.
pub struct PiperTtsProvider {
client: reqwest::Client,
api_url: String,
}
impl PiperTtsProvider {
/// Create a new Piper TTS provider pointing at the given API URL.
pub fn new(api_url: &str) -> Self {
Self {
client: reqwest::Client::builder()
.timeout(TTS_HTTP_TIMEOUT)
.build()
.expect("Failed to build HTTP client for Piper TTS"),
api_url: api_url.to_string(),
}
}
}
#[async_trait::async_trait]
impl TtsProvider for PiperTtsProvider {
fn name(&self) -> &str {
"piper"
}
async fn synthesize(&self, text: &str, voice: &str) -> Result<Vec<u8>> {
let body = serde_json::json!({
"model": "tts-1",
"input": text,
"voice": voice,
});
let resp = self
.client
.post(&self.api_url)
.json(&body)
.send()
.await
.context("Failed to send Piper TTS request")?;
let status = resp.status();
if !status.is_success() {
let error_body: serde_json::Value = resp
.json()
.await
.unwrap_or_else(|_| serde_json::json!({"error": "unknown"}));
let msg = error_body["error"]["message"]
.as_str()
.unwrap_or("unknown error");
bail!("Piper TTS API error ({}): {}", status, msg);
}
let bytes = resp
.bytes()
.await
.context("Failed to read Piper TTS response body")?;
Ok(bytes.to_vec())
}
fn supported_voices(&self) -> Vec<String> {
// Piper voices depend on installed models; return empty (dynamic).
Vec::new()
}
fn supported_formats(&self) -> Vec<String> {
["mp3", "wav", "opus"]
.iter()
.map(|s| (*s).to_string())
.collect()
}
}
// ── TtsManager ───────────────────────────────────────────────────
/// Central manager for multi-provider TTS synthesis.
@@ -510,6 +585,11 @@ impl TtsManager {
}
}
if let Some(ref piper_cfg) = config.piper {
let provider = PiperTtsProvider::new(&piper_cfg.api_url);
providers.insert("piper".to_string(), Box::new(provider));
}
let max_text_length = if config.max_text_length == 0 {
DEFAULT_MAX_TEXT_LENGTH
} else {
@@ -652,6 +732,54 @@ mod tests {
);
}
#[test]
fn piper_provider_creation() {
let provider = PiperTtsProvider::new("http://127.0.0.1:5000/v1/audio/speech");
assert_eq!(provider.name(), "piper");
assert_eq!(provider.api_url, "http://127.0.0.1:5000/v1/audio/speech");
assert_eq!(provider.supported_formats(), vec!["mp3", "wav", "opus"]);
// Piper voices depend on installed models; list is empty.
assert!(provider.supported_voices().is_empty());
}
#[test]
fn tts_manager_with_piper_provider() {
let mut config = default_tts_config();
config.default_provider = "piper".to_string();
config.piper = Some(crate::config::PiperTtsConfig {
api_url: "http://127.0.0.1:5000/v1/audio/speech".into(),
});
let manager = TtsManager::new(&config).unwrap();
assert_eq!(manager.available_providers(), vec!["piper"]);
}
#[tokio::test]
async fn tts_rejects_empty_text_for_piper() {
let mut config = default_tts_config();
config.default_provider = "piper".to_string();
config.piper = Some(crate::config::PiperTtsConfig {
api_url: "http://127.0.0.1:5000/v1/audio/speech".into(),
});
let manager = TtsManager::new(&config).unwrap();
let err = manager
.synthesize_with_provider("", "piper", "default")
.await
.unwrap_err();
assert!(
err.to_string().contains("must not be empty"),
"expected empty-text error, got: {err}"
);
}
#[test]
fn piper_not_registered_when_config_is_none() {
let config = default_tts_config();
let manager = TtsManager::new(&config).unwrap();
assert!(!manager.available_providers().contains(&"piper".to_string()));
}
#[test]
fn tts_config_defaults() {
let config = TtsConfig::default();
@@ -664,6 +792,7 @@ mod tests {
assert!(config.elevenlabs.is_none());
assert!(config.google.is_none());
assert!(config.edge.is_none());
assert!(config.piper.is_none());
}
#[test]
+49 -104
View File
@@ -21,12 +21,6 @@ use super::traits::{Channel, ChannelMessage, SendMessage};
// ── State machine ──────────────────────────────────────────────
/// Maximum allowed capture duration (seconds) to prevent unbounded memory growth.
const MAX_CAPTURE_SECS_LIMIT: u32 = 300;
/// Minimum silence timeout to prevent API hammering.
const MIN_SILENCE_TIMEOUT_MS: u32 = 100;
/// Internal states for the wake-word detector.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum WakeState {
@@ -36,6 +30,8 @@ pub enum WakeState {
Triggered,
/// Wake word confirmed — capturing the full utterance that follows.
Capturing,
/// Captured audio is being transcribed.
Processing,
}
impl std::fmt::Display for WakeState {
@@ -44,6 +40,7 @@ impl std::fmt::Display for WakeState {
Self::Listening => write!(f, "Listening"),
Self::Triggered => write!(f, "Triggered"),
Self::Capturing => write!(f, "Capturing"),
Self::Processing => write!(f, "Processing"),
}
}
}
@@ -81,97 +78,55 @@ impl Channel for VoiceWakeChannel {
let config = self.config.clone();
let transcription_config = self.transcription_config.clone();
// ── Validate config ───────────────────────────────────
let energy_threshold = config.energy_threshold;
if !energy_threshold.is_finite() || energy_threshold <= 0.0 {
bail!("VoiceWake: energy_threshold must be a positive finite number, got {energy_threshold}");
}
if config.silence_timeout_ms < MIN_SILENCE_TIMEOUT_MS {
bail!(
"VoiceWake: silence_timeout_ms must be >= {MIN_SILENCE_TIMEOUT_MS}, got {}",
config.silence_timeout_ms
);
}
let max_capture_secs = config.max_capture_secs.min(MAX_CAPTURE_SECS_LIMIT);
if max_capture_secs != config.max_capture_secs {
warn!(
"VoiceWake: max_capture_secs clamped from {} to {MAX_CAPTURE_SECS_LIMIT}",
config.max_capture_secs
);
}
// Run the blocking audio capture loop on a dedicated thread.
let (audio_tx, mut audio_rx) = mpsc::channel::<Vec<f32>>(64);
let (audio_tx, mut audio_rx) = mpsc::channel::<Vec<f32>>(4);
let energy_threshold = config.energy_threshold;
let silence_timeout = Duration::from_millis(u64::from(config.silence_timeout_ms));
let max_capture = Duration::from_secs(u64::from(max_capture_secs));
let max_capture = Duration::from_secs(u64::from(config.max_capture_secs));
let sample_rate: u32;
let channels_count: u16;
// ── Initialise cpal stream ────────────────────────────
// cpal::Stream is !Send, so we build and hold it on a dedicated thread.
// When the listen function exits, the shutdown oneshot is dropped,
// the thread exits, and the stream + microphone are released.
let (shutdown_tx, shutdown_rx) = tokio::sync::oneshot::channel::<()>();
let (init_tx, init_rx) = tokio::sync::oneshot::channel::<Result<(u32, u16)>>();
{
use cpal::traits::{DeviceTrait, HostTrait, StreamTrait};
let host = cpal::default_host();
let device = host
.default_input_device()
.ok_or_else(|| anyhow::anyhow!("No default audio input device available"))?;
let supported = device.default_input_config()?;
sample_rate = supported.sample_rate().0;
channels_count = supported.channels();
info!(
device = ?device.name().unwrap_or_default(),
sample_rate,
channels = channels_count,
"VoiceWake: opening audio input"
);
let stream_config: cpal::StreamConfig = supported.into();
let audio_tx_clone = audio_tx.clone();
std::thread::spawn(move || {
use cpal::traits::{DeviceTrait, HostTrait, StreamTrait};
let stream = device.build_input_stream(
&stream_config,
move |data: &[f32], _: &cpal::InputCallbackInfo| {
// Non-blocking: try_send and drop if full.
let _ = audio_tx_clone.try_send(data.to_vec());
},
move |err| {
warn!("VoiceWake: audio stream error: {err}");
},
None,
)?;
let result = (|| -> Result<(u32, u16, cpal::Stream)> {
let host = cpal::default_host();
let device = host.default_input_device().ok_or_else(|| {
anyhow::anyhow!("No default audio input device available")
})?;
stream.play()?;
let supported = device.default_input_config()?;
let sr = supported.sample_rate().0;
let ch = supported.channels();
info!(
device = ?device.name().unwrap_or_default(),
sample_rate = sr,
channels = ch,
"VoiceWake: opening audio input"
);
let stream_config: cpal::StreamConfig = supported.into();
let stream = device.build_input_stream(
&stream_config,
move |data: &[f32], _: &cpal::InputCallbackInfo| {
let _ = audio_tx_clone.try_send(data.to_vec());
},
move |err| {
warn!("VoiceWake: audio stream error: {err}");
},
None,
)?;
stream.play()?;
Ok((sr, ch, stream))
})();
match result {
Ok((sr, ch, _stream)) => {
let _ = init_tx.send(Ok((sr, ch)));
// Hold the stream alive until shutdown is signalled.
let _ = shutdown_rx.blocking_recv();
debug!("VoiceWake: stream holder thread exiting");
}
Err(e) => {
let _ = init_tx.send(Err(e));
}
}
});
let (sr, ch) = init_rx
.await
.map_err(|_| anyhow::anyhow!("VoiceWake: stream init thread panicked"))??;
sample_rate = sr;
channels_count = ch;
// Keep the stream alive for the lifetime of the channel.
// We leak it intentionally — the channel runs until the daemon shuts down.
std::mem::forget(stream);
}
// Drop the extra sender so the channel closes when the stream sender drops.
@@ -185,10 +140,6 @@ impl Channel for VoiceWakeChannel {
let mut capture_start = Instant::now();
let mut msg_counter: u64 = 0;
// Hard cap on capture buffer: max_capture_secs * sample_rate * channels * 2 (safety margin).
let max_buf_samples =
max_capture_secs as usize * sample_rate as usize * channels_count as usize * 2;
info!(wake_word = %wake_word, "VoiceWake: entering listen loop");
while let Some(chunk) = audio_rx.recv().await {
@@ -209,9 +160,7 @@ impl Channel for VoiceWakeChannel {
}
}
WakeState::Triggered => {
if capture_buf.len() + chunk.len() <= max_buf_samples {
capture_buf.extend_from_slice(&chunk);
}
capture_buf.extend_from_slice(&chunk);
if energy >= energy_threshold {
last_voice_at = Instant::now();
@@ -253,9 +202,7 @@ impl Channel for VoiceWakeChannel {
}
}
WakeState::Capturing => {
if capture_buf.len() + chunk.len() <= max_buf_samples {
capture_buf.extend_from_slice(&chunk);
}
capture_buf.extend_from_slice(&chunk);
if energy >= energy_threshold {
last_voice_at = Instant::now();
@@ -307,11 +254,13 @@ impl Channel for VoiceWakeChannel {
capture_buf.clear();
}
}
WakeState::Processing => {
// Should not receive chunks while processing, but just buffer them.
// State transitions happen above synchronously after transcription.
}
}
}
// Signal the stream holder thread to exit and release the microphone.
drop(shutdown_tx);
bail!("VoiceWake: audio stream ended unexpectedly");
}
}
@@ -334,14 +283,8 @@ pub fn encode_wav_from_f32(samples: &[f32], sample_rate: u32, channels: u16) ->
let bits_per_sample: u16 = 16;
let byte_rate = u32::from(channels) * sample_rate * u32::from(bits_per_sample) / 8;
let block_align = channels * bits_per_sample / 8;
// Guard against u32 overflow — reject buffers that exceed WAV's 4 GB limit.
let data_bytes = samples.len() * 2;
assert!(
u32::try_from(data_bytes).is_ok(),
"audio buffer too large for WAV encoding ({data_bytes} bytes)"
);
#[allow(clippy::cast_possible_truncation)]
let data_len = data_bytes as u32;
let data_len = (samples.len() * 2) as u32; // 16-bit = 2 bytes per sample; max ~25 MB
let file_len = 36 + data_len;
let mut buf = Vec::with_capacity(file_len as usize + 8);
@@ -389,6 +332,7 @@ mod tests {
assert_eq!(WakeState::Listening.to_string(), "Listening");
assert_eq!(WakeState::Triggered.to_string(), "Triggered");
assert_eq!(WakeState::Capturing.to_string(), "Capturing");
assert_eq!(WakeState::Processing.to_string(), "Processing");
}
#[test]
@@ -557,6 +501,7 @@ mod tests {
WakeState::Listening,
WakeState::Triggered,
WakeState::Capturing,
WakeState::Processing,
];
for (i, a) in states.iter().enumerate() {
for (j, b) in states.iter().enumerate() {
+12 -12
View File
@@ -19,18 +19,18 @@ pub use schema::{
ImageProviderFluxConfig, ImageProviderImagenConfig, ImageProviderStabilityConfig, JiraConfig,
KnowledgeConfig, LarkConfig, LinkedInConfig, LinkedInContentConfig, LinkedInImageConfig,
LocalWhisperConfig, MatrixConfig, McpConfig, McpServerConfig, McpTransport, MemoryConfig,
Microsoft365Config, ModelRouteConfig, MultimodalConfig, NextcloudTalkConfig,
NodeTransportConfig, NodesConfig, NotionConfig, ObservabilityConfig, OpenAiSttConfig,
OpenAiTtsConfig, OpenVpnTunnelConfig, OtpConfig, OtpMethod, PacingConfig,
PeripheralBoardConfig, PeripheralsConfig, PluginsConfig, ProjectIntelConfig, ProxyConfig,
ProxyScope, QdrantConfig, QueryClassificationConfig, ReliabilityConfig, ResourceLimitsConfig,
RuntimeConfig, SandboxBackend, SandboxConfig, SchedulerConfig, SecretsConfig, SecurityConfig,
SecurityOpsConfig, SkillCreationConfig, SkillsConfig, SkillsPromptInjectionMode, SlackConfig,
StorageConfig, StorageProviderConfig, StorageProviderSection, StreamMode, SwarmConfig,
SwarmStrategy, TelegramConfig, TextBrowserConfig, ToolFilterGroup, ToolFilterGroupMode,
TranscriptionConfig, TtsConfig, TunnelConfig, VerifiableIntentConfig, WebFetchConfig,
WebSearchConfig, WebhookConfig, WhatsAppChatPolicy, WhatsAppWebMode, WorkspaceConfig,
DEFAULT_GWS_SERVICES,
MemoryPolicyConfig, Microsoft365Config, ModelRouteConfig, MultimodalConfig,
NextcloudTalkConfig, NodeTransportConfig, NodesConfig, NotionConfig, ObservabilityConfig,
OpenAiSttConfig, OpenAiTtsConfig, OpenVpnTunnelConfig, OtpConfig, OtpMethod, PacingConfig,
PeripheralBoardConfig, PeripheralsConfig, PiperTtsConfig, PluginsConfig, ProjectIntelConfig,
ProxyConfig, ProxyScope, QdrantConfig, QueryClassificationConfig, ReliabilityConfig,
ResourceLimitsConfig, RuntimeConfig, SandboxBackend, SandboxConfig, SchedulerConfig,
SecretsConfig, SecurityConfig, SecurityOpsConfig, SkillCreationConfig, SkillsConfig,
SkillsPromptInjectionMode, SlackConfig, StorageConfig, StorageProviderConfig,
StorageProviderSection, StreamMode, SwarmConfig, SwarmStrategy, TelegramConfig,
TextBrowserConfig, ToolFilterGroup, ToolFilterGroupMode, TranscriptionConfig, TtsConfig,
TunnelConfig, VerifiableIntentConfig, WebFetchConfig, WebSearchConfig, WebhookConfig,
WhatsAppChatPolicy, WhatsAppWebMode, WorkspaceConfig, DEFAULT_GWS_SERVICES,
};
pub fn name_and_presence<T: traits::ChannelConfig>(channel: Option<&T>) -> (&'static str, bool) {
+312 -87
View File
@@ -1005,6 +1005,10 @@ fn default_edge_tts_binary_path() -> String {
"edge-tts".into()
}
fn default_piper_tts_api_url() -> String {
"http://127.0.0.1:5000/v1/audio/speech".into()
}
/// Text-to-Speech configuration (`[tts]`).
#[derive(Debug, Clone, Serialize, Deserialize, JsonSchema)]
pub struct TtsConfig {
@@ -1035,6 +1039,9 @@ pub struct TtsConfig {
/// Edge TTS provider configuration (`[tts.edge]`).
#[serde(default)]
pub edge: Option<EdgeTtsConfig>,
/// Piper TTS provider configuration (`[tts.piper]`).
#[serde(default)]
pub piper: Option<PiperTtsConfig>,
}
impl Default for TtsConfig {
@@ -1049,6 +1056,7 @@ impl Default for TtsConfig {
elevenlabs: None,
google: None,
edge: None,
piper: None,
}
}
}
@@ -1103,6 +1111,14 @@ pub struct EdgeTtsConfig {
pub binary_path: String,
}
/// Piper TTS provider configuration (local GPU-accelerated, OpenAI-compatible endpoint).
#[derive(Debug, Clone, Serialize, Deserialize, JsonSchema)]
pub struct PiperTtsConfig {
/// Base URL for the Piper TTS HTTP server (e.g. `"http://127.0.0.1:5000/v1/audio/speech"`).
#[serde(default = "default_piper_tts_api_url")]
pub api_url: String,
}
/// Determines when a `ToolFilterGroup` is active.
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize, JsonSchema, Default)]
#[serde(rename_all = "snake_case")]
@@ -1413,6 +1429,15 @@ pub struct MultimodalConfig {
/// Allow fetching remote image URLs (http/https). Disabled by default.
#[serde(default)]
pub allow_remote_fetch: bool,
/// Provider name to use for vision/image messages (e.g. `"ollama"`).
/// When set, messages containing `[IMAGE:]` markers are routed to this
/// provider instead of the default text provider.
#[serde(default)]
pub vision_provider: Option<String>,
/// Model to use when routing to the vision provider (e.g. `"llava:7b"`).
/// Only used when `vision_provider` is set.
#[serde(default)]
pub vision_model: Option<String>,
}
fn default_multimodal_max_images() -> usize {
@@ -1438,6 +1463,8 @@ impl Default for MultimodalConfig {
max_images: default_multimodal_max_images(),
max_image_size_mb: default_multimodal_max_image_size_mb(),
allow_remote_fetch: false,
vision_provider: None,
vision_model: None,
}
}
}
@@ -3809,77 +3836,6 @@ impl Default for QdrantConfig {
}
}
/// Configuration for the mem0 (OpenMemory) memory backend.
///
/// Connects to a self-hosted OpenMemory server via its REST API.
/// Deploy OpenMemory with `docker compose up` from the mem0 repo,
/// then point `url` at the API (default `http://localhost:8765`).
///
/// ```toml
/// [memory]
/// backend = "mem0"
///
/// [memory.mem0]
/// url = "http://localhost:8765"
/// user_id = "zeroclaw"
/// app_name = "zeroclaw"
/// ```
#[derive(Debug, Clone, Serialize, Deserialize, JsonSchema)]
pub struct Mem0Config {
/// OpenMemory server URL (e.g. `http://localhost:8765`).
/// Falls back to `MEM0_URL` env var if not set.
#[serde(default = "default_mem0_url")]
pub url: String,
/// User ID for scoping memories within mem0.
/// Falls back to `MEM0_USER_ID` env var, or default `"zeroclaw"`.
#[serde(default = "default_mem0_user_id")]
pub user_id: String,
/// Application name registered in mem0.
/// Falls back to `MEM0_APP_NAME` env var, or default `"zeroclaw"`.
#[serde(default = "default_mem0_app_name")]
pub app_name: String,
/// Whether mem0 should use its built-in LLM to extract facts from
/// stored text (`infer = true`) or store raw text as-is (`false`).
#[serde(default = "default_mem0_infer")]
pub infer: bool,
/// Custom prompt for guiding LLM-based fact extraction when `infer = true`.
/// Useful for non-English content (e.g. Cantonese/Chinese).
/// Falls back to `MEM0_EXTRACTION_PROMPT` env var.
/// If unset, the mem0 server uses its built-in default prompt.
#[serde(default = "default_mem0_extraction_prompt")]
pub extraction_prompt: Option<String>,
}
fn default_mem0_url() -> String {
std::env::var("MEM0_URL").unwrap_or_else(|_| "http://localhost:8765".into())
}
fn default_mem0_user_id() -> String {
std::env::var("MEM0_USER_ID").unwrap_or_else(|_| "zeroclaw".into())
}
fn default_mem0_app_name() -> String {
std::env::var("MEM0_APP_NAME").unwrap_or_else(|_| "zeroclaw".into())
}
fn default_mem0_infer() -> bool {
true
}
fn default_mem0_extraction_prompt() -> Option<String> {
std::env::var("MEM0_EXTRACTION_PROMPT")
.ok()
.filter(|s| !s.trim().is_empty())
}
impl Default for Mem0Config {
fn default() -> Self {
Self {
url: default_mem0_url(),
user_id: default_mem0_user_id(),
app_name: default_mem0_app_name(),
infer: default_mem0_infer(),
extraction_prompt: default_mem0_extraction_prompt(),
}
}
}
#[derive(Debug, Clone, Serialize, Deserialize, JsonSchema)]
#[allow(clippy::struct_excessive_bools)]
pub struct MemoryConfig {
@@ -3954,6 +3910,43 @@ pub struct MemoryConfig {
#[serde(default = "default_true")]
pub auto_hydrate: bool,
// ── Retrieval Pipeline ─────────────────────────────────────
/// Retrieval stages to execute in order. Valid: "cache", "fts", "vector".
#[serde(default = "default_retrieval_stages")]
pub retrieval_stages: Vec<String>,
/// Enable LLM reranking when candidate count exceeds threshold.
#[serde(default)]
pub rerank_enabled: bool,
/// Minimum candidate count to trigger reranking.
#[serde(default = "default_rerank_threshold")]
pub rerank_threshold: usize,
/// FTS score above which to early-return without vector search (0.01.0).
#[serde(default = "default_fts_early_return_score")]
pub fts_early_return_score: f64,
// ── Namespace Isolation ─────────────────────────────────────
/// Default namespace for memory entries.
#[serde(default = "default_namespace")]
pub default_namespace: String,
// ── Conflict Resolution ─────────────────────────────────────
/// Cosine similarity threshold for conflict detection (0.01.0).
#[serde(default = "default_conflict_threshold")]
pub conflict_threshold: f64,
// ── Audit Trail ─────────────────────────────────────────────
/// Enable audit logging of memory operations.
#[serde(default)]
pub audit_enabled: bool,
/// Retention period for audit entries in days (default: 30).
#[serde(default = "default_audit_retention_days")]
pub audit_retention_days: u32,
// ── Policy Engine ───────────────────────────────────────────
/// Memory policy configuration.
#[serde(default)]
pub policy: MemoryPolicyConfig,
// ── SQLite backend options ─────────────────────────────────
/// For sqlite backend: max seconds to wait when opening the DB (e.g. file locked).
/// None = wait indefinitely (default). Recommended max: 300.
@@ -3965,13 +3958,42 @@ pub struct MemoryConfig {
/// Only used when `backend = "qdrant"`.
#[serde(default)]
pub qdrant: QdrantConfig,
}
// ── Mem0 backend options ─────────────────────────────────
/// Configuration for mem0 (OpenMemory) backend.
/// Only used when `backend = "mem0"`.
/// Requires `--features memory-mem0` at build time.
/// Memory policy configuration (`[memory.policy]` section).
#[derive(Debug, Clone, Default, Serialize, Deserialize, JsonSchema)]
pub struct MemoryPolicyConfig {
/// Maximum entries per namespace (0 = unlimited).
#[serde(default)]
pub mem0: Mem0Config,
pub max_entries_per_namespace: usize,
/// Maximum entries per category (0 = unlimited).
#[serde(default)]
pub max_entries_per_category: usize,
/// Retention days by category (overrides global). Keys: "core", "daily", "conversation".
#[serde(default)]
pub retention_days_by_category: std::collections::HashMap<String, u32>,
/// Namespaces that are read-only (writes are rejected).
#[serde(default)]
pub read_only_namespaces: Vec<String>,
}
fn default_retrieval_stages() -> Vec<String> {
vec!["cache".into(), "fts".into(), "vector".into()]
}
fn default_rerank_threshold() -> usize {
5
}
fn default_fts_early_return_score() -> f64 {
0.85
}
fn default_namespace() -> String {
"default".into()
}
fn default_conflict_threshold() -> f64 {
0.85
}
fn default_audit_retention_days() -> u32 {
30
}
fn default_embedding_provider() -> String {
@@ -4045,9 +4067,17 @@ impl Default for MemoryConfig {
snapshot_enabled: false,
snapshot_on_hygiene: false,
auto_hydrate: true,
retrieval_stages: default_retrieval_stages(),
rerank_enabled: false,
rerank_threshold: default_rerank_threshold(),
fts_early_return_score: default_fts_early_return_score(),
default_namespace: default_namespace(),
conflict_threshold: default_conflict_threshold(),
audit_enabled: false,
audit_retention_days: default_audit_retention_days(),
policy: MemoryPolicyConfig::default(),
sqlite_open_timeout_secs: None,
qdrant: QdrantConfig::default(),
mem0: Mem0Config::default(),
}
}
}
@@ -4256,6 +4286,7 @@ fn default_auto_approve() -> Vec<String> {
"glob_search".into(),
"content_search".into(),
"image_info".into(),
"weather".into(),
]
}
@@ -4263,6 +4294,19 @@ fn default_always_ask() -> Vec<String> {
vec![]
}
impl AutonomyConfig {
/// Merge the built-in default `auto_approve` entries into the current
/// list, preserving any user-supplied additions.
pub fn ensure_default_auto_approve(&mut self) {
let defaults = default_auto_approve();
for entry in defaults {
if !self.auto_approve.iter().any(|existing| existing == &entry) {
self.auto_approve.push(entry);
}
}
}
}
fn is_valid_env_var_name(name: &str) -> bool {
let mut chars = name.chars();
match chars.next() {
@@ -4642,6 +4686,7 @@ pub struct ClassificationRule {
/// Heartbeat configuration for periodic health pings (`[heartbeat]` section).
#[derive(Debug, Clone, Serialize, Deserialize, JsonSchema)]
#[allow(clippy::struct_excessive_bools)]
pub struct HeartbeatConfig {
/// Enable periodic heartbeat pings. Default: `false`.
pub enabled: bool,
@@ -4688,6 +4733,14 @@ pub struct HeartbeatConfig {
/// Maximum number of heartbeat run history records to retain. Default: `100`.
#[serde(default = "default_heartbeat_max_run_history")]
pub max_run_history: u32,
/// Load the channel session history before each heartbeat task execution so
/// the LLM has conversational context. Default: `false`.
///
/// When `true`, the session file for the configured `target`/`to` is passed
/// to the agent as `session_state_file`, giving it access to the recent
/// conversation history — just as if the user had sent a message.
#[serde(default)]
pub load_session_context: bool,
}
fn default_heartbeat_interval() -> u32 {
@@ -4726,6 +4779,7 @@ impl Default for HeartbeatConfig {
deadman_channel: None,
deadman_to: None,
max_run_history: default_heartbeat_max_run_history(),
load_session_context: false,
}
}
}
@@ -5443,6 +5497,10 @@ pub struct MatrixConfig {
pub room_id: String,
/// Allowed Matrix user IDs. Empty = deny all.
pub allowed_users: Vec<String>,
/// Allowed Matrix room IDs or aliases. Empty = allow all rooms.
/// Supports canonical room IDs (`!abc:server`) and aliases (`#room:server`).
#[serde(default)]
pub allowed_rooms: Vec<String>,
/// Whether to interrupt an in-flight agent response when a new message arrives.
#[serde(default)]
pub interrupt_on_new_message: bool,
@@ -7516,22 +7574,50 @@ impl Config {
.await
.context("Failed to read config file")?;
// Track ignored/unknown config keys to warn users about silent misconfigurations
// (e.g., using [providers.ollama] which doesn't exist instead of top-level api_url)
// Deserialize the config with the standard TOML parser.
//
// Previously this used `serde_ignored::deserialize` for both
// deserialization and unknown-key detection. However,
// `serde_ignored` silently drops field values inside nested
// structs that carry `#[serde(default)]` (e.g. the entire
// `[autonomy]` table), causing user-supplied values to be
// replaced by defaults. See #4171.
//
// We now deserialize with `toml::from_str` (which is correct)
// and run `serde_ignored` separately just for diagnostics.
let mut config: Config =
toml::from_str(&contents).context("Failed to deserialize config file")?;
// Ensure the built-in default auto_approve entries are always
// present. When a user specifies `auto_approve` in their TOML
// (e.g. to add a custom tool), serde replaces the default list
// instead of merging. This caused default-safe tools like
// `weather` or `calculator` to lose their auto-approve status
// and get silently denied in non-interactive channel runs.
// See #4247.
//
// Users who want to require approval for a default tool can
// add it to `always_ask`, which takes precedence over
// `auto_approve` in the approval decision (see approval/mod.rs).
config.autonomy.ensure_default_auto_approve();
// Detect unknown/ignored config keys for diagnostic warnings.
// This second pass uses serde_ignored but discards the parsed
// result — only the ignored-path list is kept.
let mut ignored_paths: Vec<String> = Vec::new();
let mut config: Config = serde_ignored::deserialize(
toml::de::Deserializer::parse(&contents).context("Failed to parse config file")?,
let _: Result<Config, _> = serde_ignored::deserialize(
toml::de::Deserializer::parse(&contents)
.unwrap_or_else(|_| unreachable!("already parsed above")),
|path| {
ignored_paths.push(path.to_string());
},
)
.context("Failed to deserialize config file")?;
);
// Warn about each unknown config key.
// serde_ignored + #[serde(default)] on nested structs can produce
// false positives: parent-level fields get re-reported under the
// nested key (e.g. "memory.mem0.auto_hydrate" even though
// auto_hydrate belongs to MemoryConfig, not Mem0Config). We
// nested key (e.g. "memory.qdrant.auto_hydrate" even though
// auto_hydrate belongs to MemoryConfig, not QdrantConfig). We
// suppress these by checking whether the leaf key is a known field
// on the parent struct.
let known_memory_fields: &[&str] = &[
@@ -7560,7 +7646,7 @@ impl Config {
];
for path in ignored_paths {
// Skip false positives from nested memory sub-sections
if path.starts_with("memory.mem0.") || path.starts_with("memory.qdrant.") {
if path.starts_with("memory.qdrant.") {
let leaf = path.rsplit('.').next().unwrap_or("");
if known_memory_fields.contains(&leaf) {
continue;
@@ -9531,7 +9617,9 @@ mod tests {
merged.push(']');
}
merged.push('\n');
toml::from_str(&merged).unwrap()
let mut config: Config = toml::from_str(&merged).unwrap();
config.autonomy.ensure_default_auto_approve();
config
}
#[test]
@@ -9986,6 +10074,140 @@ default_temperature = 0.7
assert_eq!(parsed.provider_timeout_secs, 120);
}
/// Regression test for #4171: the `[autonomy]` section must not be
/// silently dropped when parsing config TOML.
#[test]
async fn autonomy_section_is_not_silently_ignored() {
let raw = r#"
default_temperature = 0.7
[autonomy]
level = "full"
max_actions_per_hour = 99
auto_approve = ["file_read", "memory_recall", "http_request"]
"#;
let parsed = parse_test_config(raw);
assert_eq!(
parsed.autonomy.level,
AutonomyLevel::Full,
"autonomy.level must be parsed from config (was silently defaulting to Supervised)"
);
assert_eq!(
parsed.autonomy.max_actions_per_hour, 99,
"autonomy.max_actions_per_hour must be parsed from config"
);
assert!(
parsed
.autonomy
.auto_approve
.contains(&"http_request".to_string()),
"autonomy.auto_approve must include http_request from config"
);
}
/// Regression test for #4247: when a user provides a custom auto_approve
/// list, the built-in defaults must still be present.
#[test]
async fn auto_approve_merges_user_entries_with_defaults() {
let raw = r#"
default_temperature = 0.7
[autonomy]
auto_approve = ["my_custom_tool", "another_tool"]
"#;
let parsed = parse_test_config(raw);
// User entries are preserved
assert!(
parsed
.autonomy
.auto_approve
.contains(&"my_custom_tool".to_string()),
"user-supplied tool must remain in auto_approve"
);
assert!(
parsed
.autonomy
.auto_approve
.contains(&"another_tool".to_string()),
"user-supplied tool must remain in auto_approve"
);
// Defaults are merged in
for default_tool in &[
"file_read",
"memory_recall",
"weather",
"calculator",
"web_fetch",
] {
assert!(
parsed.autonomy.auto_approve.contains(&default_tool.to_string()),
"default tool '{default_tool}' must be present in auto_approve even when user provides custom list"
);
}
}
/// Regression test: empty auto_approve still gets defaults merged.
#[test]
async fn auto_approve_empty_list_gets_defaults() {
let raw = r#"
default_temperature = 0.7
[autonomy]
auto_approve = []
"#;
let parsed = parse_test_config(raw);
let defaults = default_auto_approve();
for tool in &defaults {
assert!(
parsed.autonomy.auto_approve.contains(tool),
"default tool '{tool}' must be present even when user sets auto_approve = []"
);
}
}
/// When no autonomy section is provided, defaults are applied normally.
#[test]
async fn auto_approve_defaults_when_no_autonomy_section() {
let raw = r#"
default_temperature = 0.7
"#;
let parsed = parse_test_config(raw);
let defaults = default_auto_approve();
for tool in &defaults {
assert!(
parsed.autonomy.auto_approve.contains(tool),
"default tool '{tool}' must be present when no [autonomy] section"
);
}
}
/// Duplicates are not introduced when ensure_default_auto_approve runs
/// on a list that already contains the defaults.
#[test]
async fn auto_approve_no_duplicates() {
let raw = r#"
default_temperature = 0.7
[autonomy]
auto_approve = ["weather", "file_read"]
"#;
let parsed = parse_test_config(raw);
let weather_count = parsed
.autonomy
.auto_approve
.iter()
.filter(|t| *t == "weather")
.count();
assert_eq!(weather_count, 1, "weather must not be duplicated");
let file_read_count = parsed
.autonomy
.auto_approve
.iter()
.filter(|t| *t == "file_read")
.count();
assert_eq!(file_read_count, 1, "file_read must not be duplicated");
}
#[test]
async fn provider_timeout_secs_parses_from_toml() {
let raw = r#"
@@ -10597,6 +10819,7 @@ default_temperature = 0.7
device_id: Some("DEVICE123".into()),
room_id: "!room123:matrix.org".into(),
allowed_users: vec!["@user:matrix.org".into()],
allowed_rooms: vec![],
interrupt_on_new_message: false,
};
let json = serde_json::to_string(&mc).unwrap();
@@ -10618,6 +10841,7 @@ default_temperature = 0.7
device_id: None,
room_id: "!abc:synapse.local".into(),
allowed_users: vec!["@admin:synapse.local".into(), "*".into()],
allowed_rooms: vec![],
interrupt_on_new_message: false,
};
let toml_str = toml::to_string(&mc).unwrap();
@@ -10711,6 +10935,7 @@ allowed_users = ["@ops:matrix.org"]
device_id: None,
room_id: "!r:m".into(),
allowed_users: vec!["@u:m".into()],
allowed_rooms: vec![],
interrupt_on_new_message: false,
}),
signal: None,
+193 -1
View File
@@ -362,10 +362,22 @@ async fn run_heartbeat_worker(config: Config) -> Result<()> {
};
// ── Phase 2: Execute selected tasks ─────────────────────
// Re-read session context on every tick so we pick up messages
// that arrived since the daemon started.
let session_context = if config.heartbeat.load_session_context {
load_heartbeat_session_context(&config)
} else {
None
};
let mut tick_had_error = false;
for task in &tasks_to_run {
let task_start = std::time::Instant::now();
let prompt = format!("[Heartbeat Task | {}] {}", task.priority, task.text);
let task_prompt = format!("[Heartbeat Task | {}] {}", task.priority, task.text);
let prompt = match &session_context {
Some(ctx) => format!("{ctx}\n\n{task_prompt}"),
None => task_prompt,
};
let temp = config.default_temperature;
match Box::pin(crate::agent::run(
config.clone(),
@@ -497,6 +509,186 @@ fn resolve_heartbeat_delivery(config: &Config) -> Result<Option<(String, String)
}
}
/// Load recent conversation history for the heartbeat's delivery target and
/// format it as a text preamble to inject into the task prompt.
///
/// Scans `{workspace}/sessions/` for JSONL files whose name starts with
/// `{channel}_` and ends with `_{to}.jsonl` (or exactly `{channel}_{to}.jsonl`),
/// then picks the most recently modified match. This handles session key
/// formats such as `telegram_diskiller.jsonl` and
/// `telegram_5673725398_diskiller.jsonl`.
/// Returns `None` when `target`/`to` are not configured or no session exists.
const HEARTBEAT_SESSION_CONTEXT_MESSAGES: usize = 20;
fn load_heartbeat_session_context(config: &Config) -> Option<String> {
use crate::providers::traits::ChatMessage;
let channel = config
.heartbeat
.target
.as_deref()
.map(str::trim)
.filter(|v| !v.is_empty())?;
let to = config
.heartbeat
.to
.as_deref()
.map(str::trim)
.filter(|v| !v.is_empty())?;
if channel.contains('/') || channel.contains('\\') || to.contains('/') || to.contains('\\') {
tracing::warn!("heartbeat session context: channel/to contains path separators, skipping");
return None;
}
let sessions_dir = config.workspace_dir.join("sessions");
// Find the most recently modified JSONL file that belongs to this target.
// Matches both `{channel}_{to}.jsonl` and `{channel}_{anything}_{to}.jsonl`.
let prefix = format!("{channel}_");
let suffix = format!("_{to}.jsonl");
let exact = format!("{channel}_{to}.jsonl");
let mid_prefix = format!("{channel}_{to}_");
let path = std::fs::read_dir(&sessions_dir)
.ok()?
.filter_map(|e| e.ok())
.filter(|e| {
let name = e.file_name();
let name = name.to_string_lossy();
name.ends_with(".jsonl")
&& (name == exact
|| (name.starts_with(&prefix) && name.ends_with(&suffix))
|| name.starts_with(&mid_prefix))
})
.max_by_key(|e| {
e.metadata()
.and_then(|m| m.modified())
.unwrap_or(std::time::SystemTime::UNIX_EPOCH)
})
.map(|e| e.path())?;
if !path.exists() {
tracing::debug!("💓 Heartbeat session context: no session file found for {channel}/{to}");
return None;
}
let messages = load_jsonl_messages(&path);
if messages.is_empty() {
return None;
}
let recent: Vec<&ChatMessage> = messages
.iter()
.filter(|m| m.role == "user" || m.role == "assistant")
.rev()
.take(HEARTBEAT_SESSION_CONTEXT_MESSAGES)
.collect::<Vec<_>>()
.into_iter()
.rev()
.collect();
// Only inject context if there is at least one real user message in the
// window. If the JSONL contains only assistant messages (e.g. previous
// heartbeat outputs with no reply yet), skip context to avoid feeding
// Monika's own messages back to her in a loop.
let has_user_message = recent.iter().any(|m| m.role == "user");
if !has_user_message {
tracing::debug!(
"💓 Heartbeat session context: no user messages in recent history — skipping"
);
return None;
}
// Use the session file's mtime as a proxy for when the last message arrived.
let last_message_age = std::fs::metadata(&path)
.ok()
.and_then(|m| m.modified().ok())
.and_then(|mtime| mtime.elapsed().ok());
let silence_note = match last_message_age {
Some(age) => {
let mins = age.as_secs() / 60;
if mins < 60 {
format!("(last message ~{mins} minutes ago)\n")
} else {
let hours = mins / 60;
let rem = mins % 60;
if rem == 0 {
format!("(last message ~{hours}h ago)\n")
} else {
format!("(last message ~{hours}h {rem}m ago)\n")
}
}
}
None => String::new(),
};
tracing::debug!(
"💓 Heartbeat session context: {} messages from {}, silence: {}",
recent.len(),
path.display(),
silence_note.trim(),
);
let mut ctx = format!(
"[Recent conversation history — use this for context when composing your message] {silence_note}",
);
for msg in &recent {
let label = if msg.role == "user" { "User" } else { "You" };
// Truncate very long messages to avoid bloating the prompt.
// Use char_indices to avoid panicking on multi-byte UTF-8 characters.
let content = if msg.content.len() > 500 {
let truncate_at = msg
.content
.char_indices()
.map(|(i, _)| i)
.take_while(|&i| i <= 500)
.last()
.unwrap_or(0);
format!("{}", &msg.content[..truncate_at])
} else {
msg.content.clone()
};
ctx.push_str(label);
ctx.push_str(": ");
ctx.push_str(&content);
ctx.push('\n');
}
Some(ctx)
}
/// Read the last `HEARTBEAT_SESSION_CONTEXT_MESSAGES` `ChatMessage` lines from
/// a JSONL session file using a bounded rolling window so we never hold the
/// entire file in memory.
fn load_jsonl_messages(path: &std::path::Path) -> Vec<crate::providers::traits::ChatMessage> {
use std::collections::VecDeque;
use std::io::BufRead;
let file = match std::fs::File::open(path) {
Ok(f) => f,
Err(_) => return Vec::new(),
};
let reader = std::io::BufReader::new(file);
let mut window: VecDeque<crate::providers::traits::ChatMessage> =
VecDeque::with_capacity(HEARTBEAT_SESSION_CONTEXT_MESSAGES + 1);
for line in reader.lines() {
let Ok(line) = line else { continue };
let trimmed = line.trim();
if trimmed.is_empty() {
continue;
}
if let Ok(msg) = serde_json::from_str::<crate::providers::traits::ChatMessage>(trimmed) {
window.push_back(msg);
if window.len() > HEARTBEAT_SESSION_CONTEXT_MESSAGES {
window.pop_front();
}
}
}
window.into_iter().collect()
}
/// Auto-detect the best channel for heartbeat delivery by checking which
/// channels are configured. Returns the first match in priority order.
fn auto_detect_heartbeat_channel(config: &Config) -> Option<(String, String)> {
+1
View File
@@ -891,6 +891,7 @@ mod tests {
device_id: None,
room_id: "!r:m".into(),
allowed_users: vec![],
allowed_rooms: vec![],
interrupt_on_new_message: false,
});
let entries = all_integrations();
+293
View File
@@ -0,0 +1,293 @@
//! Audit trail for memory operations.
//!
//! Provides a decorator `AuditedMemory<M>` that wraps any `Memory` backend
//! and logs all operations to a `memory_audit` table. Opt-in via
//! `[memory] audit_enabled = true`.
use super::traits::{Memory, MemoryCategory, MemoryEntry, ProceduralMessage};
use async_trait::async_trait;
use chrono::Local;
use parking_lot::Mutex;
use rusqlite::{params, Connection};
use std::path::{Path, PathBuf};
use std::sync::Arc;
/// Audit log entry operations.
#[derive(Debug, Clone, Copy)]
pub enum AuditOp {
Store,
Recall,
Get,
List,
Forget,
StoreProcedural,
}
impl std::fmt::Display for AuditOp {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
match self {
Self::Store => write!(f, "store"),
Self::Recall => write!(f, "recall"),
Self::Get => write!(f, "get"),
Self::List => write!(f, "list"),
Self::Forget => write!(f, "forget"),
Self::StoreProcedural => write!(f, "store_procedural"),
}
}
}
/// Decorator that wraps a `Memory` backend with audit logging.
pub struct AuditedMemory<M: Memory> {
inner: M,
audit_conn: Arc<Mutex<Connection>>,
#[allow(dead_code)]
db_path: PathBuf,
}
impl<M: Memory> AuditedMemory<M> {
pub fn new(inner: M, workspace_dir: &Path) -> anyhow::Result<Self> {
let db_path = workspace_dir.join("memory").join("audit.db");
if let Some(parent) = db_path.parent() {
std::fs::create_dir_all(parent)?;
}
let conn = Connection::open(&db_path)?;
conn.execute_batch(
"PRAGMA journal_mode = WAL;
PRAGMA synchronous = NORMAL;
CREATE TABLE IF NOT EXISTS memory_audit (
id INTEGER PRIMARY KEY AUTOINCREMENT,
operation TEXT NOT NULL,
key TEXT,
namespace TEXT,
session_id TEXT,
timestamp TEXT NOT NULL,
metadata TEXT
);
CREATE INDEX IF NOT EXISTS idx_audit_timestamp ON memory_audit(timestamp);
CREATE INDEX IF NOT EXISTS idx_audit_operation ON memory_audit(operation);",
)?;
Ok(Self {
inner,
audit_conn: Arc::new(Mutex::new(conn)),
db_path,
})
}
fn log_audit(
&self,
op: AuditOp,
key: Option<&str>,
namespace: Option<&str>,
session_id: Option<&str>,
metadata: Option<&str>,
) {
let conn = self.audit_conn.lock();
let now = Local::now().to_rfc3339();
let op_str = op.to_string();
let _ = conn.execute(
"INSERT INTO memory_audit (operation, key, namespace, session_id, timestamp, metadata)
VALUES (?1, ?2, ?3, ?4, ?5, ?6)",
params![op_str, key, namespace, session_id, now, metadata],
);
}
/// Prune audit entries older than the given number of days.
pub fn prune_older_than(&self, retention_days: u32) -> anyhow::Result<u64> {
let conn = self.audit_conn.lock();
let cutoff =
(Local::now() - chrono::Duration::days(i64::from(retention_days))).to_rfc3339();
let affected = conn.execute(
"DELETE FROM memory_audit WHERE timestamp < ?1",
params![cutoff],
)?;
Ok(u64::try_from(affected).unwrap_or(0))
}
/// Count total audit entries.
pub fn audit_count(&self) -> anyhow::Result<usize> {
let conn = self.audit_conn.lock();
let count: i64 =
conn.query_row("SELECT COUNT(*) FROM memory_audit", [], |row| row.get(0))?;
#[allow(clippy::cast_sign_loss, clippy::cast_possible_truncation)]
Ok(count as usize)
}
}
#[async_trait]
impl<M: Memory> Memory for AuditedMemory<M> {
fn name(&self) -> &str {
self.inner.name()
}
async fn store(
&self,
key: &str,
content: &str,
category: MemoryCategory,
session_id: Option<&str>,
) -> anyhow::Result<()> {
self.log_audit(AuditOp::Store, Some(key), None, session_id, None);
self.inner.store(key, content, category, session_id).await
}
async fn recall(
&self,
query: &str,
limit: usize,
session_id: Option<&str>,
since: Option<&str>,
until: Option<&str>,
) -> anyhow::Result<Vec<MemoryEntry>> {
self.log_audit(
AuditOp::Recall,
None,
None,
session_id,
Some(&format!("query={query}")),
);
self.inner
.recall(query, limit, session_id, since, until)
.await
}
async fn get(&self, key: &str) -> anyhow::Result<Option<MemoryEntry>> {
self.log_audit(AuditOp::Get, Some(key), None, None, None);
self.inner.get(key).await
}
async fn list(
&self,
category: Option<&MemoryCategory>,
session_id: Option<&str>,
) -> anyhow::Result<Vec<MemoryEntry>> {
self.log_audit(AuditOp::List, None, None, session_id, None);
self.inner.list(category, session_id).await
}
async fn forget(&self, key: &str) -> anyhow::Result<bool> {
self.log_audit(AuditOp::Forget, Some(key), None, None, None);
self.inner.forget(key).await
}
async fn count(&self) -> anyhow::Result<usize> {
self.inner.count().await
}
async fn health_check(&self) -> bool {
self.inner.health_check().await
}
async fn store_procedural(
&self,
messages: &[ProceduralMessage],
session_id: Option<&str>,
) -> anyhow::Result<()> {
self.log_audit(
AuditOp::StoreProcedural,
None,
None,
session_id,
Some(&format!("messages={}", messages.len())),
);
self.inner.store_procedural(messages, session_id).await
}
async fn recall_namespaced(
&self,
namespace: &str,
query: &str,
limit: usize,
session_id: Option<&str>,
since: Option<&str>,
until: Option<&str>,
) -> anyhow::Result<Vec<MemoryEntry>> {
self.log_audit(
AuditOp::Recall,
None,
Some(namespace),
session_id,
Some(&format!("query={query}")),
);
self.inner
.recall_namespaced(namespace, query, limit, session_id, since, until)
.await
}
async fn store_with_metadata(
&self,
key: &str,
content: &str,
category: MemoryCategory,
session_id: Option<&str>,
namespace: Option<&str>,
importance: Option<f64>,
) -> anyhow::Result<()> {
self.log_audit(AuditOp::Store, Some(key), namespace, session_id, None);
self.inner
.store_with_metadata(key, content, category, session_id, namespace, importance)
.await
}
}
#[cfg(test)]
mod tests {
use super::*;
use crate::memory::NoneMemory;
use tempfile::TempDir;
#[tokio::test]
async fn audited_memory_logs_store_operation() {
let tmp = TempDir::new().unwrap();
let inner = NoneMemory::new();
let audited = AuditedMemory::new(inner, tmp.path()).unwrap();
audited
.store("test_key", "test_value", MemoryCategory::Core, None)
.await
.unwrap();
assert_eq!(audited.audit_count().unwrap(), 1);
}
#[tokio::test]
async fn audited_memory_logs_recall_operation() {
let tmp = TempDir::new().unwrap();
let inner = NoneMemory::new();
let audited = AuditedMemory::new(inner, tmp.path()).unwrap();
let _ = audited.recall("query", 10, None, None, None).await;
assert_eq!(audited.audit_count().unwrap(), 1);
}
#[tokio::test]
async fn audited_memory_prune_works() {
let tmp = TempDir::new().unwrap();
let inner = NoneMemory::new();
let audited = AuditedMemory::new(inner, tmp.path()).unwrap();
audited
.store("k1", "v1", MemoryCategory::Core, None)
.await
.unwrap();
// Pruning with 0 days should remove entries
let pruned = audited.prune_older_than(0).unwrap();
// Entry was just created, so 0-day retention should remove it
// Pruning should succeed (pruned is usize, always >= 0)
let _ = pruned;
}
#[tokio::test]
async fn audited_memory_delegates_correctly() {
let tmp = TempDir::new().unwrap();
let inner = NoneMemory::new();
let audited = AuditedMemory::new(inner, tmp.path()).unwrap();
assert_eq!(audited.name(), "none");
assert!(audited.health_check().await);
assert_eq!(audited.count().await.unwrap(), 0);
}
}
-12
View File
@@ -4,7 +4,6 @@ pub enum MemoryBackendKind {
Lucid,
Postgres,
Qdrant,
Mem0,
Markdown,
None,
Unknown,
@@ -66,15 +65,6 @@ const QDRANT_PROFILE: MemoryBackendProfile = MemoryBackendProfile {
optional_dependency: false,
};
const MEM0_PROFILE: MemoryBackendProfile = MemoryBackendProfile {
key: "mem0",
label: "Mem0 (OpenMemory) — semantic memory with LLM fact extraction via [memory.mem0]",
auto_save_default: true,
uses_sqlite_hygiene: false,
sqlite_based: false,
optional_dependency: true,
};
const NONE_PROFILE: MemoryBackendProfile = MemoryBackendProfile {
key: "none",
label: "None — disable persistent memory",
@@ -114,7 +104,6 @@ pub fn classify_memory_backend(backend: &str) -> MemoryBackendKind {
"lucid" => MemoryBackendKind::Lucid,
"postgres" => MemoryBackendKind::Postgres,
"qdrant" => MemoryBackendKind::Qdrant,
"mem0" | "openmemory" => MemoryBackendKind::Mem0,
"markdown" => MemoryBackendKind::Markdown,
"none" => MemoryBackendKind::None,
_ => MemoryBackendKind::Unknown,
@@ -127,7 +116,6 @@ pub fn memory_backend_profile(backend: &str) -> MemoryBackendProfile {
MemoryBackendKind::Lucid => LUCID_PROFILE,
MemoryBackendKind::Postgres => POSTGRES_PROFILE,
MemoryBackendKind::Qdrant => QDRANT_PROFILE,
MemoryBackendKind::Mem0 => MEM0_PROFILE,
MemoryBackendKind::Markdown => MARKDOWN_PROFILE,
MemoryBackendKind::None => NONE_PROFILE,
MemoryBackendKind::Unknown => CUSTOM_PROFILE,
File diff suppressed because it is too large Load Diff
+173
View File
@@ -0,0 +1,173 @@
//! Conflict resolution for memory entries.
//!
//! Before storing Core memories, performs a semantic similarity check against
//! existing entries. If cosine similarity exceeds a threshold but content
//! differs, the old entry is marked as superseded.
use super::traits::{Memory, MemoryCategory, MemoryEntry};
/// Check for conflicting memories and mark old ones as superseded.
///
/// Returns the list of entry IDs that were superseded.
pub async fn check_and_resolve_conflicts(
memory: &dyn Memory,
key: &str,
content: &str,
category: &MemoryCategory,
threshold: f64,
) -> anyhow::Result<Vec<String>> {
// Only check conflicts for Core memories
if !matches!(category, MemoryCategory::Core) {
return Ok(Vec::new());
}
// Search for similar existing entries
let candidates = memory.recall(content, 10, None, None, None).await?;
let mut superseded = Vec::new();
for candidate in &candidates {
if candidate.key == key {
continue; // Same key = update, not conflict
}
if !matches!(candidate.category, MemoryCategory::Core) {
continue;
}
if let Some(score) = candidate.score {
if score > threshold && candidate.content != content {
superseded.push(candidate.id.clone());
}
}
}
Ok(superseded)
}
/// Mark entries as superseded in SQLite by setting their `superseded_by` column.
pub fn mark_superseded(
conn: &rusqlite::Connection,
superseded_ids: &[String],
new_id: &str,
) -> anyhow::Result<()> {
if superseded_ids.is_empty() {
return Ok(());
}
for id in superseded_ids {
conn.execute(
"UPDATE memories SET superseded_by = ?1 WHERE id = ?2",
rusqlite::params![new_id, id],
)?;
}
Ok(())
}
/// Simple text-based conflict detection without embeddings.
///
/// Uses token overlap (Jaccard similarity) as a fast approximation
/// when vector embeddings are unavailable.
pub fn jaccard_similarity(a: &str, b: &str) -> f64 {
let words_a: std::collections::HashSet<&str> = a.split_whitespace().collect();
let words_b: std::collections::HashSet<&str> = b.split_whitespace().collect();
if words_a.is_empty() && words_b.is_empty() {
return 1.0;
}
if words_a.is_empty() || words_b.is_empty() {
return 0.0;
}
let intersection = words_a.intersection(&words_b).count();
let union = words_a.union(&words_b).count();
if union == 0 {
0.0
} else {
intersection as f64 / union as f64
}
}
/// Find potentially conflicting entries using text similarity when embeddings
/// are not available. Returns entries above the threshold.
pub fn find_text_conflicts(
entries: &[MemoryEntry],
new_content: &str,
threshold: f64,
) -> Vec<String> {
entries
.iter()
.filter(|e| {
matches!(e.category, MemoryCategory::Core)
&& e.superseded_by.is_none()
&& jaccard_similarity(&e.content, new_content) > threshold
&& e.content != new_content
})
.map(|e| e.id.clone())
.collect()
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn jaccard_identical_strings() {
let sim = jaccard_similarity("hello world", "hello world");
assert!((sim - 1.0).abs() < f64::EPSILON);
}
#[test]
fn jaccard_disjoint_strings() {
let sim = jaccard_similarity("hello world", "foo bar");
assert!(sim.abs() < f64::EPSILON);
}
#[test]
fn jaccard_partial_overlap() {
let sim = jaccard_similarity("the quick brown fox", "the slow brown dog");
// overlap: "the", "brown" = 2; union: "the", "quick", "brown", "fox", "slow", "dog" = 6
assert!((sim - 2.0 / 6.0).abs() < 0.01);
}
#[test]
fn jaccard_empty_strings() {
assert!((jaccard_similarity("", "") - 1.0).abs() < f64::EPSILON);
assert!(jaccard_similarity("hello", "").abs() < f64::EPSILON);
assert!(jaccard_similarity("", "hello").abs() < f64::EPSILON);
}
#[test]
fn find_text_conflicts_filters_correctly() {
let entries = vec![
MemoryEntry {
id: "1".into(),
key: "pref".into(),
content: "User prefers Rust for systems work".into(),
category: MemoryCategory::Core,
timestamp: "now".into(),
session_id: None,
score: None,
namespace: "default".into(),
importance: Some(0.7),
superseded_by: None,
},
MemoryEntry {
id: "2".into(),
key: "daily1".into(),
content: "User prefers Rust for systems work".into(),
category: MemoryCategory::Daily,
timestamp: "now".into(),
session_id: None,
score: None,
namespace: "default".into(),
importance: Some(0.3),
superseded_by: None,
},
];
// Only Core entries should be flagged
let conflicts = find_text_conflicts(&entries, "User now prefers Go for systems work", 0.3);
assert_eq!(conflicts.len(), 1);
assert_eq!(conflicts[0], "1");
}
}
+28 -1
View File
@@ -8,6 +8,8 @@
//! This two-phase approach replaces the naive raw-message auto-save with
//! semantic extraction, similar to Nanobot's `save_memory` tool call pattern.
use crate::memory::conflict;
use crate::memory::importance;
use crate::memory::traits::{Memory, MemoryCategory};
use crate::providers::traits::Provider;
@@ -78,8 +80,33 @@ pub async fn consolidate_turn(
if let Some(ref update) = result.memory_update {
if !update.trim().is_empty() {
let mem_key = format!("core_{}", uuid::Uuid::new_v4());
// Compute importance score heuristically.
let imp = importance::compute_importance(update, &MemoryCategory::Core);
// Check for conflicts with existing Core memories.
if let Err(e) = conflict::check_and_resolve_conflicts(
memory,
&mem_key,
update,
&MemoryCategory::Core,
0.85,
)
.await
{
tracing::debug!("conflict check skipped: {e}");
}
// Store with importance metadata.
memory
.store(&mem_key, update, MemoryCategory::Core, None)
.store_with_metadata(
&mem_key,
update,
MemoryCategory::Core,
None,
None,
Some(imp),
)
.await?;
}
}
+42 -4
View File
@@ -1,4 +1,5 @@
use crate::config::MemoryConfig;
use crate::memory::policy::PolicyEnforcer;
use anyhow::Result;
use chrono::{DateTime, Duration, Local, NaiveDate, Utc};
use rusqlite::{params, Connection};
@@ -47,6 +48,13 @@ pub fn run_if_due(config: &MemoryConfig, workspace_dir: &Path) -> Result<()> {
return Ok(());
}
// Use policy engine for per-category retention overrides.
let enforcer = PolicyEnforcer::new(&config.policy);
let conversation_retention = enforcer.retention_days_for_category(
&crate::memory::traits::MemoryCategory::Conversation,
config.conversation_retention_days,
);
let report = HygieneReport {
archived_memory_files: archive_daily_memory_files(
workspace_dir,
@@ -55,12 +63,16 @@ pub fn run_if_due(config: &MemoryConfig, workspace_dir: &Path) -> Result<()> {
archived_session_files: archive_session_files(workspace_dir, config.archive_after_days)?,
purged_memory_archives: purge_memory_archives(workspace_dir, config.purge_after_days)?,
purged_session_archives: purge_session_archives(workspace_dir, config.purge_after_days)?,
pruned_conversation_rows: prune_conversation_rows(
workspace_dir,
config.conversation_retention_days,
)?,
pruned_conversation_rows: prune_conversation_rows(workspace_dir, conversation_retention)?,
};
// Prune audit entries if audit is enabled.
if config.audit_enabled {
if let Err(e) = prune_audit_entries(workspace_dir, config.audit_retention_days) {
tracing::debug!("audit pruning skipped: {e}");
}
}
write_state(workspace_dir, &report)?;
if report.total_actions() > 0 {
@@ -318,6 +330,32 @@ fn prune_conversation_rows(workspace_dir: &Path, retention_days: u32) -> Result<
Ok(u64::try_from(affected).unwrap_or(0))
}
fn prune_audit_entries(workspace_dir: &Path, retention_days: u32) -> Result<()> {
if retention_days == 0 {
return Ok(());
}
let db_path = workspace_dir.join("memory").join("audit.db");
if !db_path.exists() {
return Ok(());
}
let conn = Connection::open(db_path)?;
conn.execute_batch("PRAGMA journal_mode = WAL; PRAGMA synchronous = NORMAL;")?;
let cutoff = (Local::now() - Duration::days(i64::from(retention_days))).to_rfc3339();
let affected = conn.execute(
"DELETE FROM memory_audit WHERE timestamp < ?1",
params![cutoff],
)?;
if affected > 0 {
tracing::debug!("pruned {affected} audit entries older than {retention_days} days");
}
Ok(())
}
fn memory_date_from_filename(filename: &str) -> Option<NaiveDate> {
let stem = filename.strip_suffix(".md")?;
let date_part = stem.split('_').next().unwrap_or(stem);
+107
View File
@@ -0,0 +1,107 @@
//! Heuristic importance scorer for non-LLM paths.
//!
//! Assigns importance scores (0.01.0) based on memory category and keyword
//! signals. Used when LLM-based consolidation is unavailable or as a fast
//! first-pass scorer.
use super::traits::MemoryCategory;
/// Base importance by category.
fn category_base_score(category: &MemoryCategory) -> f64 {
match category {
MemoryCategory::Core => 0.7,
MemoryCategory::Daily => 0.3,
MemoryCategory::Conversation => 0.2,
MemoryCategory::Custom(_) => 0.4,
}
}
/// Keyword boost: if the content contains high-signal keywords, bump importance.
fn keyword_boost(content: &str) -> f64 {
const HIGH_SIGNAL_KEYWORDS: &[&str] = &[
"decision",
"always",
"never",
"important",
"critical",
"must",
"requirement",
"policy",
"rule",
"principle",
];
let lowered = content.to_ascii_lowercase();
let matches = HIGH_SIGNAL_KEYWORDS
.iter()
.filter(|kw| lowered.contains(**kw))
.count();
// Cap at +0.2
(matches as f64 * 0.1).min(0.2)
}
/// Compute heuristic importance score for a memory entry.
pub fn compute_importance(content: &str, category: &MemoryCategory) -> f64 {
let base = category_base_score(category);
let boost = keyword_boost(content);
(base + boost).min(1.0)
}
/// Compute final retrieval score incorporating importance and recency.
///
/// `hybrid_score`: raw retrieval score from FTS/vector (0.01.0)
/// `importance`: importance score (0.01.0)
/// `recency_decay`: recency factor (0.01.0, 1.0 = very recent)
pub fn weighted_final_score(hybrid_score: f64, importance: f64, recency_decay: f64) -> f64 {
hybrid_score * 0.7 + importance * 0.2 + recency_decay * 0.1
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn core_category_has_high_base_score() {
let score = compute_importance("some fact", &MemoryCategory::Core);
assert!((score - 0.7).abs() < f64::EPSILON);
}
#[test]
fn conversation_category_has_low_base_score() {
let score = compute_importance("chat message", &MemoryCategory::Conversation);
assert!((score - 0.2).abs() < f64::EPSILON);
}
#[test]
fn keywords_boost_importance() {
let score = compute_importance(
"This is a critical decision that must always be followed",
&MemoryCategory::Core,
);
// base 0.7 + boost for "critical", "decision", "must", "always" = 0.7 + 0.2 (capped) = 0.9
assert!(score > 0.85);
}
#[test]
fn boost_capped_at_point_two() {
let score = compute_importance(
"important critical decision rule policy must always never requirement principle",
&MemoryCategory::Conversation,
);
// base 0.2 + max boost 0.2 = 0.4
assert!((score - 0.4).abs() < f64::EPSILON);
}
#[test]
fn weighted_final_score_formula() {
let score = weighted_final_score(1.0, 1.0, 1.0);
assert!((score - 1.0).abs() < f64::EPSILON);
let score = weighted_final_score(0.0, 0.0, 0.0);
assert!(score.abs() < f64::EPSILON);
let score = weighted_final_score(0.5, 0.5, 0.5);
assert!((score - 0.5).abs() < f64::EPSILON);
}
}
+3
View File
@@ -226,6 +226,9 @@ impl LucidMemory {
timestamp: now.clone(),
session_id: None,
score: Some((1.0 - rank as f64 * 0.05).max(0.1)),
namespace: "default".into(),
importance: None,
superseded_by: None,
});
}
+3
View File
@@ -91,6 +91,9 @@ impl MarkdownMemory {
timestamp: filename.to_string(),
session_id: None,
score: None,
namespace: "default".into(),
importance: None,
superseded_by: None,
}
})
.collect()
-635
View File
@@ -1,635 +0,0 @@
//! Mem0 (OpenMemory) memory backend.
//!
//! Connects to a self-hosted OpenMemory server via its REST API
//! and implements the [`Memory`] trait for seamless integration with
//! ZeroClaw's auto-save, auto-recall, and hygiene lifecycle.
//!
//! Deploy OpenMemory: `docker compose up` from the mem0 repo.
//! Default endpoint: `http://localhost:8765`.
use super::traits::{Memory, MemoryCategory, MemoryEntry, ProceduralMessage};
use crate::config::schema::Mem0Config;
use async_trait::async_trait;
use reqwest::Client;
use serde::{Deserialize, Serialize};
/// Memory backend backed by a mem0 (OpenMemory) REST API.
pub struct Mem0Memory {
client: Client,
base_url: String,
user_id: String,
app_name: String,
infer: bool,
extraction_prompt: Option<String>,
}
// ── mem0 API request/response types ────────────────────────────────
#[derive(Serialize)]
struct AddMemoryRequest<'a> {
user_id: &'a str,
text: &'a str,
#[serde(skip_serializing_if = "Option::is_none")]
metadata: Option<Mem0Metadata<'a>>,
infer: bool,
#[serde(skip_serializing_if = "Option::is_none")]
app: Option<&'a str>,
#[serde(skip_serializing_if = "Option::is_none")]
custom_instructions: Option<&'a str>,
}
#[derive(Serialize)]
struct Mem0Metadata<'a> {
key: &'a str,
category: &'a str,
#[serde(skip_serializing_if = "Option::is_none")]
session_id: Option<&'a str>,
}
#[derive(Serialize)]
struct AddProceduralRequest<'a> {
user_id: &'a str,
messages: &'a [ProceduralMessage],
#[serde(skip_serializing_if = "Option::is_none")]
metadata: Option<serde_json::Value>,
}
#[derive(Serialize)]
struct DeleteMemoriesRequest<'a> {
memory_ids: Vec<&'a str>,
user_id: &'a str,
}
#[derive(Deserialize)]
struct Mem0MemoryItem {
id: String,
#[serde(alias = "content", alias = "text", default)]
memory: String,
#[serde(default)]
created_at: Option<serde_json::Value>,
#[serde(default, rename = "metadata_")]
metadata: Option<Mem0ResponseMetadata>,
#[serde(alias = "relevance_score", default)]
score: Option<f64>,
}
#[derive(Deserialize, Default)]
struct Mem0ResponseMetadata {
#[serde(default)]
key: Option<String>,
#[serde(default)]
category: Option<String>,
#[serde(default)]
session_id: Option<String>,
}
#[derive(Deserialize)]
struct Mem0ListResponse {
#[serde(default)]
items: Vec<Mem0MemoryItem>,
#[serde(default)]
total: usize,
}
// ── Implementation ─────────────────────────────────────────────────
impl Mem0Memory {
/// Create a new mem0 memory backend from config.
pub fn new(config: &Mem0Config) -> anyhow::Result<Self> {
let base_url = config.url.trim_end_matches('/').to_string();
if base_url.is_empty() {
anyhow::bail!("mem0 URL is empty; set [memory.mem0] url or MEM0_URL env var");
}
let client = Client::builder()
.timeout(std::time::Duration::from_secs(30))
.build()?;
Ok(Self {
client,
base_url,
user_id: config.user_id.clone(),
app_name: config.app_name.clone(),
infer: config.infer,
extraction_prompt: config.extraction_prompt.clone(),
})
}
fn api_url(&self, path: &str) -> String {
format!("{}/api/v1{}", self.base_url, path)
}
/// Use `session_id` as the effective mem0 `user_id` when provided,
/// falling back to the configured default. This enables per-user
/// and per-group memory scoping via the existing `Memory` trait.
fn effective_user_id<'a>(&'a self, session_id: Option<&'a str>) -> &'a str {
session_id
.filter(|s| !s.trim().is_empty())
.unwrap_or(&self.user_id)
}
/// Recall memories with optional search filters.
///
/// - `created_after` / `created_before`: ISO 8601 timestamps for time-range filtering.
/// - `metadata_filter`: arbitrary JSON object passed to the mem0 SDK `filters` param.
pub async fn recall_filtered(
&self,
query: &str,
limit: usize,
session_id: Option<&str>,
created_after: Option<&str>,
created_before: Option<&str>,
metadata_filter: Option<&serde_json::Value>,
) -> anyhow::Result<Vec<MemoryEntry>> {
let effective_user = self.effective_user_id(session_id);
let limit_str = limit.to_string();
let mut params: Vec<(&str, &str)> = vec![
("user_id", effective_user),
("search_query", query),
("size", &limit_str),
];
if let Some(after) = created_after {
params.push(("created_after", after));
}
if let Some(before) = created_before {
params.push(("created_before", before));
}
let meta_json;
if let Some(mf) = metadata_filter {
meta_json = serde_json::to_string(mf)?;
params.push(("metadata_filter", &meta_json));
}
let resp = self
.client
.get(self.api_url("/memories/"))
.query(&params)
.send()
.await?;
if !resp.status().is_success() {
let status = resp.status();
let text = resp.text().await.unwrap_or_default();
anyhow::bail!("mem0 recall failed ({status}): {text}");
}
let list: Mem0ListResponse = resp.json().await?;
Ok(list.items.into_iter().map(|i| self.to_entry(i)).collect())
}
fn to_entry(&self, item: Mem0MemoryItem) -> MemoryEntry {
let meta = item.metadata.unwrap_or_default();
let timestamp = match item.created_at {
Some(serde_json::Value::Number(n)) => {
// Unix timestamp → ISO 8601
if let Some(ts) = n.as_i64() {
chrono::DateTime::from_timestamp(ts, 0)
.map(|dt| dt.to_rfc3339())
.unwrap_or_default()
} else {
String::new()
}
}
Some(serde_json::Value::String(s)) => s,
_ => String::new(),
};
let category = match meta.category.as_deref() {
Some("daily") => MemoryCategory::Daily,
Some("conversation") => MemoryCategory::Conversation,
Some(other) if other != "core" => MemoryCategory::Custom(other.to_string()),
// "core" or None → default
_ => MemoryCategory::Core,
};
MemoryEntry {
id: item.id,
key: meta.key.unwrap_or_default(),
content: item.memory,
category,
timestamp,
session_id: meta.session_id,
score: item.score,
}
}
/// Store a conversation trace as procedural memory.
///
/// Sends the message history (user input, tool calls, assistant response)
/// to the mem0 procedural endpoint so that "how to" patterns can be
/// extracted and stored for future recall.
pub async fn store_procedural(
&self,
messages: &[ProceduralMessage],
session_id: Option<&str>,
) -> anyhow::Result<()> {
if messages.is_empty() {
return Ok(());
}
let effective_user = self.effective_user_id(session_id);
let body = AddProceduralRequest {
user_id: effective_user,
messages,
metadata: None,
};
let resp = self
.client
.post(self.api_url("/memories/procedural"))
.json(&body)
.send()
.await?;
if !resp.status().is_success() {
let status = resp.status();
let text = resp.text().await.unwrap_or_default();
anyhow::bail!("mem0 store_procedural failed ({status}): {text}");
}
Ok(())
}
}
// ── History API types ─────────────────────────────────────────────
#[derive(Deserialize)]
struct Mem0HistoryResponse {
#[serde(default)]
history: Vec<serde_json::Value>,
#[serde(default)]
error: Option<String>,
}
impl Mem0Memory {
/// Retrieve the edit history (audit trail) for a specific memory by ID.
pub async fn history(&self, memory_id: &str) -> anyhow::Result<String> {
let url = self.api_url(&format!("/memories/{memory_id}/history"));
let resp = self.client.get(&url).send().await?;
if !resp.status().is_success() {
let status = resp.status();
let text = resp.text().await.unwrap_or_default();
anyhow::bail!("mem0 history failed ({status}): {text}");
}
let body: Mem0HistoryResponse = resp.json().await?;
if let Some(err) = body.error {
anyhow::bail!("mem0 history error: {err}");
}
if body.history.is_empty() {
return Ok(format!("No history found for memory {memory_id}."));
}
let mut lines = Vec::with_capacity(body.history.len() + 1);
lines.push(format!("History for memory {memory_id}:"));
for (i, entry) in body.history.iter().enumerate() {
let event = entry
.get("event")
.and_then(|v| v.as_str())
.unwrap_or("unknown");
let old_memory = entry
.get("old_memory")
.and_then(|v| v.as_str())
.unwrap_or("-");
let new_memory = entry
.get("new_memory")
.and_then(|v| v.as_str())
.unwrap_or("-");
let timestamp = entry
.get("created_at")
.or_else(|| entry.get("timestamp"))
.and_then(|v| v.as_str())
.unwrap_or("unknown");
lines.push(format!(
" {idx}. [{event}] at {timestamp}\n old: {old_memory}\n new: {new_memory}",
idx = i + 1,
));
}
Ok(lines.join("\n"))
}
}
#[async_trait]
impl Memory for Mem0Memory {
fn name(&self) -> &str {
"mem0"
}
async fn store(
&self,
key: &str,
content: &str,
category: MemoryCategory,
session_id: Option<&str>,
) -> anyhow::Result<()> {
let cat_str = category.to_string();
let effective_user = self.effective_user_id(session_id);
let body = AddMemoryRequest {
user_id: effective_user,
text: content,
metadata: Some(Mem0Metadata {
key,
category: &cat_str,
session_id,
}),
infer: self.infer,
app: Some(&self.app_name),
custom_instructions: self.extraction_prompt.as_deref(),
};
let resp = self
.client
.post(self.api_url("/memories/"))
.json(&body)
.send()
.await?;
if !resp.status().is_success() {
let status = resp.status();
let text = resp.text().await.unwrap_or_default();
anyhow::bail!("mem0 store failed ({status}): {text}");
}
Ok(())
}
async fn recall(
&self,
query: &str,
limit: usize,
session_id: Option<&str>,
_since: Option<&str>,
_until: Option<&str>,
) -> anyhow::Result<Vec<MemoryEntry>> {
// mem0 handles filtering server-side; since/until are not yet
// supported by the mem0 API, so we pass them through as no-ops.
self.recall_filtered(query, limit, session_id, None, None, None)
.await
}
async fn get(&self, key: &str) -> anyhow::Result<Option<MemoryEntry>> {
// mem0 doesn't have a get-by-key API, so we search by key in metadata
let results = self.recall(key, 1, None, None, None).await?;
Ok(results.into_iter().find(|e| e.key == key))
}
async fn list(
&self,
category: Option<&MemoryCategory>,
session_id: Option<&str>,
) -> anyhow::Result<Vec<MemoryEntry>> {
let effective_user = self.effective_user_id(session_id);
let resp = self
.client
.get(self.api_url("/memories/"))
.query(&[("user_id", effective_user), ("size", "100")])
.send()
.await?;
if !resp.status().is_success() {
let status = resp.status();
let text = resp.text().await.unwrap_or_default();
anyhow::bail!("mem0 list failed ({status}): {text}");
}
let list: Mem0ListResponse = resp.json().await?;
let entries: Vec<MemoryEntry> = list.items.into_iter().map(|i| self.to_entry(i)).collect();
// Client-side category filter (mem0 API doesn't filter by metadata)
match category {
Some(cat) => Ok(entries.into_iter().filter(|e| &e.category == cat).collect()),
None => Ok(entries),
}
}
async fn forget(&self, key: &str) -> anyhow::Result<bool> {
// Find the memory ID by key first
let entry = self.get(key).await?;
let entry = match entry {
Some(e) => e,
None => return Ok(false),
};
let body = DeleteMemoriesRequest {
memory_ids: vec![&entry.id],
user_id: &self.user_id,
};
let resp = self
.client
.delete(self.api_url("/memories/"))
.json(&body)
.send()
.await?;
Ok(resp.status().is_success())
}
async fn count(&self) -> anyhow::Result<usize> {
let resp = self
.client
.get(self.api_url("/memories/"))
.query(&[
("user_id", self.user_id.as_str()),
("size", "1"),
("page", "1"),
])
.send()
.await?;
if !resp.status().is_success() {
let status = resp.status();
let text = resp.text().await.unwrap_or_default();
anyhow::bail!("mem0 count failed ({status}): {text}");
}
let list: Mem0ListResponse = resp.json().await?;
Ok(list.total)
}
async fn health_check(&self) -> bool {
self.client
.get(self.api_url("/memories/"))
.query(&[
("user_id", self.user_id.as_str()),
("size", "1"),
("page", "1"),
])
.send()
.await
.is_ok_and(|r| r.status().is_success())
}
async fn store_procedural(
&self,
messages: &[ProceduralMessage],
session_id: Option<&str>,
) -> anyhow::Result<()> {
Mem0Memory::store_procedural(self, messages, session_id).await
}
}
#[cfg(test)]
mod tests {
use super::*;
fn test_config() -> Mem0Config {
Mem0Config {
url: "http://localhost:8765".into(),
user_id: "test-user".into(),
app_name: "test-app".into(),
infer: true,
extraction_prompt: None,
}
}
#[test]
fn new_rejects_empty_url() {
let config = Mem0Config {
url: String::new(),
..test_config()
};
assert!(Mem0Memory::new(&config).is_err());
}
#[test]
fn new_trims_trailing_slash() {
let config = Mem0Config {
url: "http://localhost:8765/".into(),
..test_config()
};
let mem = Mem0Memory::new(&config).unwrap();
assert_eq!(mem.base_url, "http://localhost:8765");
}
#[test]
fn api_url_builds_correct_path() {
let mem = Mem0Memory::new(&test_config()).unwrap();
assert_eq!(
mem.api_url("/memories/"),
"http://localhost:8765/api/v1/memories/"
);
}
#[test]
fn to_entry_maps_unix_timestamp() {
let mem = Mem0Memory::new(&test_config()).unwrap();
let item = Mem0MemoryItem {
id: "id-1".into(),
memory: "hello".into(),
created_at: Some(serde_json::json!(1_700_000_000)),
metadata: Some(Mem0ResponseMetadata {
key: Some("k1".into()),
category: Some("core".into()),
session_id: None,
}),
score: Some(0.95),
};
let entry = mem.to_entry(item);
assert_eq!(entry.id, "id-1");
assert_eq!(entry.key, "k1");
assert_eq!(entry.category, MemoryCategory::Core);
assert!(!entry.timestamp.is_empty());
assert_eq!(entry.score, Some(0.95));
}
#[test]
fn to_entry_maps_string_timestamp() {
let mem = Mem0Memory::new(&test_config()).unwrap();
let item = Mem0MemoryItem {
id: "id-2".into(),
memory: "world".into(),
created_at: Some(serde_json::json!("2024-01-01T00:00:00Z")),
metadata: None,
score: None,
};
let entry = mem.to_entry(item);
assert_eq!(entry.timestamp, "2024-01-01T00:00:00Z");
assert_eq!(entry.category, MemoryCategory::Core); // default
}
#[test]
fn to_entry_handles_missing_metadata() {
let mem = Mem0Memory::new(&test_config()).unwrap();
let item = Mem0MemoryItem {
id: "id-3".into(),
memory: "bare".into(),
created_at: None,
metadata: None,
score: None,
};
let entry = mem.to_entry(item);
assert_eq!(entry.key, "");
assert_eq!(entry.category, MemoryCategory::Core);
assert!(entry.timestamp.is_empty());
assert_eq!(entry.score, None);
}
#[test]
fn to_entry_custom_category() {
let mem = Mem0Memory::new(&test_config()).unwrap();
let item = Mem0MemoryItem {
id: "id-4".into(),
memory: "custom".into(),
created_at: None,
metadata: Some(Mem0ResponseMetadata {
key: Some("k".into()),
category: Some("project_notes".into()),
session_id: Some("s1".into()),
}),
score: None,
};
let entry = mem.to_entry(item);
assert_eq!(
entry.category,
MemoryCategory::Custom("project_notes".into())
);
assert_eq!(entry.session_id.as_deref(), Some("s1"));
}
#[test]
fn name_returns_mem0() {
let mem = Mem0Memory::new(&test_config()).unwrap();
assert_eq!(mem.name(), "mem0");
}
#[test]
fn procedural_request_serializes_messages() {
let messages = vec![
ProceduralMessage {
role: "user".into(),
content: "How do I deploy?".into(),
name: None,
},
ProceduralMessage {
role: "tool".into(),
content: "deployment started".into(),
name: Some("shell".into()),
},
ProceduralMessage {
role: "assistant".into(),
content: "Deployment complete.".into(),
name: None,
},
];
let req = AddProceduralRequest {
user_id: "test-user",
messages: &messages,
metadata: None,
};
let json = serde_json::to_value(&req).unwrap();
assert_eq!(json["user_id"], "test-user");
let msgs = json["messages"].as_array().unwrap();
assert_eq!(msgs.len(), 3);
assert_eq!(msgs[0]["role"], "user");
assert_eq!(msgs[1]["name"], "shell");
// metadata should be absent when None
assert!(json.get("metadata").is_none());
}
}
+15 -27
View File
@@ -1,24 +1,32 @@
pub mod audit;
pub mod backend;
pub mod chunker;
pub mod cli;
pub mod conflict;
pub mod consolidation;
pub mod embeddings;
pub mod hygiene;
pub mod importance;
pub mod knowledge_graph;
pub mod lucid;
pub mod markdown;
#[cfg(feature = "memory-mem0")]
pub mod mem0;
pub mod none;
pub mod policy;
#[cfg(feature = "memory-postgres")]
pub mod postgres;
pub mod qdrant;
pub mod response_cache;
pub mod retrieval;
pub mod snapshot;
pub mod sqlite;
pub mod traits;
pub mod vector;
#[cfg(test)]
mod battle_tests;
#[allow(unused_imports)]
pub use audit::AuditedMemory;
#[allow(unused_imports)]
pub use backend::{
classify_memory_backend, default_memory_backend_key, memory_backend_profile,
@@ -26,13 +34,15 @@ pub use backend::{
};
pub use lucid::LucidMemory;
pub use markdown::MarkdownMemory;
#[cfg(feature = "memory-mem0")]
pub use mem0::Mem0Memory;
pub use none::NoneMemory;
#[allow(unused_imports)]
pub use policy::PolicyEnforcer;
#[cfg(feature = "memory-postgres")]
pub use postgres::PostgresMemory;
pub use qdrant::QdrantMemory;
pub use response_cache::ResponseCache;
#[allow(unused_imports)]
pub use retrieval::{RetrievalConfig, RetrievalPipeline};
pub use sqlite::SqliteMemory;
pub use traits::Memory;
#[allow(unused_imports)]
@@ -61,7 +71,7 @@ where
Ok(Box::new(LucidMemory::new(workspace_dir, local)))
}
MemoryBackendKind::Postgres => postgres_builder(),
MemoryBackendKind::Qdrant | MemoryBackendKind::Mem0 | MemoryBackendKind::Markdown => {
MemoryBackendKind::Qdrant | MemoryBackendKind::Markdown => {
Ok(Box::new(MarkdownMemory::new(workspace_dir)))
}
MemoryBackendKind::None => Ok(Box::new(NoneMemory::new())),
@@ -340,28 +350,6 @@ pub fn create_memory_with_storage_and_routes(
);
}
#[cfg(feature = "memory-mem0")]
fn build_mem0_memory(config: &crate::config::MemoryConfig) -> anyhow::Result<Box<dyn Memory>> {
let mem = Mem0Memory::new(&config.mem0)?;
tracing::info!(
"📦 Mem0 memory backend configured (url: {}, user: {})",
config.mem0.url,
config.mem0.user_id
);
Ok(Box::new(mem))
}
#[cfg(not(feature = "memory-mem0"))]
fn build_mem0_memory(_config: &crate::config::MemoryConfig) -> anyhow::Result<Box<dyn Memory>> {
anyhow::bail!(
"memory backend 'mem0' requested but this build was compiled without `memory-mem0`; rebuild with `--features memory-mem0`"
);
}
if matches!(backend_kind, MemoryBackendKind::Mem0) {
return build_mem0_memory(config);
}
if matches!(backend_kind, MemoryBackendKind::Qdrant) {
let url = config
.qdrant
+192
View File
@@ -0,0 +1,192 @@
//! Policy engine for memory operations.
//!
//! Validates operations against configurable rules before they reach the
//! backend. Enforces namespace quotas, category limits, read-only namespaces,
//! and per-category retention rules.
use super::traits::MemoryCategory;
use crate::config::MemoryPolicyConfig;
/// Policy enforcer that validates memory operations.
pub struct PolicyEnforcer {
config: MemoryPolicyConfig,
}
impl PolicyEnforcer {
pub fn new(config: &MemoryPolicyConfig) -> Self {
Self {
config: config.clone(),
}
}
/// Check if a namespace is read-only.
pub fn is_read_only(&self, namespace: &str) -> bool {
self.config
.read_only_namespaces
.iter()
.any(|ns| ns == namespace)
}
/// Validate a store operation against policy rules.
pub fn validate_store(
&self,
namespace: &str,
_category: &MemoryCategory,
) -> Result<(), PolicyViolation> {
if self.is_read_only(namespace) {
return Err(PolicyViolation::ReadOnlyNamespace(namespace.to_string()));
}
Ok(())
}
/// Check if adding an entry would exceed namespace limits.
pub fn check_namespace_limit(&self, current_count: usize) -> Result<(), PolicyViolation> {
if self.config.max_entries_per_namespace > 0
&& current_count >= self.config.max_entries_per_namespace
{
return Err(PolicyViolation::NamespaceQuotaExceeded {
max: self.config.max_entries_per_namespace,
current: current_count,
});
}
Ok(())
}
/// Check if adding an entry would exceed category limits.
pub fn check_category_limit(&self, current_count: usize) -> Result<(), PolicyViolation> {
if self.config.max_entries_per_category > 0
&& current_count >= self.config.max_entries_per_category
{
return Err(PolicyViolation::CategoryQuotaExceeded {
max: self.config.max_entries_per_category,
current: current_count,
});
}
Ok(())
}
/// Get the retention days for a specific category, falling back to the
/// provided default if no per-category override exists.
pub fn retention_days_for_category(&self, category: &MemoryCategory, default_days: u32) -> u32 {
let key = category.to_string();
self.config
.retention_days_by_category
.get(&key)
.copied()
.unwrap_or(default_days)
}
}
/// Policy violation errors.
#[derive(Debug, Clone)]
pub enum PolicyViolation {
ReadOnlyNamespace(String),
NamespaceQuotaExceeded { max: usize, current: usize },
CategoryQuotaExceeded { max: usize, current: usize },
}
impl std::fmt::Display for PolicyViolation {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
match self {
Self::ReadOnlyNamespace(ns) => write!(f, "namespace '{ns}' is read-only"),
Self::NamespaceQuotaExceeded { max, current } => {
write!(f, "namespace quota exceeded: {current}/{max} entries")
}
Self::CategoryQuotaExceeded { max, current } => {
write!(f, "category quota exceeded: {current}/{max} entries")
}
}
}
}
impl std::error::Error for PolicyViolation {}
#[cfg(test)]
mod tests {
use super::*;
use std::collections::HashMap;
fn empty_policy() -> MemoryPolicyConfig {
MemoryPolicyConfig::default()
}
#[test]
fn default_policy_allows_everything() {
let enforcer = PolicyEnforcer::new(&empty_policy());
assert!(!enforcer.is_read_only("default"));
assert!(enforcer
.validate_store("default", &MemoryCategory::Core)
.is_ok());
assert!(enforcer.check_namespace_limit(100).is_ok());
assert!(enforcer.check_category_limit(100).is_ok());
}
#[test]
fn read_only_namespace_blocks_writes() {
let policy = MemoryPolicyConfig {
read_only_namespaces: vec!["archive".into()],
..empty_policy()
};
let enforcer = PolicyEnforcer::new(&policy);
assert!(enforcer.is_read_only("archive"));
assert!(!enforcer.is_read_only("default"));
assert!(enforcer
.validate_store("archive", &MemoryCategory::Core)
.is_err());
assert!(enforcer
.validate_store("default", &MemoryCategory::Core)
.is_ok());
}
#[test]
fn namespace_quota_enforced() {
let policy = MemoryPolicyConfig {
max_entries_per_namespace: 10,
..empty_policy()
};
let enforcer = PolicyEnforcer::new(&policy);
assert!(enforcer.check_namespace_limit(5).is_ok());
assert!(enforcer.check_namespace_limit(10).is_err());
assert!(enforcer.check_namespace_limit(15).is_err());
}
#[test]
fn category_quota_enforced() {
let policy = MemoryPolicyConfig {
max_entries_per_category: 50,
..empty_policy()
};
let enforcer = PolicyEnforcer::new(&policy);
assert!(enforcer.check_category_limit(25).is_ok());
assert!(enforcer.check_category_limit(50).is_err());
}
#[test]
fn per_category_retention_overrides_default() {
let mut retention = HashMap::new();
retention.insert("core".into(), 365);
retention.insert("conversation".into(), 7);
let policy = MemoryPolicyConfig {
retention_days_by_category: retention,
..empty_policy()
};
let enforcer = PolicyEnforcer::new(&policy);
assert_eq!(
enforcer.retention_days_for_category(&MemoryCategory::Core, 30),
365
);
assert_eq!(
enforcer.retention_days_for_category(&MemoryCategory::Conversation, 30),
7
);
assert_eq!(
enforcer.retention_days_for_category(&MemoryCategory::Daily, 30),
30
);
}
}
+12 -3
View File
@@ -100,6 +100,8 @@ impl PostgresMemory {
CREATE INDEX IF NOT EXISTS idx_memories_category ON {qualified_table}(category);
CREATE INDEX IF NOT EXISTS idx_memories_session_id ON {qualified_table}(session_id);
CREATE INDEX IF NOT EXISTS idx_memories_updated_at ON {qualified_table}(updated_at DESC);
CREATE INDEX IF NOT EXISTS idx_memories_content_fts ON {qualified_table} USING gin(to_tsvector('simple', content));
CREATE INDEX IF NOT EXISTS idx_memories_key_fts ON {qualified_table} USING gin(to_tsvector('simple', key));
"
))?;
@@ -135,6 +137,9 @@ impl PostgresMemory {
timestamp: timestamp.to_rfc3339(),
session_id: row.get(5),
score: row.try_get(6).ok(),
namespace: "default".into(),
importance: None,
superseded_by: None,
})
}
}
@@ -267,12 +272,16 @@ impl Memory for PostgresMemory {
"
SELECT id, key, content, category, created_at, session_id,
(
CASE WHEN key ILIKE '%' || $1 || '%' THEN 2.0 ELSE 0.0 END +
CASE WHEN content ILIKE '%' || $1 || '%' THEN 1.0 ELSE 0.0 END
CASE WHEN to_tsvector('simple', key) @@ plainto_tsquery('simple', $1)
THEN ts_rank_cd(to_tsvector('simple', key), plainto_tsquery('simple', $1)) * 2.0
ELSE 0.0 END +
CASE WHEN to_tsvector('simple', content) @@ plainto_tsquery('simple', $1)
THEN ts_rank_cd(to_tsvector('simple', content), plainto_tsquery('simple', $1))
ELSE 0.0 END
) AS score
FROM {qualified_table}
WHERE ($2::TEXT IS NULL OR session_id = $2)
AND ($1 = '' OR key ILIKE '%' || $1 || '%' OR content ILIKE '%' || $1 || '%')
AND ($1 = '' OR to_tsvector('simple', key || ' ' || content) @@ plainto_tsquery('simple', $1))
{time_filter}
ORDER BY score DESC, updated_at DESC
LIMIT $3
+9
View File
@@ -373,6 +373,9 @@ impl Memory for QdrantMemory {
timestamp: payload.timestamp,
session_id: payload.session_id,
score: Some(point.score),
namespace: "default".into(),
importance: None,
superseded_by: None,
})
})
.collect();
@@ -437,6 +440,9 @@ impl Memory for QdrantMemory {
timestamp: payload.timestamp,
session_id: payload.session_id,
score: None,
namespace: "default".into(),
importance: None,
superseded_by: None,
})
});
@@ -514,6 +520,9 @@ impl Memory for QdrantMemory {
timestamp: payload.timestamp,
session_id: payload.session_id,
score: None,
namespace: "default".into(),
importance: None,
superseded_by: None,
})
})
.collect();
+267
View File
@@ -0,0 +1,267 @@
//! Multi-stage retrieval pipeline.
//!
//! Wraps a `Memory` trait object with staged retrieval:
//! - **Stage 1 (Hot cache):** In-memory LRU of recent recall results.
//! - **Stage 2 (FTS):** FTS5 keyword search with optional early-return.
//! - **Stage 3 (Vector):** Vector similarity search + hybrid merge.
//!
//! Configurable via `[memory]` settings: `retrieval_stages`, `fts_early_return_score`.
use super::traits::{Memory, MemoryEntry};
use parking_lot::Mutex;
use std::collections::HashMap;
use std::sync::Arc;
use std::time::{Duration, Instant};
/// A cached recall result.
struct CachedResult {
entries: Vec<MemoryEntry>,
created_at: Instant,
}
/// Multi-stage retrieval pipeline configuration.
#[derive(Debug, Clone)]
pub struct RetrievalConfig {
/// Ordered list of stages: "cache", "fts", "vector".
pub stages: Vec<String>,
/// FTS score above which to early-return without vector stage.
pub fts_early_return_score: f64,
/// Max entries in the hot cache.
pub cache_max_entries: usize,
/// TTL for cached results.
pub cache_ttl: Duration,
}
impl Default for RetrievalConfig {
fn default() -> Self {
Self {
stages: vec!["cache".into(), "fts".into(), "vector".into()],
fts_early_return_score: 0.85,
cache_max_entries: 256,
cache_ttl: Duration::from_secs(300),
}
}
}
/// Multi-stage retrieval pipeline wrapping a `Memory` backend.
pub struct RetrievalPipeline {
memory: Arc<dyn Memory>,
config: RetrievalConfig,
hot_cache: Mutex<HashMap<String, CachedResult>>,
}
impl RetrievalPipeline {
pub fn new(memory: Arc<dyn Memory>, config: RetrievalConfig) -> Self {
Self {
memory,
config,
hot_cache: Mutex::new(HashMap::new()),
}
}
/// Build a cache key from query parameters.
fn cache_key(
query: &str,
limit: usize,
session_id: Option<&str>,
namespace: Option<&str>,
) -> String {
format!(
"{}:{}:{}:{}",
query,
limit,
session_id.unwrap_or(""),
namespace.unwrap_or("")
)
}
/// Check the hot cache for a previous result.
fn check_cache(&self, key: &str) -> Option<Vec<MemoryEntry>> {
let cache = self.hot_cache.lock();
if let Some(cached) = cache.get(key) {
if cached.created_at.elapsed() < self.config.cache_ttl {
return Some(cached.entries.clone());
}
}
None
}
/// Store a result in the hot cache with LRU eviction.
fn store_in_cache(&self, key: String, entries: Vec<MemoryEntry>) {
let mut cache = self.hot_cache.lock();
// LRU eviction: remove oldest entries if at capacity
if cache.len() >= self.config.cache_max_entries {
let oldest_key = cache
.iter()
.min_by_key(|(_, v)| v.created_at)
.map(|(k, _)| k.clone());
if let Some(k) = oldest_key {
cache.remove(&k);
}
}
cache.insert(
key,
CachedResult {
entries,
created_at: Instant::now(),
},
);
}
/// Execute the multi-stage retrieval pipeline.
pub async fn recall(
&self,
query: &str,
limit: usize,
session_id: Option<&str>,
namespace: Option<&str>,
since: Option<&str>,
until: Option<&str>,
) -> anyhow::Result<Vec<MemoryEntry>> {
let ck = Self::cache_key(query, limit, session_id, namespace);
for stage in &self.config.stages {
match stage.as_str() {
"cache" => {
if let Some(cached) = self.check_cache(&ck) {
tracing::debug!("retrieval pipeline: cache hit for '{query}'");
return Ok(cached);
}
}
"fts" | "vector" => {
// Both FTS and vector are handled by the backend's recall method
// which already does hybrid merge. We delegate to it.
let results = if let Some(ns) = namespace {
self.memory
.recall_namespaced(ns, query, limit, session_id, since, until)
.await?
} else {
self.memory
.recall(query, limit, session_id, since, until)
.await?
};
if !results.is_empty() {
// Check for FTS early-return: if top score exceeds threshold
// and we're in the FTS stage, we can skip further stages
if stage == "fts" {
if let Some(top_score) = results.first().and_then(|e| e.score) {
if top_score >= self.config.fts_early_return_score {
tracing::debug!(
"retrieval pipeline: FTS early return (score={top_score:.3})"
);
self.store_in_cache(ck, results.clone());
return Ok(results);
}
}
}
self.store_in_cache(ck, results.clone());
return Ok(results);
}
}
other => {
tracing::warn!("retrieval pipeline: unknown stage '{other}', skipping");
}
}
}
// No results from any stage
Ok(Vec::new())
}
/// Invalidate the hot cache (e.g. after a store operation).
pub fn invalidate_cache(&self) {
self.hot_cache.lock().clear();
}
/// Get the number of entries in the hot cache.
pub fn cache_size(&self) -> usize {
self.hot_cache.lock().len()
}
}
#[cfg(test)]
mod tests {
use super::*;
use crate::memory::NoneMemory;
#[tokio::test]
async fn pipeline_returns_empty_from_none_backend() {
let memory = Arc::new(NoneMemory::new());
let pipeline = RetrievalPipeline::new(memory, RetrievalConfig::default());
let results = pipeline
.recall("test", 10, None, None, None, None)
.await
.unwrap();
assert!(results.is_empty());
}
#[tokio::test]
async fn pipeline_cache_invalidation() {
let memory = Arc::new(NoneMemory::new());
let pipeline = RetrievalPipeline::new(memory, RetrievalConfig::default());
// Force a cache entry
let ck = RetrievalPipeline::cache_key("test", 10, None, None);
pipeline.store_in_cache(ck, vec![]);
assert_eq!(pipeline.cache_size(), 1);
pipeline.invalidate_cache();
assert_eq!(pipeline.cache_size(), 0);
}
#[test]
fn cache_key_includes_all_params() {
let k1 = RetrievalPipeline::cache_key("hello", 10, Some("sess-a"), Some("ns1"));
let k2 = RetrievalPipeline::cache_key("hello", 10, Some("sess-b"), Some("ns1"));
let k3 = RetrievalPipeline::cache_key("hello", 10, Some("sess-a"), Some("ns2"));
assert_ne!(k1, k2);
assert_ne!(k1, k3);
}
#[tokio::test]
async fn pipeline_caches_results() {
let memory = Arc::new(NoneMemory::new());
let config = RetrievalConfig {
stages: vec!["cache".into()],
..Default::default()
};
let pipeline = RetrievalPipeline::new(memory, config);
// First call: cache miss, no results
let results = pipeline
.recall("test", 10, None, None, None, None)
.await
.unwrap();
assert!(results.is_empty());
// Manually insert a cache entry
let ck = RetrievalPipeline::cache_key("cached_query", 5, None, None);
let fake_entry = MemoryEntry {
id: "1".into(),
key: "k".into(),
content: "cached content".into(),
category: crate::memory::MemoryCategory::Core,
timestamp: "now".into(),
session_id: None,
score: Some(0.9),
namespace: "default".into(),
importance: None,
superseded_by: None,
};
pipeline.store_in_cache(ck, vec![fake_entry]);
// Cache hit
let results = pipeline
.recall("cached_query", 5, None, None, None, None)
.await
.unwrap();
assert_eq!(results.len(), 1);
assert_eq!(results[0].content, "cached content");
}
}
+129 -23
View File
@@ -197,17 +197,35 @@ impl SqliteMemory {
)?;
// Migration: add session_id column if not present (safe to run repeatedly)
let has_session_id: bool = conn
let schema_sql: String = conn
.prepare("SELECT sql FROM sqlite_master WHERE type='table' AND name='memories'")?
.query_row([], |row| row.get::<_, String>(0))?
.contains("session_id");
if !has_session_id {
.query_row([], |row| row.get::<_, String>(0))?;
if !schema_sql.contains("session_id") {
conn.execute_batch(
"ALTER TABLE memories ADD COLUMN session_id TEXT;
CREATE INDEX IF NOT EXISTS idx_memories_session ON memories(session_id);",
)?;
}
// Migration: add namespace column
if !schema_sql.contains("namespace") {
conn.execute_batch(
"ALTER TABLE memories ADD COLUMN namespace TEXT DEFAULT 'default';
CREATE INDEX IF NOT EXISTS idx_memories_namespace ON memories(namespace);",
)?;
}
// Migration: add importance column
if !schema_sql.contains("importance") {
conn.execute_batch("ALTER TABLE memories ADD COLUMN importance REAL DEFAULT 0.5;")?;
}
// Migration: add superseded_by column
if !schema_sql.contains("superseded_by") {
conn.execute_batch("ALTER TABLE memories ADD COLUMN superseded_by TEXT;")?;
}
Ok(())
}
@@ -246,8 +264,13 @@ impl SqliteMemory {
)
}
/// Provide access to the connection for advanced queries (e.g. retrieval pipeline).
pub fn connection(&self) -> &Arc<Mutex<Connection>> {
&self.conn
}
/// Get embedding from cache, or compute + cache it
async fn get_or_compute_embedding(&self, text: &str) -> anyhow::Result<Option<Vec<f32>>> {
pub async fn get_or_compute_embedding(&self, text: &str) -> anyhow::Result<Option<Vec<f32>>> {
if self.embedder.dimensions() == 0 {
return Ok(None); // Noop embedder
}
@@ -310,7 +333,7 @@ impl SqliteMemory {
}
/// FTS5 BM25 keyword search
fn fts5_search(
pub fn fts5_search(
conn: &Connection,
query: &str,
limit: usize,
@@ -356,7 +379,7 @@ impl SqliteMemory {
///
/// Optional `category` and `session_id` filters reduce full-table scans
/// when the caller already knows the scope of relevant memories.
fn vector_search(
pub fn vector_search(
conn: &Connection,
query_embedding: &[f32],
limit: usize,
@@ -473,8 +496,8 @@ impl SqliteMemory {
let until_ref = until_owned.as_deref();
let mut sql =
"SELECT id, key, content, category, created_at, session_id FROM memories \
WHERE 1=1"
"SELECT id, key, content, category, created_at, session_id, namespace, importance, superseded_by FROM memories \
WHERE superseded_by IS NULL AND 1=1"
.to_string();
let mut param_values: Vec<Box<dyn rusqlite::types::ToSql>> = Vec::new();
let mut idx = 1;
@@ -510,6 +533,9 @@ impl SqliteMemory {
timestamp: row.get(4)?,
session_id: row.get(5)?,
score: None,
namespace: row.get::<_, Option<String>>(6)?.unwrap_or_else(|| "default".into()),
importance: row.get(7)?,
superseded_by: row.get(8)?,
})
})?;
@@ -554,8 +580,8 @@ impl Memory for SqliteMemory {
let id = Uuid::new_v4().to_string();
conn.execute(
"INSERT INTO memories (id, key, content, category, embedding, created_at, updated_at, session_id)
VALUES (?1, ?2, ?3, ?4, ?5, ?6, ?7, ?8)
"INSERT INTO memories (id, key, content, category, embedding, created_at, updated_at, session_id, namespace, importance)
VALUES (?1, ?2, ?3, ?4, ?5, ?6, ?7, ?8, 'default', 0.5)
ON CONFLICT(key) DO UPDATE SET
content = excluded.content,
category = excluded.category,
@@ -641,8 +667,8 @@ impl Memory for SqliteMemory {
.collect::<Vec<_>>()
.join(", ");
let sql = format!(
"SELECT id, key, content, category, created_at, session_id \
FROM memories WHERE id IN ({placeholders})"
"SELECT id, key, content, category, created_at, session_id, namespace, importance, superseded_by \
FROM memories WHERE superseded_by IS NULL AND id IN ({placeholders})"
);
let mut stmt = conn.prepare(&sql)?;
let id_params: Vec<Box<dyn rusqlite::types::ToSql>> = merged
@@ -659,17 +685,20 @@ impl Memory for SqliteMemory {
row.get::<_, String>(3)?,
row.get::<_, String>(4)?,
row.get::<_, Option<String>>(5)?,
row.get::<_, Option<String>>(6)?,
row.get::<_, Option<f64>>(7)?,
row.get::<_, Option<String>>(8)?,
))
})?;
let mut entry_map = std::collections::HashMap::new();
for row in rows {
let (id, key, content, cat, ts, sid) = row?;
entry_map.insert(id, (key, content, cat, ts, sid));
let (id, key, content, cat, ts, sid, ns, imp, sup) = row?;
entry_map.insert(id, (key, content, cat, ts, sid, ns, imp, sup));
}
for scored in &merged {
if let Some((key, content, cat, ts, sid)) = entry_map.remove(&scored.id) {
if let Some((key, content, cat, ts, sid, ns, imp, sup)) = entry_map.remove(&scored.id) {
if let Some(s) = since_ref {
if ts.as_str() < s {
continue;
@@ -688,6 +717,9 @@ impl Memory for SqliteMemory {
timestamp: ts,
session_id: sid,
score: Some(f64::from(scored.final_score)),
namespace: ns.unwrap_or_else(|| "default".into()),
importance: imp,
superseded_by: sup,
};
if let Some(filter_sid) = session_ref {
if entry.session_id.as_deref() != Some(filter_sid) {
@@ -727,8 +759,8 @@ impl Memory for SqliteMemory {
param_idx += 1;
}
let sql = format!(
"SELECT id, key, content, category, created_at, session_id FROM memories
WHERE {where_clause}{time_conditions}
"SELECT id, key, content, category, created_at, session_id, namespace, importance, superseded_by FROM memories
WHERE superseded_by IS NULL AND ({where_clause}){time_conditions}
ORDER BY updated_at DESC
LIMIT ?{param_idx}"
);
@@ -757,6 +789,9 @@ impl Memory for SqliteMemory {
timestamp: row.get(4)?,
session_id: row.get(5)?,
score: Some(1.0),
namespace: row.get::<_, Option<String>>(6)?.unwrap_or_else(|| "default".into()),
importance: row.get(7)?,
superseded_by: row.get(8)?,
})
})?;
for row in rows {
@@ -784,7 +819,7 @@ impl Memory for SqliteMemory {
tokio::task::spawn_blocking(move || -> anyhow::Result<Option<MemoryEntry>> {
let conn = conn.lock();
let mut stmt = conn.prepare(
"SELECT id, key, content, category, created_at, session_id FROM memories WHERE key = ?1",
"SELECT id, key, content, category, created_at, session_id, namespace, importance, superseded_by FROM memories WHERE key = ?1",
)?;
let mut rows = stmt.query_map(params![key], |row| {
@@ -796,6 +831,9 @@ impl Memory for SqliteMemory {
timestamp: row.get(4)?,
session_id: row.get(5)?,
score: None,
namespace: row.get::<_, Option<String>>(6)?.unwrap_or_else(|| "default".into()),
importance: row.get(7)?,
superseded_by: row.get(8)?,
})
})?;
@@ -832,14 +870,17 @@ impl Memory for SqliteMemory {
timestamp: row.get(4)?,
session_id: row.get(5)?,
score: None,
namespace: row.get::<_, Option<String>>(6)?.unwrap_or_else(|| "default".into()),
importance: row.get(7)?,
superseded_by: row.get(8)?,
})
};
if let Some(ref cat) = category {
let cat_str = Self::category_to_str(cat);
let mut stmt = conn.prepare(
"SELECT id, key, content, category, created_at, session_id FROM memories
WHERE category = ?1 ORDER BY updated_at DESC LIMIT ?2",
"SELECT id, key, content, category, created_at, session_id, namespace, importance, superseded_by FROM memories
WHERE superseded_by IS NULL AND category = ?1 ORDER BY updated_at DESC LIMIT ?2",
)?;
let rows = stmt.query_map(params![cat_str, DEFAULT_LIST_LIMIT], row_mapper)?;
for row in rows {
@@ -853,8 +894,8 @@ impl Memory for SqliteMemory {
}
} else {
let mut stmt = conn.prepare(
"SELECT id, key, content, category, created_at, session_id FROM memories
ORDER BY updated_at DESC LIMIT ?1",
"SELECT id, key, content, category, created_at, session_id, namespace, importance, superseded_by FROM memories
WHERE superseded_by IS NULL ORDER BY updated_at DESC LIMIT ?1",
)?;
let rows = stmt.query_map(params![DEFAULT_LIST_LIMIT], row_mapper)?;
for row in rows {
@@ -904,6 +945,71 @@ impl Memory for SqliteMemory {
.await
.unwrap_or(false)
}
async fn recall_namespaced(
&self,
namespace: &str,
query: &str,
limit: usize,
session_id: Option<&str>,
since: Option<&str>,
until: Option<&str>,
) -> anyhow::Result<Vec<MemoryEntry>> {
let entries = self
.recall(query, limit * 2, session_id, since, until)
.await?;
let filtered: Vec<MemoryEntry> = entries
.into_iter()
.filter(|e| e.namespace == namespace)
.take(limit)
.collect();
Ok(filtered)
}
async fn store_with_metadata(
&self,
key: &str,
content: &str,
category: MemoryCategory,
session_id: Option<&str>,
namespace: Option<&str>,
importance: Option<f64>,
) -> anyhow::Result<()> {
let embedding_bytes = self
.get_or_compute_embedding(content)
.await?
.map(|emb| vector::vec_to_bytes(&emb));
let conn = self.conn.clone();
let key = key.to_string();
let content = content.to_string();
let sid = session_id.map(String::from);
let ns = namespace.unwrap_or("default").to_string();
let imp = importance.unwrap_or(0.5);
tokio::task::spawn_blocking(move || -> anyhow::Result<()> {
let conn = conn.lock();
let now = Local::now().to_rfc3339();
let cat = Self::category_to_str(&category);
let id = Uuid::new_v4().to_string();
conn.execute(
"INSERT INTO memories (id, key, content, category, embedding, created_at, updated_at, session_id, namespace, importance)
VALUES (?1, ?2, ?3, ?4, ?5, ?6, ?7, ?8, ?9, ?10)
ON CONFLICT(key) DO UPDATE SET
content = excluded.content,
category = excluded.category,
embedding = excluded.embedding,
updated_at = excluded.updated_at,
session_id = excluded.session_id,
namespace = excluded.namespace,
importance = excluded.importance",
params![id, key, content, cat, embedding_bytes, now, now, sid, ns, imp],
)?;
Ok(())
})
.await?
}
}
#[cfg(test)]
+63 -2
View File
@@ -4,7 +4,7 @@ use serde::{Deserialize, Serialize};
/// A single message in a conversation trace for procedural memory.
///
/// Used to capture "how to" patterns from tool-calling turns so that
/// backends that support procedural storage (e.g. mem0) can learn from them.
/// backends that support procedural storage can learn from them.
#[derive(Clone, Debug, Serialize, Deserialize)]
pub struct ProceduralMessage {
pub role: String,
@@ -23,6 +23,19 @@ pub struct MemoryEntry {
pub timestamp: String,
pub session_id: Option<String>,
pub score: Option<f64>,
/// Namespace for isolation between agents/contexts.
#[serde(default = "default_namespace")]
pub namespace: String,
/// Importance score (0.01.0) for prioritized retrieval.
#[serde(default)]
pub importance: Option<f64>,
/// If this entry was superseded by a newer conflicting entry.
#[serde(default)]
pub superseded_by: Option<String>,
}
fn default_namespace() -> String {
"default".into()
}
impl std::fmt::Debug for MemoryEntry {
@@ -34,6 +47,8 @@ impl std::fmt::Debug for MemoryEntry {
.field("category", &self.category)
.field("timestamp", &self.timestamp)
.field("score", &self.score)
.field("namespace", &self.namespace)
.field("importance", &self.importance)
.finish_non_exhaustive()
}
}
@@ -128,7 +143,7 @@ pub trait Memory: Send + Sync {
/// Store a conversation trace as procedural memory.
///
/// Backends that support procedural storage (e.g. mem0) override this
/// Backends that support procedural storage override this
/// to extract "how to" patterns from tool-calling turns. The default
/// implementation is a no-op.
async fn store_procedural(
@@ -138,6 +153,46 @@ pub trait Memory: Send + Sync {
) -> anyhow::Result<()> {
Ok(())
}
/// Recall memories scoped to a specific namespace.
///
/// Default implementation delegates to `recall()` and filters by namespace.
/// Backends with native namespace support should override for efficiency.
async fn recall_namespaced(
&self,
namespace: &str,
query: &str,
limit: usize,
session_id: Option<&str>,
since: Option<&str>,
until: Option<&str>,
) -> anyhow::Result<Vec<MemoryEntry>> {
let entries = self
.recall(query, limit * 2, session_id, since, until)
.await?;
let filtered: Vec<MemoryEntry> = entries
.into_iter()
.filter(|e| e.namespace == namespace)
.take(limit)
.collect();
Ok(filtered)
}
/// Store a memory entry with namespace and importance.
///
/// Default implementation delegates to `store()`. Backends with native
/// namespace/importance support should override.
async fn store_with_metadata(
&self,
key: &str,
content: &str,
category: MemoryCategory,
session_id: Option<&str>,
_namespace: Option<&str>,
_importance: Option<f64>,
) -> anyhow::Result<()> {
self.store(key, content, category, session_id).await
}
}
#[cfg(test)]
@@ -185,6 +240,9 @@ mod tests {
timestamp: "2026-02-16T00:00:00Z".into(),
session_id: Some("session-abc".into()),
score: Some(0.98),
namespace: "default".into(),
importance: Some(0.7),
superseded_by: None,
};
let json = serde_json::to_string(&entry).unwrap();
@@ -196,5 +254,8 @@ mod tests {
assert_eq!(parsed.category, MemoryCategory::Core);
assert_eq!(parsed.session_id.as_deref(), Some("session-abc"));
assert_eq!(parsed.score, Some(0.98));
assert_eq!(parsed.namespace, "default");
assert_eq!(parsed.importance, Some(0.7));
assert!(parsed.superseded_by.is_none());
}
}
+1
View File
@@ -126,6 +126,7 @@ pub fn hybrid_merge(
b.final_score
.partial_cmp(&a.final_score)
.unwrap_or(std::cmp::Ordering::Equal)
.then_with(|| a.id.cmp(&b.id))
});
results.truncate(limit);
results
+2
View File
@@ -507,6 +507,7 @@ mod tests {
max_images: 1,
max_image_size_mb: 5,
allow_remote_fetch: false,
..Default::default()
};
let error = prepare_messages_for_provider(&messages, &config)
@@ -549,6 +550,7 @@ mod tests {
max_images: 4,
max_image_size_mb: 1,
allow_remote_fetch: false,
..Default::default()
};
let error = prepare_messages_for_provider(&messages, &config)
+10 -1
View File
@@ -420,9 +420,17 @@ fn memory_config_defaults_for_backend(backend: &str) -> MemoryConfig {
snapshot_enabled: false,
snapshot_on_hygiene: false,
auto_hydrate: true,
retrieval_stages: vec!["cache".into(), "fts".into(), "vector".into()],
rerank_enabled: false,
rerank_threshold: 5,
fts_early_return_score: 0.85,
default_namespace: "default".into(),
conflict_threshold: 0.85,
audit_enabled: false,
audit_retention_days: 30,
policy: crate::config::MemoryPolicyConfig::default(),
sqlite_open_timeout_secs: None,
qdrant: crate::config::QdrantConfig::default(),
mem0: crate::config::schema::Mem0Config::default(),
}
}
@@ -4185,6 +4193,7 @@ fn setup_channels() -> Result<ChannelsConfig> {
device_id: detected_device_id,
room_id,
allowed_users,
allowed_rooms: vec![],
interrupt_on_new_message: false,
});
}
+10
View File
@@ -767,6 +767,12 @@ impl Provider for OpenAiCodexProvider {
#[cfg(test)]
mod tests {
use super::*;
use std::sync::Mutex;
/// Mutex that serializes all tests which mutate process-global env vars
/// (`std::env::set_var` / `remove_var`). Each such test must hold this
/// lock for its entire duration so that parallel test threads don't race.
static ENV_MUTEX: Mutex<()> = Mutex::new(());
struct EnvGuard {
key: &'static str,
@@ -841,6 +847,7 @@ mod tests {
#[test]
fn resolve_responses_url_prefers_explicit_endpoint_env() {
let _lock = ENV_MUTEX.lock().unwrap_or_else(|e| e.into_inner());
let _endpoint_guard = EnvGuard::set(
CODEX_RESPONSES_URL_ENV,
Some("https://env.example.com/v1/responses"),
@@ -856,6 +863,7 @@ mod tests {
#[test]
fn resolve_responses_url_uses_provider_api_url_override() {
let _lock = ENV_MUTEX.lock().unwrap_or_else(|e| e.into_inner());
let _endpoint_guard = EnvGuard::set(CODEX_RESPONSES_URL_ENV, None);
let _base_guard = EnvGuard::set(CODEX_BASE_URL_ENV, None);
@@ -959,6 +967,7 @@ mod tests {
#[test]
fn resolve_reasoning_effort_prefers_configured_override() {
let _lock = ENV_MUTEX.lock().unwrap_or_else(|e| e.into_inner());
let _guard = EnvGuard::set("ZEROCLAW_CODEX_REASONING_EFFORT", Some("low"));
assert_eq!(
resolve_reasoning_effort("gpt-5-codex", Some("high")),
@@ -968,6 +977,7 @@ mod tests {
#[test]
fn resolve_reasoning_effort_uses_legacy_env_when_unconfigured() {
let _lock = ENV_MUTEX.lock().unwrap_or_else(|e| e.into_inner());
let _guard = EnvGuard::set("ZEROCLAW_CODEX_REASONING_EFFORT", Some("minimal"));
assert_eq!(
resolve_reasoning_effort("gpt-5-codex", None),
+3 -3
View File
@@ -1236,7 +1236,7 @@ mod tests {
#[cfg(not(target_os = "windows"))]
#[test]
fn run_capture_reads_stdout() {
let out = run_capture(Command::new("sh").args(["-lc", "echo hello"]))
let out = run_capture(Command::new("sh").args(["-c", "echo hello"]))
.expect("stdout capture should succeed");
assert_eq!(out.trim(), "hello");
}
@@ -1244,7 +1244,7 @@ mod tests {
#[cfg(not(target_os = "windows"))]
#[test]
fn run_capture_falls_back_to_stderr() {
let out = run_capture(Command::new("sh").args(["-lc", "echo warn 1>&2"]))
let out = run_capture(Command::new("sh").args(["-c", "echo warn 1>&2"]))
.expect("stderr capture should succeed");
assert_eq!(out.trim(), "warn");
}
@@ -1252,7 +1252,7 @@ mod tests {
#[cfg(not(target_os = "windows"))]
#[test]
fn run_checked_errors_on_non_zero_status() {
let err = run_checked(Command::new("sh").args(["-lc", "exit 17"]))
let err = run_checked(Command::new("sh").args(["-c", "exit 17"]))
.expect_err("non-zero exit should error");
assert!(err.to_string().contains("Command failed"));
}
+8 -2
View File
@@ -106,8 +106,14 @@ impl SkillCreator {
// Trim leading/trailing hyphens, then truncate.
let trimmed = collapsed.trim_matches('-');
if trimmed.len() > 64 {
// Truncate at a hyphen boundary if possible.
let truncated = &trimmed[..64];
// Find the nearest valid character boundary at or before 64 bytes.
let safe_index = trimmed
.char_indices()
.map(|(i, _)| i)
.take_while(|&i| i <= 64)
.last()
.unwrap_or(0);
let truncated = &trimmed[..safe_index];
truncated.trim_end_matches('-').to_string()
} else {
trimmed.to_string()
-1
View File
@@ -6,7 +6,6 @@ import {
ChevronRight,
Terminal,
Package,
ChevronsUpDown,
} from 'lucide-react';
import type { ToolSpec, CliTool } from '@/types/api';
import { getTools, getCliTools } from '@/lib/api';