357186ab7e
In the commit d8bf2810ff we hoisted
the userOptionFields array to a module-level variable, but kept
the code inside save() the same. This causes an issue where if
save() is called twice on the same user with some array of user
option fields, the userOptionFields array is mutated, which means
the second save is likely not saving the fields intended.
This commit fixes the issue by not mutating the array. We cannot
change them into consts though, because we have an API to add more
items to the array.
128 lines
3.7 KiB
JavaScript
128 lines
3.7 KiB
JavaScript
import * as ajaxlib from "discourse/lib/ajax";
|
|
import { module, test } from "qunit";
|
|
import sinon from "sinon";
|
|
import Group from "discourse/models/group";
|
|
import User from "discourse/models/user";
|
|
|
|
module("Unit | Model | user", function () {
|
|
test("staff", function (assert) {
|
|
let user = User.create({ id: 1, username: "eviltrout" });
|
|
|
|
assert.ok(!user.get("staff"), "user is not staff");
|
|
|
|
user.toggleProperty("moderator");
|
|
assert.ok(user.get("staff"), "moderators are staff");
|
|
|
|
user.setProperties({ moderator: false, admin: true });
|
|
assert.ok(user.get("staff"), "admins are staff");
|
|
});
|
|
|
|
test("searchContext", function (assert) {
|
|
let user = User.create({ id: 1, username: "EvilTrout" });
|
|
|
|
assert.deepEqual(
|
|
user.get("searchContext"),
|
|
{ type: "user", id: "eviltrout", user },
|
|
"has a search context"
|
|
);
|
|
});
|
|
|
|
test("isAllowedToUploadAFile", function (assert) {
|
|
let user = User.create({ trust_level: 0, admin: true });
|
|
assert.ok(
|
|
user.isAllowedToUploadAFile("image"),
|
|
"admin can always upload a file"
|
|
);
|
|
|
|
user.setProperties({ admin: false, moderator: true });
|
|
assert.ok(
|
|
user.isAllowedToUploadAFile("image"),
|
|
"moderator can always upload a file"
|
|
);
|
|
});
|
|
|
|
test("canMangeGroup", function (assert) {
|
|
let user = User.create({ admin: true });
|
|
let group = Group.create({ automatic: true });
|
|
|
|
assert.strictEqual(
|
|
user.canManageGroup(group),
|
|
false,
|
|
"automatic groups cannot be managed."
|
|
);
|
|
|
|
group.set("automatic", false);
|
|
group.setProperties({ can_admin_group: true });
|
|
|
|
assert.strictEqual(
|
|
user.canManageGroup(group),
|
|
true,
|
|
"an admin should be able to manage the group"
|
|
);
|
|
|
|
user.set("admin", false);
|
|
group.setProperties({ is_group_owner: true });
|
|
|
|
assert.strictEqual(
|
|
user.canManageGroup(group),
|
|
true,
|
|
"a group owner should be able to manage the group"
|
|
);
|
|
});
|
|
|
|
test("resolvedTimezone", function (assert) {
|
|
const tz = "Australia/Brisbane";
|
|
let user = User.create({ timezone: tz, username: "chuck", id: 111 });
|
|
|
|
sinon.stub(moment.tz, "guess").returns("America/Chicago");
|
|
sinon.stub(ajaxlib.ajax);
|
|
let spy = sinon.spy(ajaxlib, "ajax");
|
|
|
|
assert.strictEqual(
|
|
user.resolvedTimezone(user),
|
|
tz,
|
|
"if the user already has a timezone return it"
|
|
);
|
|
assert.ok(
|
|
spy.notCalled,
|
|
"if the user already has a timezone do not call AJAX update"
|
|
);
|
|
user = User.create({ username: "chuck", id: 111 });
|
|
assert.strictEqual(
|
|
user.resolvedTimezone(user),
|
|
"America/Chicago",
|
|
"if the user has no timezone guess it with moment"
|
|
);
|
|
assert.ok(
|
|
spy.calledWith("/u/chuck.json", {
|
|
type: "PUT",
|
|
dataType: "json",
|
|
data: { timezone: "America/Chicago" },
|
|
}),
|
|
"if the user has no timezone save it with an AJAX update"
|
|
);
|
|
|
|
let otherUser = User.create({ username: "howardhamlin", id: 999 });
|
|
assert.strictEqual(
|
|
otherUser.resolvedTimezone(user),
|
|
undefined,
|
|
"if the user has no timezone and the user is not the current user, do NOT guess with moment"
|
|
);
|
|
assert.not(
|
|
spy.calledWith("/u/howardhamlin.json", {
|
|
type: "PUT",
|
|
dataType: "json",
|
|
data: { timezone: "America/Chicago" },
|
|
}),
|
|
"if the user has no timezone, and the user is not the current user, do NOT save it with an AJAX update"
|
|
);
|
|
});
|
|
|
|
test("muted ids", function (assert) {
|
|
let user = User.create({ username: "chuck", muted_category_ids: [] });
|
|
|
|
assert.deepEqual(user.calculateMutedIds(0, 1, "muted_category_ids"), [1]);
|
|
assert.deepEqual(user.calculateMutedIds(1, 1, "muted_category_ids"), []);
|
|
});
|
|
});
|